Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-04 Thread joe darcy
Hello, On 12/4/2014 4:34 PM, David Holmes wrote: Hi Staffan, On 2/12/2014 10:08 AM, Staffan Friberg wrote: Hi, Hopefully this is the right list for this discussion. As part of adding Microbenchmarks to the OpenJDK source tree, I'm trying to understand how we best would add the benchmark sour

Re: Confirming JDK 8 GA version

2014-12-04 Thread Medi Montaseri
Thank you very much David and Erik for clarifying these issues for me. Looks like we all believe it doing it right, doing it once. I am impressed. Good job Medi On 12/04/2014 04:41 PM, David Holmes wrote: Just to further clarify things, the hotspot version is set in the build files: jdk8/hotsp

Re: Confirming JDK 8 GA version

2014-12-04 Thread David Holmes
Just to further clarify things, the hotspot version is set in the build files: jdk8/hotspot/make/hotspot_version HS_MAJOR_VER=25 HS_MINOR_VER=0 HS_BUILD_NUMBER=70 so that is why you see it in your local build. The JDK version string, as Erik says, takes on values based on configure arguments

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-04 Thread David Holmes
Hi Staffan, On 2/12/2014 10:08 AM, Staffan Friberg wrote: Hi, Hopefully this is the right list for this discussion. As part of adding Microbenchmarks to the OpenJDK source tree, I'm trying to understand how we best would add the benchmark sources to the existing OpenJDK tree structure. Is th

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-04 Thread mark . reinhold
2014/12/4 9:51 -0800, staffan.frib...@oracle.com: > On 12/03/2014 02:58 AM, Magnus Ihse Bursie wrote: >> ... >> >> My suggestion is that the microbenchmarks are put in the top-level >> repo, if only for the reason that it seems fully possible to split >> them out to a separate repo some time in

Re: [9] RFR (XS) 8066508: JTReg tests timeout on slow devices when run using JPRT

2014-12-04 Thread David Holmes
Hi Chris, Sorry I mis-directed you to send this one to build-dev, as it is a hotspot test/Makefile fix it should be reviewed by hotspot-dev now cc'd. Fix looks good to me. Thanks, David On 5/12/2014 6:37 AM, Chris Plummer wrote: Please review the following fix to address JPRT timeout issues

Re: [9] RFR (XS) 8066507: JPRT is not capable of running jtreg tests located jdk/test

2014-12-04 Thread David Holmes
Looks good! Thanks for fixing. David On 5/12/2014 6:37 AM, Chris Plummer wrote: Please review the following fix to allow running jdk jtreg tests using JPRT -rtests. This is the same fix that his been in place in hotspot/test/Makefile for a while now, so I just copied from there to jdk/test/Mak

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-04 Thread David Holmes
Thanks Erik. Once 8u/dev is open for 8u60 I'll request push approval. David On 4/12/2014 6:53 PM, Erik Joelsson wrote: Looks good to me. /Erik On 2014-12-04 04:16, David Holmes wrote: Updated webrev: http://cr.openjdk.java.net/~dholmes/8038189/webrev.jdk.v2/ Only changes are to profile-inc

Re: [9] RFR (XS) 8066507: JPRT is not capable of running jtreg tests located jdk/test

2014-12-04 Thread Tim Bell
Hi Chris: Please review the following fix to allow running jdk jtreg tests using JPRT -rtests. This is the same fix that his been in place in hotspot/test/Makefile for a while now, so I just copied from there to jdk/test/Makefile. https://bugs.openjdk.java.net/browse/JDK-8066507 http://cr.op

[9] RFR (XS) 8066508: JTReg tests timeout on slow devices when run using JPRT

2014-12-04 Thread Chris Plummer
Please review the following fix to address JPRT timeout issues when using -rtests to run hotspot JTReg tests on slow devices. The same logic has been in place for jdk/test/Makefile for a while now, so I just copied from there to hotspot/test/Makefile. https://bugs.openjdk.java.net/browse/JDK-8

[9] RFR (XS) 8066507: JPRT is not capable of running jtreg tests located jdk/test

2014-12-04 Thread Chris Plummer
Please review the following fix to allow running jdk jtreg tests using JPRT -rtests. This is the same fix that his been in place in hotspot/test/Makefile for a while now, so I just copied from there to jdk/test/Makefile. https://bugs.openjdk.java.net/browse/JDK-8066507 http://cr.openjdk.java.n

Re: Adding Microbenchmarks to the JDK forest/trees (JEP-230)

2014-12-04 Thread Staffan Friberg
On 12/03/2014 02:58 AM, Magnus Ihse Bursie wrote: On 2014-12-02 23:45, Christian Thalinger wrote: On Dec 2, 2014, at 2:40 PM, Jonathan Gibbons wrote: Staffan, That seems to put it on the low end for reasonably being its own repo, if you wanted that, at least, as indicated by the numbers. D

RFR(XS): 8066589: Make importing sa-jdi.jar optional on its existance

2014-12-04 Thread Volker Simonis
Hi, could you please review this tiny change which fixes the build on platforms which don't built the SA agent after the recent modualrity integrations: http://cr.openjdk.java.net/~simonis/webrevs/8066589 https://bugs.openjdk.java.net/browse/JDK-8066589 I've tested that the fix works on AIX but

Re: RFR [JEP 220] Modular Run-Time Images - compact profiles footprint

2014-12-04 Thread Alan Bateman
On 04/12/2014 16:38, Naoto Sato wrote: Quick question. Why is jdk.localedata module included in the compact profiles? The data there used to be in lib/ext/localedata.jar and lib/ext/cldrdata.jar which weren't included in those compact profiles. Naoto The "profiles" make target on JDK 8 (and JD

Re: RFR [JEP 220] Modular Run-Time Images

2014-12-04 Thread Magnus Ihse Bursie
On 2014-11-20 22:39, Chris Hegarty wrote: This is a review request for the changes for JEP 220: Modular Run-Time Images [1]. There are a number of individuals responsible for these changes. Some, possibly not all, are explicitly listed in the 'To' section of this mail, and they will help add

Re: RFR [JEP 220] Modular Run-Time Images - fix zero build

2014-12-04 Thread Xerxes Rånby
Hi Chris! The build changes introduced a new dependency that sa-jdi.jar is always built. The sa-jdi.jar do not get built for Zero and Itanium builds. Zero is built using the --with-jvm-interpreter=cpp --with-jvm-variants=zero configure options. The sa-jdi.jar also do not exist if you use t

Re: RFR [JEP 220] Modular Run-Time Images - compact profiles footprint

2014-12-04 Thread Naoto Sato
Quick question. Why is jdk.localedata module included in the compact profiles? The data there used to be in lib/ext/localedata.jar and lib/ext/cldrdata.jar which weren't included in those compact profiles. Naoto On 12/4/14, 5:48 AM, Alan Bateman wrote: On 04/12/2014 12:58, Xerxes Rånby wrote:

Re: RFR [JEP 220] Modular Run-Time Images - compact profiles footprint

2014-12-04 Thread Alan Bateman
On 04/12/2014 12:58, Xerxes Rånby wrote: The footprint of the compact profiles have been inflated by ~12Mb each after the JEP 220 changes. before # du -s -h j2re-compact1-image 17.9Mj2re-compact1-image # du -s -h j2re-compact2-image 28.7Mj2re-compact2-image # du -s -h j2re-compact3-imag

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-04 Thread Erik Joelsson
Looks good to me. /Erik On 2014-12-04 04:16, David Holmes wrote: Updated webrev: http://cr.openjdk.java.net/~dholmes/8038189/webrev.jdk.v2/ Only changes are to profile-includes.txt. Thanks, David On 2/12/2014 2:24 PM, David Holmes wrote: Erik, Many thanks for the makefile macro wizardry!

Re: Confirming JDK 8 GA version

2014-12-04 Thread Erik Joelsson
On 2014-12-03 21:54, Medi Montaseri wrote: Thanks David and Erik, A bit more confused...I don't know what hotspot is. Hotspot is the jvm, basically libjvm.so (and a few of the support libs) and has historically been treated as a separate project from the rest of the jdk. Because of that it ha