Review request: JDK-8067360: verify-modules target was dropped in jdk9 b41

2014-12-12 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8067360/webrev.00/ This patch adds back the verify-modules target to the dependences of the images target that got dropped in the merge and hides a bug in jdeps -Xverify:access. Erik - I notice make/Javadoc.gmk that sets -bootclasspath

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

2014-12-12 Thread Tristan Yan
Thanks Joe answering this. Updated webrev by changing jaxp_test to jaxp_all, Also correct “Jaxp" as “JAXP”. http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.01/ http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.02/

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

2014-12-12 Thread huizhe wang
On 12/12/2014 2:45 AM, Alan Bateman wrote: On 11/12/2014 21:10, Tristan Yan wrote: Thanks Alan and Joe I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit. http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/

Re: RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2014-12-12 Thread Severin Gehwolf
On Fri, 2014-12-12 at 06:41 -0800, Tim Bell wrote: > Thanks, Erik > > The change looks good to me as well. > > Tim Thanks, all! Cheers, Severin > On 12/12/14 06:31, Erik Joelsson wrote: > > I can push it. > > > > /Erik > > > > On 2014-12-12 15:12, Volker Simonis wrote: > >> Hi Severin, > >> >

Re: RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2014-12-12 Thread Tim Bell
Thanks, Erik The change looks good to me as well. Tim On 12/12/14 06:31, Erik Joelsson wrote: I can push it. /Erik On 2014-12-12 15:12, Volker Simonis wrote: Hi Severin, the change looks good to me and it only affects the ZERO build so there's no risk to influene any other platform. Unfor

Re: RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2014-12-12 Thread Erik Joelsson
I can push it. /Erik On 2014-12-12 15:12, Volker Simonis wrote: Hi Severin, the change looks good to me and it only affects the ZERO build so there's no risk to influene any other platform. Unfortunately I can not push it because it requires the regeneration of 'common/autoconf/generated-conf

Re: RFR: JDK-8067254: No debug symbols in JPRT Windows builds

2014-12-12 Thread Tim Bell
Hi Erik: Please review this fix which returns debug info files to the windows images. In the modular image change I mistakenly filtered out the debug info files (by comparing the new images/jdk/bin dir with the old images/j2sdk-image/bin dir instead of images/j2sdk-image/jre/bin where the fil

Re: RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2014-12-12 Thread Volker Simonis
Hi Severin, the change looks good to me and it only affects the ZERO build so there's no risk to influene any other platform. Unfortunately I can not push it because it requires the regeneration of 'common/autoconf/generated-configure.sh'. So you still need a sponsor from within Oracle. Regards,

RFR: JDK-8067254: No debug symbols in JPRT Windows builds

2014-12-12 Thread Erik Joelsson
Hello, Please review this fix which returns debug info files to the windows images. In the modular image change I mistakenly filtered out the debug info files (by comparing the new images/jdk/bin dir with the old images/j2sdk-image/bin dir instead of images/j2sdk-image/jre/bin where the files

RFR(S): 8067330 : ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2014-12-12 Thread Severin Gehwolf
Hi, Could someone please review and sponsor this fix for JDK-8067330? In particular, the hotspot build expects either PPC64 or PPC32 to be defined (hotspot/src/share/vm/utilities/macros.hpp:366) and if one of them is indeed defined PPC gets defined as well. However if neither of the two is defined

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

2014-12-12 Thread Alan Bateman
On 11/12/2014 21:10, Tristan Yan wrote: Thanks Alan and Joe I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit. http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/ http://cr.ope