Re: RFR: JDK-8067254: No debug symbols in JPRT Windows builds

2014-12-13 Thread David Holmes
Hi Erik, Looks okay to me too. David On 13/12/2014 12:08 AM, Erik Joelsson wrote: Hello, Please review this fix which returns debug info files to the windows images. In the modular image change I mistakenly filtered out the debug info files (by comparing the new images/jdk/bin dir with the ol

Re: Review request: JDK-8067360: verify-modules target was dropped in jdk9 b41

2014-12-13 Thread Alan Bateman
On 12/12/2014 18:25, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8067360/webrev.00/ This patch adds back the verify-modules target to the dependences of the images target that got dropped in the merge and hides a bug in jdeps -Xverify:access. Erik - I notice ma

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

2014-12-13 Thread Alan Bateman
On 12/12/2014 18:10, Tristan Yan wrote: Thanks Joe answering this. Updated webrev by changing jaxp_test to jaxp_all, Also correct “Jaxp" as “JAXP”. http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.01/ http://cr.openjdk.j