Building openjdk8 - was Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Toby Thain
On 12/01/15 10:28 AM, David DeHaven wrote: It won't build at all with Xcode 5, there is no gcc compiler and the clang changes were never backported to jdk8u. Yes. I believe those who have done this on Mavericks (including me) are using the apple-gcc4.2 binaries (e.g. the one that brew can i

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread David Holmes
On 13/01/2015 5:20 AM, Alex Strange wrote: On Jan 12, 2015, at 3:26 AM, David Holmes wrote: cc'ing macosx-port-dev and hotspot-dev On 12/01/2015 8:41 PM, Erik Joelsson wrote: On 2015-01-12 00:02, David Holmes wrote: Hi David, On 10/01/2015 2:00 AM, David DeHaven wrote: We have this nic

[8u40] Request for review and approval: 8068485: Update references of download.oracle.com to docs.oracle.com in javadoc makefile

2015-01-12 Thread Bhavesh Patel
Hi, In the javadoc makefile, there are references to http://download.oracle.com. This automatically gets redirected to http://docs.oracle.com. These references needs to be updated to point to https://docs.oracle.com. JBS: https://bugs.openjdk.java.net/browse/JDK-8068485 Webrev: http://cr.op

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread Alex Strange
> On Jan 12, 2015, at 3:26 AM, David Holmes wrote: > > cc'ing macosx-port-dev and hotspot-dev > > On 12/01/2015 8:41 PM, Erik Joelsson wrote: >> >> On 2015-01-12 00:02, David Holmes wrote: >>> Hi David, >>> >>> On 10/01/2015 2:00 AM, David DeHaven wrote: We have this nice little co

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-12 Thread Alan Bateman
On 12/01/2015 20:50, Sergey Bylokhov wrote: On 12.01.2015 23:42, Alan Bateman wrote: On 12/01/2015 20:29, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. In the fix a sun.datatransfer and a java.awt.datatransfer packages were moved to the separate module java.datatransfer. But sun

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-12 Thread Sergey Bylokhov
On 12.01.2015 23:42, Alan Bateman wrote: On 12/01/2015 20:29, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. In the fix a sun.datatransfer and a java.awt.datatransfer packages were moved to the separate module java.datatransfer. But sun.awt.datatransfer still located in java.deskt

Re: [9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-12 Thread Alan Bateman
On 12/01/2015 20:29, Sergey Bylokhov wrote: Hello. Please review a fix for jdk 9. In the fix a sun.datatransfer and a java.awt.datatransfer packages were moved to the separate module java.datatransfer. But sun.awt.datatransfer still located in java.desktop. I tested full jdk(all modules include

[9] Review Request: 8056298 Separate java.awt.datatransfer from the desktop module

2015-01-12 Thread Sergey Bylokhov
Hello. Please review a fix for jdk 9. In the fix a sun.datatransfer and a java.awt.datatransfer packages were moved to the separate module java.datatransfer. But sun.awt.datatransfer still located in java.desktop. I tested full jdk(all modules included) on osx using a jck, and it works without

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread David DeHaven
I don't know why Hotspot is packaged as a universal binary. In the jdk, only libJObjC was built as a universal binary and that lib was removed before JDK 8 shipped. What part of Macosx would need to interact directly with libjvm.dylib in a way that required a (fake) universal >

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread Daniel D. Daugherty
On 1/12/15 8:17 AM, David DeHaven wrote: We have this nice little comment in common/autoconf/jdk-options.m4: # On Macosx universal binaries are produced, but they only contain # 64 bit intel. This invalidates control of which jvms are built # from configure, but only server is valid anyw

Re: Fix currency-related build failure starting 12/31/2014

2015-01-12 Thread Naoto Sato
Hi Chris, Thank you for reporting this problem. We are aware of this issue and will be fixed in the next update release. Naoto On 12/30/14, 1:16 PM, Chris Metcalf wrote: Our JDK 1.6 and 1.7 builds began failing today with the message "Error: time is more than 10 years from present: 110453040

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
> The --with-xcode-path argument is optional, you should also be able to build > with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I > leave MAS managed Xcode (currently 6) active as I'm constantly bouncing > between projects and it's a hassle to have to remember to res

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Erik Joelsson
I'm happy with that answer. Thanks! /Erik On 2015-01-12 17:25, David DeHaven wrote: Or rather, the point of this exercise is to eliminate the hacks to get it to build with Xcode 5 (I'm not sure if anyone was truly successful with that). It's far better to just build with Xcode 4.6.3, and with

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
Or rather, the point of this exercise is to eliminate the hacks to get it to build with Xcode 5 (I'm not sure if anyone was truly successful with that). It's far better to just build with Xcode 4.6.3, and with these changes you don't even need to pre-sanitize your Xcode environment. A proper b

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread David DeHaven
It won't build at all with Xcode 5, there is no gcc compiler and the clang changes were never backported to jdk8u. -DrD- > Hello, > > These changes look ok to me. > > With these changes, configure will unconditionally fail if trying to use > XCode 5. I know we don't officially support using

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread David DeHaven
We have this nice little comment in common/autoconf/jdk-options.m4: # On Macosx universal binaries are produced, but they only contain # 64 bit intel. This invalidates control of which jvms are built # from configure, but only server is valid anyway. Fix this # whe

Fix currency-related build failure starting 12/31/2014

2015-01-12 Thread Chris Metcalf
Our JDK 1.6 and 1.7 builds began failing today with the message "Error: time is more than 10 years from present: 110453040". At midnight Turkish time on Dec 31, 2004, the new Turkish lira (TRY) replaced the old lira (TRL) at 1,000,000:1. You may note that this was exactly 10 years ago tod

Re: RFR 8068650: https://bugs.openjdk.java.net/browse/JDK-8068650

2015-01-12 Thread Hannes Wallnoefer
+1 Am 2015-01-08 um 07:52 schrieb A. Sundararajan: Hi, Please review http://cr.openjdk.java.net/~sundar/8068650/ for https://bugs.openjdk.java.net/browse/JDK-8068650 This issue was caused by another makefile fix to generate docs for nashorn. I'm cc'ing nashorn-dev and jdk8u-dev as the fix h

Re: RFR: AARCH64: Top-level JDK changes

2015-01-12 Thread Magnus Ihse Bursie
On 2015-01-12 05:31, Dean Long wrote: I found a small problem with the new config.sub wrapper. It works with the bash shell but not with the dash shell. The problem seems to be with this line: result=`. $DIR/autoconf-config.sub $sub_args "$@"` "dash" doesn't seem to support args passed wi

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-12 Thread Tim Bell
Erik: Looks good to me. Thanks for picking this up - I struggled with the problem for months. Tim Please review this patch, which adds support for building with different versions of Visual Studio and in particular adds support for VS2013. In order to control which version to use, I've int

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread David Holmes
cc'ing macosx-port-dev and hotspot-dev On 12/01/2015 8:41 PM, Erik Joelsson wrote: On 2015-01-12 00:02, David Holmes wrote: Hi David, On 10/01/2015 2:00 AM, David DeHaven wrote: We have this nice little comment in common/autoconf/jdk-options.m4: # On Macosx universal binaries are produce

Re: De-universalizing hotspot in jdk8u

2015-01-12 Thread Erik Joelsson
On 2015-01-12 00:02, David Holmes wrote: Hi David, On 10/01/2015 2:00 AM, David DeHaven wrote: We have this nice little comment in common/autoconf/jdk-options.m4: # On Macosx universal binaries are produced, but they only contain # 64 bit intel. This invalidates control of which jvms ar

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-12 Thread Erik Joelsson
Hello, These changes look ok to me. With these changes, configure will unconditionally fail if trying to use XCode 5. I know we don't officially support using XCode 5 for JDK 8, but aren't people working around it with some patches? How hard would it be to make it at least build? /Erik On

Re: RFR: AARCH64: Top-level JDK changes

2015-01-12 Thread Andrew Haley
On 12/01/15 04:31, Dean Long wrote: > I found a small problem with the new config.sub wrapper. It works with > the bash shell but not with the dash shell. > The problem seems to be with this line: > > result=`. $DIR/autoconf-config.sub $sub_args "$@"` > > "dash" doesn't seem to support arg

Re: JDK 9 RFR of JDK-8067099: Add deprecation lint warning to build of jdk repository

2015-01-12 Thread Erik Joelsson
Looks good to me. /Erik On 2015-01-10 01:55, joe darcy wrote: Hello, Catching up on email after the holidays... On 12/9/2014 10:39 PM, Erik Joelsson wrote: First, congratulations on almost being done fixing all the warnings! When removing the last warning exception, perhaps it's time to ch