Re: RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile

2015-01-14 Thread David Holmes
On 15/01/2015 4:40 PM, Dean Long wrote: On 1/14/2015 10:31 PM, David Holmes wrote: Hi Dean, Code reviews don't go to jdk9-dev. Build-infra is not relevant to this either. You only need hotspot-dev for a hotspot build issue (though build-dev might be useful for more complex changes). OK. Tha

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread David Holmes
On 15/01/2015 6:23 AM, David DeHaven wrote: Can someone from hotspot-dev please look at the hotspot changes? Looks okay to me. Thanks, David H. -DrD- Hello, This looks good to me. Thanks for the detailed table! /Erik On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argu

AARCH64: RFR (XS) 8068927: AARCH64: better handling of aarch64- triples (was RFR: AARCH64: Top-level JDK changes)

2015-01-14 Thread Dean Long
Can I get a review for this? https://bugs.openjdk.java.net/browse/JDK-8068927 http://cr.openjdk.java.net/~dlong/8068927/webrev/ thanks, dl On 1/13/2015 10:56 AM, Dean Long wrote: On 1/13/2015 1:08 AM, Andrew Haley wrote: On 13/01/15 08:44, Dean Long wrote: I came up with a simpler version,

Re: RFR: JDK-8068902: Solaris build fails with new 10u10 devkit

2015-01-14 Thread Tim Bell
Hello Erik: Please review this small patch, which moves the SYSROOT_CFLAGS and SYSROOT_LDFLAGS to the back of the compiler and linker command lines. On linux, this shouldn't matter as we don't need to override the --sysroot option. On Solaris, such an option does not exist, but instead we set

Re: RFR: AARCH64: Top-level JDK changes

2015-01-14 Thread Dean Long
On 1/14/2015 5:27 AM, Magnus Ihse Bursie wrote: On 2015-01-13 09:32, Dean Long wrote: On 1/12/2015 3:49 AM, Magnus Ihse Bursie wrote: On 2015-01-12 05:31, Dean Long wrote: I found a small problem with the new config.sub wrapper. It works with the bash shell but not with the dash shell. The p

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread David DeHaven
Can someone from hotspot-dev please look at the hotspot changes? -DrD- > Hello, > > This looks good to me. Thanks for the detailed table! > > /Erik > > On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argument is optional, you should also be able to build with Xcode

RFR: JDK-8068902: Solaris build fails with new 10u10 devkit

2015-01-14 Thread Erik Joelsson
Hello, Please review this small patch, which moves the SYSROOT_CFLAGS and SYSROOT_LDFLAGS to the back of the compiler and linker command lines. On linux, this shouldn't matter as we don't need to override the --sysroot option. On Solaris, such an option does not exist, but instead we set an e

RE: Problems building jdk8 in Windows - stalls at hotspot, surprisingly continues, refuses to link

2015-01-14 Thread Mads Bondo Dydensborg
Thanks, Roger, have installed, is testing. It still stalls though, so I will have to return on the linker issues later. Thanks, Mads Mads Bondo Dydensborg Senior Software Architect Development Programs Terma A/S -Original Message- From: build-dev [mailto:build-dev-boun...@openjdk.java

Re: Problems building jdk8 in Windows - stalls at hotspot, surprisingly continues, refuses to link

2015-01-14 Thread Roger Riggs
Hi, I saw that error message "COFF: file invalid or corrupt" using VS 2010 before I installed the Visual Studio 2010_x86_sp1. Worked ok after. $.02, Roger On 1/14/2015 9:35 AM, Mads Bondo Dydensborg wrote: Hi there I am trying to build jdk8 on Windows 7 64 bit, using cygwin and MS Visual St

Problems building jdk8 in Windows - stalls at hotspot, surprisingly continues, refuses to link

2015-01-14 Thread Mads Bondo Dydensborg
Hi there I am trying to build jdk8 on Windows 7 64 bit, using cygwin and MS Visual Studio Express. I am pretty experienced in building stuff in Unix/Linux, but Windows is new to me. Principally, I am using the guide at http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html, but f

Re: [8u40] Request for review and approval: 8068485: Update references of download.oracle.com to docs.oracle.com in javadoc makefile

2015-01-14 Thread Seán Coffey
Hi Bhavesh, Approved for jdk8u-dev. I'll help push this patch and the other 2 doc related ones (8068491, 8068495) to jdk8u-dev. I'll also work with you on getting these into 8u40. regards, Sean. On 13/01/15 08:05, Erik Joelsson wrote: Looks good to me. /Erik On 2015-01-13 00:40, Bhavesh P

Re: RFR: AARCH64: Top-level JDK changes

2015-01-14 Thread Magnus Ihse Bursie
On 2015-01-13 09:32, Dean Long wrote: On 1/12/2015 3:49 AM, Magnus Ihse Bursie wrote: On 2015-01-12 05:31, Dean Long wrote: I found a small problem with the new config.sub wrapper. It works with the bash shell but not with the dash shell. The problem seems to be with this line: result=`.

Re: [PATCH] Fix Shark build in JDK9

2015-01-14 Thread Erik Joelsson
On 2015-01-14 08:22, David Holmes wrote: Hi Roman, On 14/01/2015 7:41 AM, Roman Kennke wrote: Ok I think I found a way to avoid copying the whole #define block just for one line. I define that line before (and empty in case of SHARK) and use that inside the big #define. http://cr.openjdk.java

Re: [8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

2015-01-14 Thread Erik Joelsson
Hello, This looks good to me. Thanks for the detailed table! /Erik On 2015-01-14 04:09, David DeHaven wrote: The --with-xcode-path argument is optional, you should also be able to build with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I leave MAS managed Xcode (curr