Looks good, thanks for fixing this!
Brad
On 1/15/2015 3:05 AM, Erik Joelsson wrote:
Hello,
Please review the open part of this patch, which changes the building of
policy jars to happen even if BUILD_CRYPTO is false. Previously these
weren't built as there were signed versions of these jars
On 2015-01-15 08:01, David Holmes wrote:
If the build-dev guys confirm we already assume bash that is fine.
For the rest of the world, we only use bash. For hotspot, we will use
bash if called from the top-level Makefile. I can't say anything about
what the convention have been for calling t
On 2015-01-15 10:21, Erik Joelsson wrote:
Hello,
Please review this small patch which fixes bootcycle-images builds
when enabling sjavac. The problem was that the directory where the
portfile should be created is never created in the bootcycle-build
output directory. I think the best and simp
On 1/15/2015 5:41 AM, Magnus Ihse Bursie wrote:
On 2015-01-15 00:34, Dean Long wrote:
Can I get a review for this?
https://bugs.openjdk.java.net/browse/JDK-8068927
http://cr.openjdk.java.net/~dlong/8068927/webrev/
Looks good to me. (However, I'm not a formal reviewer for the
aarch64-port pro
Hi Magnus,
I've only had a quick look at your changes but I have a question.
When looking at the "make help" I think the relationship between
"repo", "target" and "module" is a little unclear.
As far as I understand a "target" is an artefact which can be named
and build by "make".
A "repo" is a
Looks good to me.
/Erik
On 2015-01-15 16:23, Magnus Ihse Bursie wrote:
This fix is the result of preparatory work in the build-infra
project. It includes:
* Remove duplicate detection of comm on Windows
* compare.sh enhancements and bug fixes
* Do not fail in SetupFoo macros on empty argument
This fix is the result of preparatory work in the build-infra project.
It includes:
* Remove duplicate detection of comm on Windows
* compare.sh enhancements and bug fixes
* Do not fail in SetupFoo macros on empty arguments
* Minor JavaCompilation enhancements
* Makefile warns for unknown contro
Looks good to me.
/Erik
On 2015-01-15 15:34, Magnus Ihse Bursie wrote:
JDK-8066769 fixed most, but unfortunately not all, of the merge errors
following Jigsaw M2.
This is a trivial logging failure in Native Compilation.
Bug: https://bugs.openjdk.java.net/browse/JDK-8069063
WebRev:
http://cr
Looks good to me.
/Erik
On 2015-01-15 14:46, Magnus Ihse Bursie wrote:
It turns out that our effort to make sure the configure script is run
by bash is not fool-proof.
The fix is to set CONFIG_SHELL ahead of calling the autoconf script.
Thanks to Dean Long for finding out the issue and testi
JDK-8066769 fixed most, but unfortunately not all, of the merge errors
following Jigsaw M2.
This is a trivial logging failure in Native Compilation.
Bug: https://bugs.openjdk.java.net/browse/JDK-8069063
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8069063-more-jigsaw-merge-errors/webrev.01
/
It turns out that our effort to make sure the configure script is run by
bash is not fool-proof.
The fix is to set CONFIG_SHELL ahead of calling the autoconf script.
Thanks to Dean Long for finding out the issue and testing the patch with
dash.
Bug: https://bugs.openjdk.java.net/browse/JDK-8
On 2015-01-14 23:02, Dean Long wrote:
On 1/14/2015 5:27 AM, Magnus Ihse Bursie wrote:
On 2015-01-13 09:32, Dean Long wrote:
On 1/12/2015 3:49 AM, Magnus Ihse Bursie wrote:
On 2015-01-12 05:31, Dean Long wrote:
I found a small problem with the new config.sub wrapper. It works
with the bash sh
On 2015-01-15 00:34, Dean Long wrote:
Can I get a review for this?
https://bugs.openjdk.java.net/browse/JDK-8068927
http://cr.openjdk.java.net/~dlong/8068927/webrev/
Looks good to me. (However, I'm not a formal reviewer for the
aarch64-port project)
/Magnus
On Thu, Jan 15, 2015 at 11:28 AM, Mads Bondo Dydensborg wrote:
> Hi Volker
>
> Thanks a lot for the info. I do not have VS2012, but I do have .NET 4.5.1.
> Installing the SP1 solved my problem, but your reference is very handy for
> other situations. (And, makes me long for the sane world of Lin
Hello,
Please review the open part of this patch, which changes the building of
policy jars to happen even if BUILD_CRYPTO is false. Previously these
weren't built as there were signed versions of these jars, but since we
no longer sign them, there is no need to not build them.
Bug: https://
Hi Volker
Thanks a lot for the info. I do not have VS2012, but I do have .NET 4.5.1.
Installing the SP1 solved my problem, but your reference is very handy for
other situations. (And, makes me long for the sane world of Linux).
RE the stall : Yes, I have anti-virus software running - this is co
Hi Mads,
The COFF isue is a known problem with VS2010 after installing VS2012
or .NET 4.5.1. There exist various workarounds - just google for "LINK
: fatal error LNK1123: failure during conversion to COFF: file
invalid".
The easiest and fastes solution is to remove the bad version of
"cvtres.exe
Hello,
Please review this small patch which fixes bootcycle-images builds when
enabling sjavac. The problem was that the directory where the portfile
should be created is never created in the bootcycle-build output
directory. I think the best and simplest solution is to just always
create it
Thanks, Roger, updating Visual Studio Express to service pack 1 seems to allow
the build to run to completion.
Perhaps this could be suggested in the build guide?
The weird "stall" after:
Generating jvmtifiles/jvmtiEnvRecommended.cpp
Generating jvmtifiles/bytecodeInterpreterWithChecks.cpp
Gene
On 1/14/2015 11:01 PM, David Holmes wrote:
On 15/01/2015 4:40 PM, Dean Long wrote:
On 1/14/2015 10:31 PM, David Holmes wrote:
Hi Dean,
Code reviews don't go to jdk9-dev. Build-infra is not relevant to this
either. You only need hotspot-dev for a hotspot build issue (though
build-dev might be u
20 matches
Mail list logo
