RFR: JDK-8072950: api/xinclude/Harold/harold-97.html\#harold-97, api/xinclude/Harold/harold-67.html\#harold-67 fails on solaris with build port-stage-aarch64

2015-02-12 Thread Erik Joelsson
Hello, Please review this small fix to property cleaning. We normally build on Solaris (11.1) machines with gnu tools installed, including gnu sed so this has not affected official Oracle builds or JPRT. However, we cannot rely on gnu sed always being present so the build should be correct eve

Re: [rfc][jdk7] jhat manpage have corrupted url in see also.

2015-02-12 Thread dalibor topic
On 09.02.2015 16:37, Omair Majid wrote: At this point, only showstopper bugs are being accepted into JDK 7u. Please hold onto this patch until jdk7u80 is released and the repository is open for fixes again. Thanks, Omair - that's the best approach. cheers, dalibor topic --

Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread David Holmes
Please see attached - do we have a minimum gcc version set in configure? If not, should we? I would think yes. David --- Begin Message --- On 12/02/2015 5:28 PM, Thomas Stüfe wrote: On Thu, Feb 12, 2015 at 12:55 AM, David Holmes mailto:david.hol...@oracle.com>> wrote: On 12/02/2015 2:37

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Erik Joelsson
We don't have a minimum version currently. I agree that it would be a good idea, but if we define one, wouldn't we also need to take responsibility of testing that it keeps working? /Erik On 2015-02-12 12:58, David Holmes wrote: Please see attached - do we have a minimum gcc version set in co

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Volker Simonis
Hi, I don't think we should enforce a minimum Version for GCC (actually we would have to enforce an exact version because the master builds at Oracle are only tested with exactly one compiler version - see https://wiki.openjdk.java.net/display/Build/Supported+build+platforms). Different users hav

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Dave Pointon
Hi all , Not that I have any say in this matter, but I concur with Volker and would support his suggestion. ​Rgds ,​ -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Ro

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Thomas Stüfe
Hi, On Thu, Feb 12, 2015 at 2:27 PM, Volker Simonis wrote: > Hi, > > I don't think we should enforce a minimum Version for GCC (actually we > would have to enforce an exact version because the master builds at > Oracle are only tested with exactly one compiler version - see > https://wiki.openjd

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Mario Torre
2015-02-12 14:27 GMT+01:00 Volker Simonis : > Hi, > > I don't think we should enforce a minimum Version for GCC (actually we > would have to enforce an exact version because the master builds at > Oracle are only tested with exactly one compiler version - see > https://wiki.openjdk.java.net/display

Re: RFR: JDK-8072950: api/xinclude/Harold/harold-97.html\#harold-97, api/xinclude/Harold/harold-67.html\#harold-67 fails on solaris with build port-stage-aarch64

2015-02-12 Thread Tim Bell
Erik: Please review this small fix to property cleaning. We normally build on Solaris (11.1) machines with gnu tools installed, including gnu sed so this has not affected official Oracle builds or JPRT. However, we cannot rely on gnu sed always being present so the build should be correct eve

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread David Holmes
On 12/02/2015 11:27 PM, Volker Simonis wrote: Hi, I don't think we should enforce a minimum Version for GCC (actually we would have to enforce an exact version because the master builds at Oracle are only tested with exactly one compiler version - see https://wiki.openjdk.java.net/display/Build/

Re: Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

2015-02-12 Thread Martin Buchholz
Source files should have exactly one trailing newline. find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl -0777 -ne 'print "Must have exactly one trailing newline: $ARGV\n" unless m~[^\n]\Z~s'