On 2/13/15 10:01 AM, Sergey Bylokhov wrote:
http://cr.openjdk.java.net/~serb/8039269/webrev.00/root
http://cr.openjdk.java.net/~serb/8039269/webrev.00/jdk
I looked at java/awt/Cursor.java that looks fine to me
Minor comment on java/awt/Cursor.java
line 166, 167: all caps are usual
Hello.
Please review the fix for jdk 9.
As requested cursor related properties/images were moved from /lib to the
java.desktop.
- Image prefixes were removed because I moved them to the os specific location.
- Windows version of cursors.properties was removed, because it was mostly the
same as
On 13/02/2015 9:08 PM, Volker Simonis wrote:
Hi David,
Thomas' initial change which started this discussion, i.e.
https://bugs.openjdk.java.net/browse/JDK-8072935
http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/
adds the missing newline to src/share/vm/services/writeableFla
Hi Erik,
I've created "CODETOOLS-7901298: jcheck should check that every file
ends with exactly one newline"
(https://bugs.openjdk.java.net/browse/JDK-8072935) and submitted a fix
(http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/)
to the code-tools-...@openjdk.java.net list for
Hi David,
Thomas' initial change which started this discussion, i.e.
https://bugs.openjdk.java.net/browse/JDK-8072935
http://cr.openjdk.java.net/~stuefe/webrevs/8072935/webrev.01/webrev/
adds the missing newline to src/share/vm/services/writeableFlags.cpp.
It should be pushed to jdk9-hs-rt/ (pre
If we are to create such a check, please also include .gmk, .properties,
.m4 and Makefile. In JDK-8072950 I'm adding a workaround for missing
line endings in properties files.
/Erik
On 2015-02-13 11:09, David Holmes wrote:
On 13/02/2015 7:23 PM, Volker Simonis wrote:
Hi,
could somebody plea
On 13/02/2015 7:23 PM, Volker Simonis wrote:
Hi,
could somebody please sponsor and push this change.
Push it to where, as what? I thought you wanted a jcheck addition.
David
Thanks,
Volker
On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz wrote:
Source files should have exactly one trail
Hi,
could somebody please sponsor and push this change.
Thanks,
Volker
On Fri, Feb 13, 2015 at 7:49 AM, Martin Buchholz wrote:
> Source files should have exactly one trailing newline.
>
> find -iregex '.*\.\(java\|txt\|c\|cc\|h\|hpp\|cpp\)$' | xargs perl -0777 -ne
> 'print "Must have exactly o
