Looks good to me too.
dl
On 2/11/2015 12:11 PM, David Holmes wrote:
On 11/02/2015 9:35 PM, Erik Joelsson wrote:
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8072904/webrev.hotspot.02/
On 2015-02-11 10:53, David Holmes wrote:
Hi Erik,
On 11/02/2015 7:23 PM, Erik Joelsson wrote:
Hel
On 17/02/2015 15:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
/Erik
Updated webrev looks good.
-Alan
Erik, the change looks good. Thanks for following up on this one!
-Sherman
On 2/17/15 7:38 AM, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~eri
Erik
On 02/17/15 15:58, Daniel Fuchs wrote:
On 17/02/15 16:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
Thank
Ingemar:
Looks good to me as well.
/Tim
Looks good to me.
/Erik
On 2015-02-17 09:39, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with
jprt is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev:
On 17/02/15 16:38, Erik Joelsson wrote:
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
Thanks Erik.
This one appears to work like a charm
Right, thanks for catching that. The OS specific file is not there for
every OS. This patch should fix it. I'm testing all platforms now.
Webrev: http://cr.openjdk.java.net/~erikj/8073328/webrev.jdk.03/
/Erik
On 2015-02-17 16:24, Daniel Fuchs wrote:
Hi Erik,
I tried to import your patch, and
Hi Erik,
I tried to import your patch, and now the build fails with the
following error:
make[3]: *** No rule to make target
`/Users/danielfuchs/workspaces/jdk/jdk9-dev-java-time/jdk/make/data/charsetmapping/stdcs-macosx',
needed by
`/Users/danielfuchs/workspaces/jdk/jdk9-dev-java-time/build/
I realize that I missed a couple of my own notes on the original review
for JDK-8073152. Here is an update webrev where I address those points
as well.
* Remove unused variable CHARSET_EXTENDED
* Remove use of undefined variable $(CHARSET_EXTENDED_DATA)
However, I opted not to add all the java
On 17/02/2015 14:56, Erik Joelsson wrote:
Hello,
Please review this fix for the incremental build behavior of the
gensrc build step. After JDK-8073152 the charsets would
unconditionally get regenerated each time make was invoked. The actual
culprit was a stray backslash which prevented the 't
Hello,
Please review this fix for the incremental build behavior of the gensrc
build step. After JDK-8073152 the charsets would unconditionally get
regenerated each time make was invoked. The actual culprit was a stray
backslash which prevented the 'touch' on the next line from executing.
I
On 17/02/2015 7:46 PM, Ingemar Aberg wrote:
On 2015-02-17 10:22, David Holmes wrote:
On 17/02/2015 6:39 PM, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with jprt
is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/J
On 2015-02-17 10:22, David Holmes wrote:
On 17/02/2015 6:39 PM, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with jprt
is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev: http://cr.openjdk.java.ne
On 17/02/2015 7:22 PM, David Holmes wrote:
On 17/02/2015 6:39 PM, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with jprt
is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev: http://cr.openjdk.java.n
On 17/02/2015 6:39 PM, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with jprt
is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev: http://cr.openjdk.java.net/~erikj/8073231/webrev.00/
So this is fo
Looks good to me.
/Erik
On 2015-02-17 09:39, Ingemar Aberg wrote:
A convenient way of adding configure options when building JDK with
jprt is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev: http://cr.openjdk.java.net/~erikj/8073231/w
A convenient way of adding configure options when building JDK with jprt
is needed, for example to build colocated tests
Bug: https://bugs.openjdk.java.net/browse/JDK-8073231
Webrev: http://cr.openjdk.java.net/~erikj/8073231/webrev.00/
17 matches
Mail list logo
