Re: RFR 8073596 : Add jdk.management.cmm in boot.modules that needs sun.management.spi be exported to it

2015-03-02 Thread Brent Christian
On 2/28/15 1:18 AM, Alan Bateman wrote: Just a minor comment, we've been keeping the *.modules files in sorted order. Not a big deal but would be good to continue that if you can. Will do. Thanks, Alan -Brent

Re: RFR: JDK-8074048 : Upgrading to ccache 1.3.10 disables the use of ccache

2015-03-02 Thread Steven Loomis
updated webrev (on cr) Bug: https://bugs.openjdk.java.net/browse/JDK-8074048 webrev: http://cr.openjdk.java.net/~srl/8074048/webrev.01/

Re: [8u60] Request for approval to backport: 8067330: ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2015-03-02 Thread Severin Gehwolf
Hi, On Mon, 2015-03-02 at 16:56 +, Seán Coffey wrote: > Hi Severin, > > I'd missed your previous request. It was marked as a review request! Sorry, my bad. > Consider this approved for jdk8u-dev. Can you add a 'noreg-build' label > to the bug report ? Done. > Erik, would you be willing t

Re: [8u60] Request for approval to backport: 8067330: ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2015-03-02 Thread Seán Coffey
Hi Severin, I'd missed your previous request. It was marked as a review request! Consider this approved for jdk8u-dev. Can you add a 'noreg-build' label to the bug report ? Erik, would you be willing to push this changeset to the 8u-dev forest ? Looks like there's some closed code that needs

[8u60] Request for approval to backport: 8067330: ZERO_ARCHDEF incorrectly defined for PPC/PPC64 architectures

2015-03-02 Thread Severin Gehwolf
Hi, I've sent this email before[1], but would like for this backport to get into 8u60 before it closes this month[2]. The patch in question only touches Zero make variables and should be fairly safe to backport. The patch is the same (modulo autogen.sh generation timestamp) as for JDK 9. I'd also

Re: (urgent) RFR: JDK-8074072: Race condition in build since JDK-8072842 can cause failed builds on Solaris

2015-03-02 Thread Magnus Ihse Bursie
On 2015-03-02 10:42, Erik Joelsson wrote: Hello, A race condition, possibly leading to a failed build on Solaris, was introduced with JDK-8072842. Here is a fix adding the necessary dependencies to solve this for now, until the proper solution in JDK-8064808 can be fixed. The fix in Tools.g

RFR: JDK-8074072 Race condition in build since JDK-8072842 can cause failed builds on Solaris

2015-03-02 Thread Magnus Ihse Bursie
A race condition, possibly leading to a failed build on Solaris, was introduced with JDK-8072842. The two Solaris helper script fix_empty_sec_hdr_flags and add_gnu_debuglink are built several times, in the same location. If we are unlucky then thread A does: A1: compile add_gnu_link.c A

RFR: JDK-8074091: Remove dead code from merge mistake in JavaCompilation.gmk

2015-03-02 Thread Erik Joelsson
Hello, In JavaCompilation.gmk, between the definitions of SetupArchive and add_file_to_copy, there is a partial block of code that looks like it shouldn't be there. It seems to be part of the moved SetupZipArchive and has most likely reappeared in JavaCompilation in a merge. The code snippet

(urgent) RFR: JDK-8074072: Race condition in build since JDK-8072842 can cause failed builds on Solaris

2015-03-02 Thread Erik Joelsson
Hello, A race condition, possibly leading to a failed build on Solaris, was introduced with JDK-8072842. Here is a fix adding the necessary dependencies to solve this for now, until the proper solution in JDK-8064808 can be fixed. The fix in Tools.gmk has long been needed, but happened to wo

Re: RFR (M): 8036767 PPC64: Support for little endian execution model

2015-03-02 Thread David Holmes
On 28/02/2015 5:06 AM, Andrew Hughes wrote: - Original Message - On 27/02/2015 11:25 AM, Andrew Hughes wrote: - Original Message - On 26/02/2015 12:31 PM, David Holmes wrote: On 26/02/2015 2:57 AM, Andrew Hughes wrote: These are the revised versions of the webrevs: http:/

Re: RFR 8073596 : Add jdk.management.cmm in boot.modules that needs sun.management.spi be exported to it

2015-03-02 Thread Erik Joelsson
Looks good to me. /Erik On 2015-02-27 21:55, Brent Christian wrote: Hi, Please review a small update to the module config files for a new jdk.management.cmm module. Webrev: http://cr.openjdk.java.net/~bchristi/8073596/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8073596 I also fou

Re: RFR: JDK-8074055 Improvements in compare.sh from build-infra

2015-03-02 Thread Erik Joelsson
Looks good to me. /Erik On 2015-02-27 22:25, Magnus Ihse Bursie wrote: This is a few improvements of the compare.sh script, originally targeted for JDK-8069064. It was forced to be left out at the last moment to avoid costly merge conflicts. :-( Since then JDK-8073965 has modified compare.sh

Re: RFR: JDK-8074048 : Upgrading to ccache 1.3.10 disables the use of ccache

2015-03-02 Thread Erik Joelsson
Looks good to me. Thanks for fixing it! Please remember to run common/bin/autogen.sh and submit both the open and closed generated-configure.sh with this. Same bugid is fine. /Erik On 2015-02-28 01:35, Steven Loomis wrote: Subject was wrong, this is a RFR on 8074048 On 2/27/2015 9:14 AM, St