Re: RFR: JDK-8075140: Solaris build of native libraries not consistently using EXTRA_CFLAGS and EXTRA_LDFLAGS

2015-03-13 Thread David Holmes
Hi Erik, On 14/03/2015 12:08 AM, Erik Joelsson wrote: Hello, While working on the new Hotspot makefiles in build-infra I noticed this problem. When introducing devkits for Solaris, we rely on the variables EXTRA_CFLAGS, EXTRA_CXXFLAGS and EXTRA_LDFLAGS to propagate the SYSROOT specific flags in

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

2015-03-13 Thread Mandy Chung
This module contains both pack200 and unpack200 tools although it only contains the native implementation of unpacker. Naming it as jdk.unpack200 would give an impression that it contains the unpacker only which isn't the case. Like the API java.util.jar.Pack200 class, it's about Pack200 form

Re: Windows build failure in JDK8 with --disable-zip-debug-info

2015-03-13 Thread Volker Simonis
On Thu, Mar 12, 2015 at 8:48 PM, Magnus Ihse Bursie wrote: > We have had issues before with pattern rules on Windows/cygwin. An older > incarnation of Images.gmk used pattern rules extensively, but it hanged or > crashed mysteriously. > > Also, in general, we've tried to avoid pattern rules sinc

Re: RFR: JDK-8075140: Solaris build of native libraries not consistently using EXTRA_CFLAGS and EXTRA_LDFLAGS

2015-03-13 Thread Tim Bell
Hello Erik: While working on the new Hotspot makefiles in build-infra I noticed this problem. When introducing devkits for Solaris, we rely on the variables EXTRA_CFLAGS, EXTRA_CXXFLAGS and EXTRA_LDFLAGS to propagate the SYSROOT specific flags into the hotspot build. However, these flags aren

RFR: JDK-8075140: Solaris build of native libraries not consistently using EXTRA_CFLAGS and EXTRA_LDFLAGS

2015-03-13 Thread Erik Joelsson
Hello, While working on the new Hotspot makefiles in build-infra I noticed this problem. When introducing devkits for Solaris, we rely on the variables EXTRA_CFLAGS, EXTRA_CXXFLAGS and EXTRA_LDFLAGS to propagate the SYSROOT specific flags into the hotspot build. However, these flags aren't co

Re: RFR: JDK-8075054 Mixed case Windows path break native dependency checks

2015-03-13 Thread Tim Bell
Magnus: Looks good to me as well. Tim On 03/13/15 05:56, Erik Joelsson wrote: Looks good! /Erik On 2015-03-13 13:37, Magnus Ihse Bursie wrote: Bug description: If the top-level directory of the forest contains mixed case elements in the path, then the script which checks for native C/C++

Re: RFR: JDK-8075054 Mixed case Windows path break native dependency checks

2015-03-13 Thread Erik Joelsson
Looks good! /Erik On 2015-03-13 13:37, Magnus Ihse Bursie wrote: Bug description: If the top-level directory of the forest contains mixed case elements in the path, then the script which checks for native C/C++ headers dependencies doesn't work properly. This happens because Visual Studio co

RFR: JDK-8075054 Mixed case Windows path break native dependency checks

2015-03-13 Thread Magnus Ihse Bursie
Bug description: If the top-level directory of the forest contains mixed case elements in the path, then the script which checks for native C/C++ headers dependencies doesn't work properly. This happens because Visual Studio compiler sometimes (?) produce lower-case only paths when invoked wit

Re: JDK 9 RFR of doclint updates to cover langtools API

2015-03-13 Thread Magnus Ihse Bursie
On 2015-03-13 07:45, joe darcy wrote: Hello, As a follow-up to the recent work to add doclint flags to the build of various modules, please review the additional patch below to add such coverage to the API defined in the langtools repo. (The change to java.desktop deletes a trailing space ch