Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-24 Thread David Holmes
Thanks Tim! David On 25/03/2015 2:13 PM, Tim Bell wrote: David, Dean: bug: https://bugs.openjdk.java.net/browse/JDK-8072740 webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev/ Simple fix, contributed by Dean Long, that allows the jvm.cfg file to be located in the "closed" location.

Re: RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-24 Thread Tim Bell
David, Dean: bug: https://bugs.openjdk.java.net/browse/JDK-8072740 webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev/ Simple fix, contributed by Dean Long, that allows the jvm.cfg file to be located in the "closed" location. The arm and ppc jvm.cfg files can then be moved to that "c

RFR: 8072740: move closed jvm.cfg files out of open repo

2015-03-24 Thread David Holmes
bug: https://bugs.openjdk.java.net/browse/JDK-8072740 webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev/ Simple fix, contributed by Dean Long, that allows the jvm.cfg file to be located in the "closed" location. The arm and ppc jvm.cfg files can then be moved to that "closed" location

Re: IcedTea Build Failures using self as book JDK

2015-03-24 Thread Andrew Hughes
- Original Message - > [+distro-pkg-dev] > > On Mon, Mar 23, 2015 at 11:47 AM, Styx, Aaron (US SSA) < > aaron.s...@baesystems.com> wrote: > > > I'm working on porting Java 7 (using IcedTea 2.5.4) to a new OS. I've > > completed the build once, but when I install what was built to use as t

Re: RFR: JDK-8075717 Replace INTERNAL_BUILD with DEBUG in awt

2015-03-24 Thread Alexander Zvegintsev
Looks fine to me too. Thanks, Alexander. On 03/23/2015 04:31 PM, Sergey Bylokhov wrote: The fix looks fine. 23.03.15 16:11, Magnus Ihse Bursie wrote: The current define INTERNAL_BUILD has a value that is dependent on the milestone part of the version string. This is not ideal, and should be

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Here's the latest patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8055831/webrev.01/ The changes are: - restructured the native libraries from one directory to several directories on a per DLL/EXE basis - that impacted jdk/make/lib/Lib-jdk.accessibility.gmk - removed the source for the Ferret and

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Pete Brunet
Hi Sergey, That's pretty much the case. I just went through the code and found these differences: - merged in JDK-8055173 (merge jawt.dll into javaaccessbridge.dll) which was recently pushed. - removed some dead code - cleaned up up comments/documentation - cleaned up some code indentation issues

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Sergey Bylokhov
Hi,Pete. Do I understand correctly that the code itself were not changed except files location? 21.03.15 7:33, Pete Brunet wrote: Please review the following patch which will add the code of the Java Access Bridge (JAB) and related Java Accessibility Utilities to OpenJDK. This code is used by

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Erik Joelsson
Actually, I just noticed that we are indeed setting -def: to the linker. Please leave the .def files in the patch. /Erik On 2015-03-24 15:55, Erik Joelsson wrote: On 2015-03-24 14:08, Magnus Ihse Bursie wrote: JavaAccessBridge.DEF is pretty empty. I'll see if the build will work without

Re: RFR: JDK-8075725: Remove /jre subdir in hotspot dist dir

2015-03-24 Thread Erik Joelsson
On 2015-03-24 14:14, Magnus Ihse Bursie wrote: On 2015-03-23 14:36, Erik Joelsson wrote: Hello, In JDK 9, the /jre sub directory in the jdk image has been removed. We should also remove this in the hotspot dist output directory and the corresponding import logic in the jdk build. There are

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Erik Joelsson
On 2015-03-24 14:08, Magnus Ihse Bursie wrote: JavaAccessBridge.DEF is pretty empty. I'll see if the build will work without it. WinAccessBridge.DEF seems like it might be needed. What do you think? Is it accessed by the compiler? Unless it is given as input to the compiler or linker co

Re: RFR: JDK-8075725: Remove /jre subdir in hotspot dist dir

2015-03-24 Thread Magnus Ihse Bursie
On 2015-03-23 14:36, Erik Joelsson wrote: Hello, In JDK 9, the /jre sub directory in the jdk image has been removed. We should also remove this in the hotspot dist output directory and the corresponding import logic in the jdk build. There are still references to /jre in hotspot.script and b

Re: RfR JDK-8055831 Open Source Java Access Bridge

2015-03-24 Thread Magnus Ihse Bursie
On 2015-03-23 18:31, Pete Brunet wrote: Hi Erik, I tried the restructuring about 2 weeks ago and the build failed trying to find an h file in the common directory. I used two directories on the SRC := setting for SetupNativeCompilation but the build failed not finding an h file located in the s

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-24 Thread Erik Helin
On 2015-03-24, Mikael Gerdin wrote: > Hi Volker, > > On 2015-03-19 15:26, Volker Simonis wrote: > >Hi Mikael, > > > >the change looks good (and I think it is really reasonable to have > >this warning). > >I've also checked that our ancient gcc 4.1.2 already supports this option:) > > Thanks! > >

Re: RFR (XS) Enable -Woverloaded-virtual for GCC in the HotSpot build

2015-03-24 Thread Mikael Gerdin
Hi Volker, On 2015-03-19 15:26, Volker Simonis wrote: Hi Mikael, the change looks good (and I think it is really reasonable to have this warning). I've also checked that our ancient gcc 4.1.2 already supports this option:) Thanks! Any more takers from HotSpot land? /Mikael Regards, Volke