Re: RFR: JDK-8080082 configure fails if you create an empty directory and then run configure from it

2015-05-11 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-12 03:44, Magnus Ihse Bursie wrote: JDK-8079891 caused this behavior: /scratch/dh198349/jdk9-dev > mkdir mybuild /scratch/dh198349/jdk9-dev > cd mybuild /scratch/dh198349/jdk9-dev/mybuild > bash ../configure Running custom generated-configure.sh configure: Co

Re: RFR: JDK-8080082 configure fails if you create an empty directory and then run configure from it

2015-05-11 Thread David Holmes
On 12/05/2015 11:44 AM, Magnus Ihse Bursie wrote: JDK-8079891 caused this behavior: /scratch/dh198349/jdk9-dev > mkdir mybuild /scratch/dh198349/jdk9-dev > cd mybuild /scratch/dh198349/jdk9-dev/mybuild > bash ../configure Running custom generated-configure.sh configure: Configuration created at

RFR: JDK-8080082 configure fails if you create an empty directory and then run configure from it

2015-05-11 Thread Magnus Ihse Bursie
JDK-8079891 caused this behavior: /scratch/dh198349/jdk9-dev > mkdir mybuild /scratch/dh198349/jdk9-dev > cd mybuild /scratch/dh198349/jdk9-dev/mybuild > bash ../configure Running custom generated-configure.sh configure: Configuration created at Mon May 11 19:09:12 EDT 2015. configure: configure

Re: RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread David Holmes
Hi Erik, On 11/05/2015 10:31 PM, Erik Joelsson wrote: Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Web

Re: RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread Magnus Ihse Bursie
On 2015-05-11 14:31, Erik Joelsson wrote: Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Webrev: http:

RFR: JDK-8039426: gcc can target wrong instruction set when building JDK native code

2015-05-11 Thread Erik Joelsson
Hello, Please review this small fix to CFLAGS when compiling with GCC on a 32-bit system. Hotspot currently sets -march=i586 and the jdk libraries should do the same for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8039426 Webrev: http://cr.openjdk.java.net/~erikj/8039426/webrev

Re: Backport multiple toolchains support to JDK8?

2015-05-11 Thread Magnus Ihse Bursie
On 2015-05-08 18:49, Alexander Smundak wrote: And I guess the successor of the 8u60 is going to be the last JDK8 release? As far as I know, 8u60 is the last JDK8 feature release being done by Oracle. /Magnus On Fri, May 8, 2015 at 2:00 AM, Magnus Ihse Bursie wrote: On 2015-05-08 04:46, Ale

Re: RFR: JDK-8080013 OpenJDK windows build fails due to warning in libfontmanager

2015-05-11 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-11 14:05, Magnus Ihse Bursie wrote: JDK-8074859, which turns on warnings-as-errors, unfortunately was not properly tested with open-only, just the Oracle closed build. An extra warning present in freetype2 code causes the build to fail. Bug: https://bugs.op

RFR: JDK-8080013 OpenJDK windows build fails due to warning in libfontmanager

2015-05-11 Thread Magnus Ihse Bursie
JDK-8074859, which turns on warnings-as-errors, unfortunately was not properly tested with open-only, just the Oracle closed build. An extra warning present in freetype2 code causes the build to fail. Bug: https://bugs.openjdk.java.net/browse/JDK-8080013 WebRev inline: diff --git a/make/lib/Aw

Re: RFR: JDK-8079891 Store configure log in $BUILD/configure.log

2015-05-11 Thread Magnus Ihse Bursie
On 2015-05-11 13:02, Roger Riggs wrote: Hi, Great to see the log output to a file. I don't find the blast of trivial output from configure to be useful. It would be a separate change, but can the output be limited to just error and warnings or only the notable intermediate results. Unfortunat

Re: Issues with dtrace enabled in OpenJdk 9

2015-05-11 Thread Staffan Larsen
Note that SDT and dtrace4linux are different things. As far as I know, no one has tried dtrace4linux with Hotspot so you are in uncharted territories. SDT should work (if installed). Oracle Linux also has an implementation of Dtrace that I think is different from dtrace4linux. This is also untes

Re: Issues with dtrace enabled in OpenJdk 9

2015-05-11 Thread David Holmes
On 11/05/2015 8:51 PM, Mahesh Pujari wrote: Thanks for replying back Erik. I ran as you stated i.e. using "make DTRACE_ENABLED=true" but then I realized that the configure that I was running would do the same i.e. by having CFLAGS=-DDTRACE_ENABLED=1. No it isn't the same. The linux/makefiles/

Re: RFR: JDK-8079891 Store configure log in $BUILD/configure.log

2015-05-11 Thread Roger Riggs
Hi, Great to see the log output to a file. I don't find the blast of trivial output from configure to be useful. It would be a separate change, but can the output be limited to just error and warnings or only the notable intermediate results. $.02, Roger On 5/11/2015 5:05 AM, Magnus Ihse Burs

Re: RFR 8079900: javadoc is missing for jdk.nashorn.api.tree package

2015-05-11 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-11 12:55, Marcus Lagergren wrote: +1 On 11 May 2015, at 12:47, A. Sundararajan wrote: Please review fix for http://cr.openjdk.java.net/~sundar/8079900/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079900#comment-13640520 Note that jdk.nashor

Re: RFR 8079900: javadoc is missing for jdk.nashorn.api.tree package

2015-05-11 Thread Marcus Lagergren
+1 > On 11 May 2015, at 12:47, A. Sundararajan > wrote: > > Please review fix for http://cr.openjdk.java.net/~sundar/8079900/webrev.00/ > for https://bugs.openjdk.java.net/browse/JDK-8079900#comment-13640520 > > Note that jdk.nashorn.api.tree is part of nashorn API as specified by Nashorn >

Re: Issues with dtrace enabled in OpenJdk 9

2015-05-11 Thread Mahesh Pujari
Thanks for replying back Erik. I ran as you stated i.e. using "make DTRACE_ENABLED=true" but then I realized that the configure that I was running would do the same i.e. by having CFLAGS=-DDTRACE_ENABLED=1. When I make (using your approach and passing enable in configure), I end up with lots and

RFR 8079900: javadoc is missing for jdk.nashorn.api.tree package

2015-05-11 Thread A. Sundararajan
Please review fix for http://cr.openjdk.java.net/~sundar/8079900/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079900#comment-13640520 Note that jdk.nashorn.api.tree is part of nashorn API as specified by Nashorn Parser API JEP http://openjdk.java.net/jeps/236 Thanks, -Sundar

Re: Issues with dtrace enabled in OpenJdk 9

2015-05-11 Thread Erik Joelsson
Hello, I don't have any experience building with dtrace support, but the Hotspot makefiles seem to imply that it can be achieved by running: make DTRACE_ENABLED=true That variable will trigger the appropriate preprocessor flags to be added at least. See hotspot/make/linux/makefiles/dtrace.ma

Issues with dtrace enabled in OpenJdk 9

2015-05-11 Thread Mahesh Pujari
Hi all, I am trying make OpenJdk 9 with dtrace enabled, on my Ubuntu machine (installed with https://github.com/dtrace4linux/linux), with configuration as below (and I am noob). ./configure --enable-option-checking=fatal --with-debug-level=slowdebug --with-target-bits=64 --disable-zip-debug-info

Re: RFR: JDK-8079891 Store configure log in $BUILD/configure.log

2015-05-11 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-11 11:05, Magnus Ihse Bursie wrote: It is trivial to save the log file of configure in the build output directory. We should do that. I also noted that the repeat of warnings at the end of the configure run had stopped working since we moved config.log to

RFR: JDK-8079891 Store configure log in $BUILD/configure.log

2015-05-11 Thread Magnus Ihse Bursie
It is trivial to save the log file of configure in the build output directory. We should do that. I also noted that the repeat of warnings at the end of the configure run had stopped working since we moved config.log to configure-support. (Also, it was incorrectly indented.) I fixed this as we

Re: RFR: JDK-8079771 Fix SoundLibraries.gmk mismerge after JDK-8072665

2015-05-11 Thread Magnus Ihse Bursie
On 2015-05-10 04:27, Phil Race wrote: I guess this was my merge .. I know it was 2 months ago but I do not remember being asked to merge this manually so it looks like an odd auto-merge anomaly as it seemed to get all the other 6 or so cases right. Merges of code you haven't written yourself ca