Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-27 Thread Jan Lahoda
Hi, I've uploaded another iteration, with these changes: -the symbols file is now generated automatically (for the typical OpenJDK case). -fixed a minor issue in CreateSymbols that could cause putting class description into wrong a file (the break - break OUTER; change). -jdk.management module

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-27 Thread Maurizio Cimadamore
Looks great. The only nitpick is that the comments in CreateSymbols don't mention the fact that a side effect of the sym.txt generation is the platform-description-file mentioned earlier in the same comments (so one might wonder where does that come from). Maurizio On 27/05/15 10:37, Jan

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-05-27 Thread Jan Lahoda
Ah, yes, I did not realize that. Thanks, will fix. Thanks, Jan On 27.5.2015 11:59, Maurizio Cimadamore wrote: Looks great. The only nitpick is that the comments in CreateSymbols don't mention the fact that a side effect of the sym.txt generation is the platform-description-file mentioned

Re: [8u60] Request for review and approval: JDK-8074523: Windows native binaries have inconsistent Product version

2015-05-27 Thread Magnus Ihse Bursie
On 2015-05-26 12:24, Erik Joelsson wrote: Any chance I could get a review on this? Yeah, if you ask nicely, with sugar on top. ;-) Fix looks good to me. Thanks for taking care of this. /Magnus /Erik On 2015-05-20 16:09, Erik Joelsson wrote: Thanks, changed to: Windows native binaries

Why isn't 8u45 release listed on OpenJDK site?

2015-05-27 Thread Alexander Voron
I'm going to update OpenJRE to the version which contains Oracle April CPU fixes. According to the repo tags, I suppose, I should use jdk8u45-b14 I have 2 questions: 1. Is jdk8u45-b14 an official release branch for OpenJDK? 2. If it so - why wasn't 8u45 listed on OpenJDK 8 update releases page?

Re: RFR 9: 8074818: Resolve disabled warnings for libjava

2015-05-27 Thread Martin Buchholz
On Tue, May 26, 2015 at 7:52 PM, Roger Riggs roger.ri...@oracle.com wrote: Hi, Sadly, but not entirely unexpectedly there is an anomaly in the include files: It seems that Windows does not define O_SYNC and O_DSYNC. To make up for the absence

Re: AWT Dev RfR JDK-8077296 RE build fails on non-Win builds when attempting to build Win only javadoc

2015-05-27 Thread Mandy Chung
On 2015-05-21 07:33, Pete Brunet wrote: Please review the following change for 8u: http://cr.openjdk.java.net/~ptbrunet/JDK-8077296/webrev.00/ I only skimmed through the change. package-info.java should have @jdk.Exported. Mandy Background: - As part of the open sourcing of the

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-05-27 Thread Mandy Chung
Valerie, Did you see my comment yesterday? http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012254.html Since you have reverted the java.security to keep the classname, to avoid causing merge conflict to jimage refresh, let’s remove the META-INF files in the first push and the

RFR 7191662: JCE providers should be located via ServiceLoader

2015-05-27 Thread Valerie Peng
Hi, build experts, Can you please review the make file related change, i.e. the new file || *make/gensrc/Gensrc-java.naming.gmk*, in the following webrev: http://cr.openjdk.java.net/~valeriep/7191662/webrev.01/ This is for merging the java.security.Provider file from various providers and