Re: Request for guidance on fixing JDK-8075571: Support tier1 and tier2 make targets

2015-06-02 Thread joe darcy
Thanks for the pointers Jon. A not-quite-finished version of this work is up at http://cr.openjdk.java.net/~darcy/8075571.0/ The nashorn test makefile is copied from the jaxp one with s/jaxp/nashorn/g. While I'm at it, I think it is worthwhile to add support nominal support for tier 3 tes

Re: official compiler for Solaris jdk9 build?

2015-06-02 Thread David Holmes
On 3/06/2015 2:12 AM, Semyon Sadetsky wrote: The repository version should be buildable on all platforms without any source code modifications, shouldn't it? The repository version should build with Studio12u3 on Solaris 10u6, or Solaris 10u10. However if you want to build on Solaris 11.x then

Re: Request for guidance on fixing JDK-8075571: Support tier1 and tier2 make targets

2015-06-02 Thread Jonathan Gibbons
Joe, The magic you need to manipulate is lines 54-71 (approx) in test/Makefile. # Default test target (core) default: jdk_core langtools_jtreg jaxp_all # All testing all: jdk_all langtools_all jaxp_all # Test targets langtools_% : @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), JT_JA

Re: Request for guidance on fixing JDK-8075571: Support tier1 and tier2 make targets

2015-06-02 Thread joe darcy
PS It is a bit lame, but if new new definitions are put into the jdk/test/TEST.groups file diff -r df4d75f58f15 test/TEST.groups --- a/test/TEST.groupsThu May 28 11:31:40 2015 -0700 +++ b/test/TEST.groupsTue Jun 02 13:21:06 2015 -0700 @@ -42,6 +42,9 @@ :jdk_other \ :jdk_svc +j

Request for guidance on fixing JDK-8075571: Support tier1 and tier2 make targets

2015-06-02 Thread joe darcy
Hello makefile gurus, To provide the next level of support to the tiered testing policy [1], I'd like to get some advice on how best to tackle JDK-8075571: Support tier1 and tier2 make targets From the bug, currently one can invoke test groups like so: make test-only TEST=jdk_lang T

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-06-02 Thread Jan Lahoda
Hello Eric, Thanks for the change, this seems definitely better to me. I've folded your change that into my patch. An updated version (just langtools this time): http://cr.openjdk.java.net/~jlahoda/8072480/webrev.04/langtools/ Thanks! Jan On 2.6.2015 16:04, Erik Joelsson wrote: Hello Jan,

Re: [8u60] Request for review and approval: JDK-8074523: Windows native binaries have inconsistent "Product version"

2015-06-02 Thread Tim Bell
Hi Erik: I still need an 8u reviewer, anyone? Line 534 in jdk-options.m4 needs to line up with the following comment lines. Otherwise, this looks good. No need to respin the webrev after fixing the white space. Tim On 2015-05-27 16:05, Magnus Ihse Bursie wrote: On 2015-05-26 12:24, E

Re: official compiler for Solaris jdk9 build?

2015-06-02 Thread Semyon Sadetsky
The repository version should be buildable on all platforms without any source code modifications, shouldn't it? --Semyon On 6/2/2015 6:47 PM, Phil Race wrote: E_STATEMENT_NOT_REACHED is a favourite of SunStudio and I recently fixed one such warning (in closed code so I can't point to it here

Re: official compiler for Solaris jdk9 build?

2015-06-02 Thread Phil Race
E_STATEMENT_NOT_REACHED is a favourite of SunStudio and I recently fixed one such warning (in closed code so I can't point to it here) but I did not see this one .. however I was using jprt and locally Solaris 10 SPARC. So perhaps it is something to do with the headers ? Ironically the warning

Re: official compiler for Solaris jdk9 build?

2015-06-02 Thread Erik Joelsson
Hello Semyon, Solaris Studio 12.3 is the correct version. However, internally we use devkits with the compiler and system headers/libraries all packaged together (details in separate mail). The devkits still use headers and libraries from Solaris 10u10 for compatibility with that release. We

official compiler for Solaris jdk9 build?

2015-06-02 Thread Semyon Sadetsky
Hi, I'm trying to build jdk9 under the current Solaris 11.2 version. Which version of the Solaris Studio should be installed for that? The readme-builds states: ... At a minimum, the Studio 12 Update 1 Compilers (containing version 5.10 of the C and C++ compilers) is required, including specif

Re: [8u60] Request for review and approval: JDK-8074523: Windows native binaries have inconsistent "Product version"

2015-06-02 Thread Erik Joelsson
Thanks Magnus, but I still need an 8u reviewer, anyone? /Erik On 2015-05-27 16:05, Magnus Ihse Bursie wrote: On 2015-05-26 12:24, Erik Joelsson wrote: Any chance I could get a review on this? Yeah, if you ask nicely, with sugar on top. ;-) Fix looks good to me. Thanks for taking care of thi

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-06-02 Thread Erik Joelsson
Hello Jan, Sorry to bother you with even more build changes, but with these file moves, I realized that this new file, ct.sym, is really a part of the jdk.compiler module and really not a special case at all. Because of this, it should be generated as part of the jdk.compiler-gendata target.

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
On 6/2/2015 4:50 PM, Magnus Ihse Bursie wrote: On 2015-06-02 15:21, Semyon Sadetsky wrote: Hello, Hate to disturb you again but I got yet another show stopper for my Solaris build: Generating solaris_amd64_docs/jvmti.html Creating libverify.so from 2 file(s) Creating libjava.so from 60 file

Re: Solaris jdk9 build problem

2015-06-02 Thread Roger Riggs
HI, The compiler is doing more checking than others. The other compilers don't seem to know that _exit() does not return. The following patch may get past the issue. (I'm not sure if it will with all compilers.) Let me know if that works and we'll see about patching 9. Roger diff --git a/s

Re: Solaris jdk9 build problem

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 15:21, Semyon Sadetsky wrote: Hello, Hate to disturb you again but I got yet another show stopper for my Solaris build: Generating solaris_amd64_docs/jvmti.html Creating libverify.so from 2 file(s) Creating libjava.so from 60 file(s) Creating libfdlibm.a from 62 file(s) Creating

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 13:50, Bertrand Delsart wrote: On 02/06/2015 12:45, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
Hello, Hate to disturb you again but I got yet another show stopper for my Solaris build: Generating solaris_amd64_docs/jvmti.html Creating libverify.so from 2 file(s) Creating libjava.so from 60 file(s) Creating libfdlibm.a from 62 file(s) Creating libzip.so from 21 file(s) Creating libjli.so

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 10:36 PM, Magnus Ihse Bursie wrote: On 2015-06-02 13:29, David Holmes wrote: On 2/06/2015 8:45 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasona

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 13:29, David Holmes wrote: On 2/06/2015 8:45 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In th

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Erik Joelsson
Looks good to me. /Erik On 2015-06-02 12:45, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In the interest of mo

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Bertrand Delsart
On 02/06/2015 12:45, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In the interest of moving forward can we use his

Re: Solaris jdk9 build problem

2015-06-02 Thread Erik Joelsson
On 2015-06-02 12:33, David Holmes wrote: On 2/06/2015 8:33 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:22, David Holmes wrote: On 2/06/2015 8:12 PM, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, M

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 8:45 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In the interest of moving forward can we use hi

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 12:35, Magnus Ihse Bursie wrote: On 2015-06-02 12:27, David Holmes wrote: These should be removed instead. Okay but I don't think it reasonable to expect Bertrand to make such changes. In the interest of moving forward can we use his current patch and file a follow up bug to get

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
On 6/2/2015 1:33 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:22, David Holmes wrote: On 2/06/2015 8:12 PM, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Bertrand Delsart
On 02/06/2015 12:27, David Holmes wrote: On 2/06/2015 8:22 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:57, David Holmes wrote: On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warni

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 12:27, David Holmes wrote: On 2/06/2015 8:22 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:57, David Holmes wrote: On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warni

Re: Solaris jdk9 build problem

2015-06-02 Thread David Holmes
On 2/06/2015 8:33 PM, Magnus Ihse Bursie wrote: On 2015-06-02 12:22, David Holmes wrote: On 2/06/2015 8:12 PM, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:

Re: Solaris jdk9 build problem

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 12:22, David Holmes wrote: On 2/06/2015 8:12 PM, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM,

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
That helped. Thank you! --Semyon On 6/2/2015 1:18 PM, Erik Joelsson wrote: Or no, I wrote too fast. The assembler 'as' is part of Solaris and not Solaris Studio. You need to install the correct package to get it in /usr/bin/as. /Erik On 2015-06-02 12:17, Erik Joelsson wrote: When I build on

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 8:22 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:57, David Holmes wrote: On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup)

Re: Re: Solaris jdk9 build problem

2015-06-02 Thread Mikael Gerdin
On 2015-06-02 12:06, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could yo

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 11:57, David Holmes wrote: On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup): http://cr.openjdk.java.net/~bdelsart/8081616/w

Re: Solaris jdk9 build problem

2015-06-02 Thread David Holmes
On 2/06/2015 8:12 PM, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 2

Re: Solaris jdk9 build problem

2015-06-02 Thread Erik Joelsson
Or no, I wrote too fast. The assembler 'as' is part of Solaris and not Solaris Studio. You need to install the correct package to get it in /usr/bin/as. /Erik On 2015-06-02 12:17, Erik Joelsson wrote: When I build on Solaris, configure finds 'as' in the Solaris Studio bin dir. /Erik On 201

Re: Solaris jdk9 build problem

2015-06-02 Thread Erik Joelsson
When I build on Solaris, configure finds 'as' in the Solaris Studio bin dir. /Erik On 2015-06-02 12:12, Semyon Sadetsky wrote: On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Sem

Re: Solaris jdk9 build problem

2015-06-02 Thread David Holmes
On 2/06/2015 5:54 PM, Semyon Sadetsky wrote: On 6/2/2015 9:27 AM, David Holmes wrote: On 2/06/2015 4:20 PM, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could you help me to resolve 9 build problem on Solaris 11.2:

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
On 6/2/2015 1:06 PM, Magnus Ihse Bursie wrote: On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could yo

Re: Solaris jdk9 build problem

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 11:25, Semyon Sadetsky wrote: On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could you help me to resolve 9 build problem on Solaris 1

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 7:57 PM, David Holmes wrote: On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup): http://cr.openjdk.java.net/~bdelsart/808161

Re: RFR: JDK-8081471 Allow SetupTestFilesCompilation to set LDFLAGS for individual tests

2015-06-02 Thread Erik Joelsson
Looks good to me. /Erik On 2015-05-29 11:15, Magnus Ihse Bursie wrote: A request have been made to be able to set specific LDFLAGS for individual tests/libraries in SetupTestFilesCompilation, similar to the CFLAGS_filename construct in SetupNativeCompilation, e.g. LDFLAGS_libFooBar := -lfoofl

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 6:58 PM, Magnus Ihse Bursie wrote: On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup): http://cr.openjdk.java.net/~bdelsart/8081616/webrev.00/webrev/ Without the fix, -Werror

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread David Holmes
On 2/06/2015 6:40 PM, Bertrand Delsart wrote: Thanks David, Answers inlined. On 02/06/2015 01:34, David Holmes wrote: Hi Bertrand, On 2/06/2015 3:23 AM, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup):

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
On 6/2/2015 11:47 AM, Magnus Ihse Bursie wrote: On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could you help me to resolve 9 build problem on Solaris 11.2: /usr/ccs/bin/nm: solaris_x86_64.o: No s

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-01 19:23, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup): http://cr.openjdk.java.net/~bdelsart/8081616/webrev.00/webrev/ Without the fix, -Werror is used to compiled native JDK libraries even

Re: Solaris jdk9 build problem

2015-06-02 Thread Magnus Ihse Bursie
On 2015-06-02 08:20, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could you help me to resolve 9 build problem on Solaris 11.2: /usr/ccs/bin/nm: solaris_x86_64.o: No such file or directory gmake[8]: *** [libjvm.so] Er

Re: RFR [XXS] : JDK-8081616: build fixes for --disable-warnings-as-errors

2015-06-02 Thread Bertrand Delsart
Thanks David, Answers inlined. On 02/06/2015 01:34, David Holmes wrote: Hi Bertrand, On 2/06/2015 3:23 AM, Bertrand Delsart wrote: Hi all, A small open webrev to fix some issues around --disable-warnings-as-errors (this is not a full cleanup): http://cr.openjdk.java.net/~bdelsart/8081616/we

Re: Solaris jdk9 build problem

2015-06-02 Thread Semyon Sadetsky
On 6/2/2015 9:27 AM, David Holmes wrote: On 2/06/2015 4:20 PM, Semyon Sadetsky wrote: On 6/2/2015 2:35 AM, Magnus Ihse Bursie wrote: On 2015-06-01 21:17, Semyon Sadetsky wrote: Hello, Could you help me to resolve 9 build problem on Solaris 11.2: /usr/ccs/bin/nm: solaris_x86_64.o: No such fi