Looks good.
/Erik
On 2015-06-10 15:44, Magnus Ihse Bursie wrote:
On 2015-06-09 01:31, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
General comment: Not all copyright years were updated.
I realize I missed that part of the revi
Change looks fine, but as David pointed out, please run through jprt.
/Erik
On 2015-06-11 00:05, Pete Brunet wrote:
Please review this simple patch which causes jdk.accessibility to be
built for all platforms, not just for Windows. I tested it on Win and Mac.
http://cr.openjdk.java.net/~ptbrun
On 2015-06-11 01:38, Maurizio Cimadamore wrote:
On 10/06/15 17:27, Mandy Chung wrote:
On Jun 10, 2015, at 6:25 AM, Maurizio Cimadamore
wrote:
Hi,
In the context of the IntelliJ project support for JDK, I have a
question on the very last step of 'make images' :
## Starting verify-modules
Hello Omair,
This looks good to me, thanks for catching it!
/Erik
On 2015-06-11 00:36, Omair Majid wrote:
Hi,
I discovered a bug in SetupNativeCompilation that results in some C++
code being built with wrong CXXFLAGS.
Bug: https://bugs.openjdk.java.net/browse/JDK-8087156
Webrev:
http://cr.o
On 11/06/2015 8:05 AM, Pete Brunet wrote:
Please review this simple patch which causes jdk.accessibility to be
built for all platforms, not just for Windows. I tested it on Win and Mac.
http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/
Looks okay but please ensure you test on all pla
Hi Magnus,
On 10/06/2015 10:13 PM, Magnus Ihse Bursie wrote:
On 2015-06-10 11:58, David Holmes wrote:
Hi Magnus,
Generally looks good - a few comments/queries below.
In general, I believe most issues you found are valid. :-) However, as I
said before in this thread, I'd like to see them reso
> On Jun 10, 2015, at 4:54 PM, Pete Brunet wrote:
>
> Hi Mandy, That's fixed in the JDK-8078335 patch I submitted earlier in
> the day to build-dev as a RfR. I tested that on Win and Mac.
>
> http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/
Looks good to me.
Mandy
>
> Pete
>
>
Hi Mandy, That's fixed in the JDK-8078335 patch I submitted earlier in
the day to build-dev as a RfR. I tested that on Win and Mac.
http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/
Pete
On 6/10/15 6:08 PM, Mandy Chung wrote:
> Just a quick check, jdk.accessibility is only linked in w
On 10/06/15 17:27, Mandy Chung wrote:
On Jun 10, 2015, at 6:25 AM, Maurizio Cimadamore
wrote:
Hi,
In the context of the IntelliJ project support for JDK, I have a question on
the very last step of 'make images' :
## Starting verify-modules
Checking dependencies across JDK modules
Access ve
> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote:
>
> Due to some other priorities it's been over 2 months since the last webrev.
> An update is here:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03
BarProvider.java
You can use try-with-resource
try (PrintWriter writer = n
Just a quick check, jdk.accessibility is only linked in windows image at the
moment. It is a bug. Are you going to fix that in this changeset? I think
you have to verify this change in windows as well as other platforms.
Mandy
> On Jun 10, 2015, at 3:33 PM, Pete Brunet wrote:
>
> Due to s
Note that I need to remove the import of java.io.PrintWriter in
java.awt.Toolkit.java
On 6/10/15 5:33 PM, Pete Brunet wrote:
> Due to some other priorities it's been over 2 months since the last
> webrev. An update is here:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03
>
> The chan
Hi,
I discovered a bug in SetupNativeCompilation that results in some C++
code being built with wrong CXXFLAGS.
Bug: https://bugs.openjdk.java.net/browse/JDK-8087156
Webrev:
http://cr.openjdk.java.net/~omajid/webrevs/8087156-setupnativecompilation/00/
It turns out that debugging flags are autom
Due to some other priorities it's been over 2 months since the last
webrev. An update is here:
http://cr.openjdk.java.net/~ptbrunet/JDK-8055160/webrev.03
The changes from webrev.02 are:
1) The test was changed to not use the service provider to test the
activation of the service provider. Inste
Please review this simple patch which causes jdk.accessibility to be
built for all platforms, not just for Windows. I tested it on Win and Mac.
http://cr.openjdk.java.net/~ptbrunet/JDK-8078335/webrev.00/
Pete
On 6/10/2015 6:13 AM, Magnus Ihse Bursie wrote:
On 2015-06-10 11:58, David Holmes wrote:
Hi Magnus,
Generally looks good - a few comments/queries below.
In general, I believe most issues you found are valid. :-) However, as
I said before in this thread, I'd like to see them resolved in the
> On Jun 10, 2015, at 6:25 AM, Maurizio Cimadamore
> wrote:
>
> Hi,
> In the context of the IntelliJ project support for JDK, I have a question on
> the very last step of 'make images' :
>
> ## Starting verify-modules
> Checking dependencies across JDK modules
> Access verification succeeded.
On 10/06/15 16:30, Erik Joelsson wrote:
On 2015-06-10 15:25, Maurizio Cimadamore wrote:
Hi,
In the context of the IntelliJ project support for JDK, I have a
question on the very last step of 'make images' :
## Starting verify-modules
Checking dependencies across JDK modules
Access verifica
On 2015-06-10 15:25, Maurizio Cimadamore wrote:
Hi,
In the context of the IntelliJ project support for JDK, I have a
question on the very last step of 'make images' :
## Starting verify-modules
Checking dependencies across JDK modules
Access verification succeeded.
I noticed that this step i
On 2015-06-09 01:31, Daniel D. Daugherty wrote:
>
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
General comment: Not all copyright years were updated.
I realize I missed that part of the review. :-(
I have now updated the copyright years. Here's a delta revi
Hi,
In the context of the IntelliJ project support for JDK, I have a
question on the very last step of 'make images' :
## Starting verify-modules
Checking dependencies across JDK modules
Access verification succeeded.
I noticed that this step is always applied, regardless of whether there
was
On 2015-06-10 11:58, David Holmes wrote:
Hi Magnus,
Generally looks good - a few comments/queries below.
In general, I believe most issues you found are valid. :-) However, as I
said before in this thread, I'd like to see them resolved in the needed
follow-up patches. The source code changes
Hi Magnus,
Generally looks good - a few comments/queries below.
On 9/06/2015 11:52 PM, Magnus Ihse Bursie wrote:
Here's an updated webrev, which fixes the typos that were pointed out by
reviewers:
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.02/
common/autoconf/ve
On Wed, Jun 10, 2015 at 11:02:19AM +0200, Andreas Lundblad wrote:
> What's the approperiate procedure here? Should I submit a patch that adds the
> type arguments to avoid forcing people to update their boot jdks?
I have now pushed a patch that adds the type arguments.
http://hg.openjdk.java.net
On Wed, Jun 10, 2015 at 09:06:44AM +0100, Alan Bateman wrote:
>
>
> On 10/06/2015 09:00, Erik Joelsson wrote:
> >Hello,
> >
> >Sjavac has always been compiled in the interim langtools step, the
> >configure flag only affects using it to compile the rest of the
> >java classes.
> >
> >Has a bug be
On 10/06/2015 09:00, Erik Joelsson wrote:
Hello,
Sjavac has always been compiled in the interim langtools step, the
configure flag only affects using it to compile the rest of the java
classes.
Has a bug been created for this?
I haven't created a bug for this as I wasn't sure if this was
Hello,
Sjavac has always been compiled in the interim langtools step, the
configure flag only affects using it to compile the rest of the java
classes.
Has a bug been created for this?
/Erik
On 2015-06-10 09:53, Alan Bateman wrote:
There was a sjavac update pushed to jdk9/dev yesterday (J
There was a sjavac update pushed to jdk9/dev yesterday (JDK-8054717). I
seem to be running into build issues on OS X since then (clean build,
not a reconfigure). My boot JDK is 8u31. My configure command does not
specify --enable-sjavac so I'm surprised this code is being compiled.
Anyone el
Looks good.
/Erik
On 2015-06-09 15:52, Magnus Ihse Bursie wrote:
Here's an updated webrev, which fixes the typos that were pointed out
by reviewers:
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.02/
And here's a (much simpler) delta webrev which shows just these
29 matches
Mail list logo
