Question around the 8054717 fix

2015-06-15 Thread Seán Coffey
Hi, I had a security library fix reviewed last week [1] and all was ok with builds back then. Today, I found that my build is broken and I think it's down to the changes introduced from the 8054717 fix. The build error (snippet) is :

JDK 9 RFR of JDK-8098579: Remove non-existent javax.tools.annotation package from CORE_PKGS.gmk

2015-06-15 Thread joe darcy
Hello, Please review the fix below to address JDK-8098579: Remove non-existent javax.tools.annotation package from CORE_PKGS.gmk Thanks, -Joe diff -r 1bcfd6b87265 make/common/CORE_PKGS.gmk --- a/make/common/CORE_PKGS.gmkThu Jun 11 20:18:41 2015 -0700 +++

RFR 9/8: 8066504: GetVersionEx in java.base/windows/native/libjava/java_props_md.c might not get correct Windows version

2015-06-15 Thread Roger Riggs
Please review code for Windows 10 that sets the System properties for os.name and os.version from the version of kernel32.dll. The update uses the same technique used by Hotspot in src/os/windows/vm/os_windows.cpp. The Windows link of CoreLibraries.gmk includes version.lib/dll. The behavior

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-15 Thread Valerie Peng
It seems that the jimage refresh change may still take some time, so we will end up removing the makefile related changes and then deferring the ServiceLoader related changes to Jake workspace. Here is the latest webrev (Security source/test changes only, no more makefile changes)