Re: [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 6/25/2015 1:15 AM, Naoto Sato wrote: Thanks. Here is the diff from "webrev.01" to address your comment: http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62 Naoto On 6/24/15 2:16 AM, Masayoshi Okutsu wrote: applyParentLocales() sets parentLocalesMap be

Re: [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Naoto Sato
Thanks. Here is the diff from "webrev.01" to address your comment: http://hg.openjdk.java.net/jdk9/sandbox/jdk/rev/b8faab65bb62 Naoto On 6/24/15 2:16 AM, Masayoshi Okutsu wrote: applyParentLocales() sets parentLocalesMap before populating the map with data. It's possible that other threads loo

Re: JDK 9 RFR of JDK-8072480: javac should support compilation for a specific platform version

2015-06-24 Thread Jan Lahoda
Hello, After some offline discussions, I've somewhat changed the internal API for plugging in the platforms (based on Jon's advices). An updated webrev is here: http://cr.openjdk.java.net/~jlahoda/8072480/webrev.05/langtools/ How does this look? Thanks for all the comments! Jan On 2.6.2015

Re: [9] RFR: 8008577: Use CLDR Locale Data by Default (JEP-252)

2015-06-24 Thread Masayoshi Okutsu
applyParentLocales() sets parentLocalesMap before populating the map with data. It's possible that other threads look up the map without the (full) data. So, a Map (local variable) should be populated and then parentLocalesMap should be set to the Map. Also, parentLocalesMap needs to be volatil