Can someone please help reviewing this change?
This is to move Apple provider from jdk.deploy.osx module to java.base
module.
The native library for Apple provider is separated out from the "osx"
one generated in jdk.deploy.osx module and named "osxapple" (sort of
following the convention of S
Hi Sundar,
Seems fine to me. I've filled:
https://bugs.openjdk.java.net/browse/JDK-8133549
for generalizing the EditingHistory.
Thanks,
Jan
On 13.8.2015 14:46, Sundararajan Athijegannathan wrote:
Hi Jan,
Yes, I took that part of code from jshell code - hoped that I can do
multiline editi
+1
> On Aug 12, 2015, at 2:03 PM, Sundararajan Athijegannathan
> wrote:
>
> Hi,
>
> Please review changes for the bug:
> https://bugs.openjdk.java.net/browse/JDK-8133347
>
> This is a subtask of "jjs should use jline"
> https://bugs.openjdk.java.net/browse/JDK-8080678
>
> This subtask addr
Hi Jan,
Yes, I took that part of code from jshell code - hoped that I can do
multiline editing support + history on that for jjs later. But, you're
right. For now, it is better to have a simpler history code in Console
as you suggested.
Also if we want more common code, perhaps jdk.internal
Hi Sundar,
Regarding the new Console.java, there is a copy of EditingHistory from
JShell. That implements a support for simpler editing of multi-line
snippet from history (still somewhat experimental, I think). If that
would be useful for jjs, then I think we(/I) should work on sharing that
c
Thanks, looks good!
/Erik
On 2015-08-13 09:51, Sundararajan Athijegannathan wrote:
Updated only the "top" webrev:
http://cr.openjdk.java.net/~sundar/8133347/top/webrev.01/
Thanks,
-Sundar
On 8/13/2015 12:47 PM, Sundararajan Athijegannathan wrote:
Hi,
Thanks. I'll fix it.
-Sundar
On 8/13/
Updated only the "top" webrev:
http://cr.openjdk.java.net/~sundar/8133347/top/webrev.01/
Thanks,
-Sundar
On 8/13/2015 12:47 PM, Sundararajan Athijegannathan wrote:
Hi,
Thanks. I'll fix it.
-Sundar
On 8/13/2015 12:43 PM, Erik Joelsson wrote:
Hello Sundar,
Build changes look ok. I would app
Hi,
Thanks. I'll fix it.
-Sundar
On 8/13/2015 12:43 PM, Erik Joelsson wrote:
Hello Sundar,
Build changes look ok. I would appreciate if you could avoid
increasing the line length that much in make/Images.gmk though. It
makes side by side comparisons difficult.
/Erik
On 2015-08-12 19:03,
Looks good.
/Erik
On 2015-08-12 23:23, David DeHaven wrote:
JBS Issue:
https://bugs.openjdk.java.net/browse/JDK-8130929
I need a small change to top level test/Makefile. If closed/test/Makefile is not present
it is simply ignored so this should have no impact on OpenJDK builds. This change wi
Hello Sundar,
Build changes look ok. I would appreciate if you could avoid increasing
the line length that much in make/Images.gmk though. It makes side by
side comparisons difficult.
/Erik
On 2015-08-12 19:03, Sundararajan Athijegannathan wrote:
Hi,
Please review changes for the bug:
htt
10 matches
Mail list logo
