Re: [9] Review Request: 8079965 Stop ignoring warnings for libawt_lwawt

2015-09-23 Thread Phil Race
IMO we should support building JDK on as many platforms as possible. Not just the RE-blessed platform of the day which can change more often than I can - or want to - update my systems as I need to build multiple releases. -phil. On 09/23/2015 01:44 PM, Sergey Bylokhov wrote: Yes I can change

Re: [9] Review Request: 8079965 Stop ignoring warnings for libawt_lwawt

2015-09-23 Thread Sergey Bylokhov
Yes I can change the types in CPrinterJob [1] via ifdef, but actually do we support sdk 10.8 in jdk9? [1] http://cr.openjdk.java.net/~serb/8079965/webrev.01/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m.sdiff.html On 23.09.15 23:34, Phil Race wrote: This looks OK except that

Re: [9] Review Request: 8079965 Stop ignoring warnings for libawt_lwawt

2015-09-23 Thread Phil Race
This looks OK except that I have a suggestion with regards to Apple's (gratuitous!) enum change OpenOffice solved this with an ifdef https://svn.apache.org/viewvc/openoffice/trunk/main/vcl/aqua/source/gdi/salprn.cxx?r1=1591062&r2=1633297&pathrev=1633297 -- openoffice/trunk/main/vcl/aqua/source/

Re: [9] RFR 4763438: Replace uses of @beaninfo with meta facility in core j2se

2015-09-23 Thread Sergey Bylokhov
Can somebody from the build team review the changes in the make file? Thanks. Please review an updated version of this fix: http://cr.openjdk.java.net/~serb/4763438/webrev.00 ccc request will be filed after the technical review. In this version - The new make file is updated - SimpleBeanInf

RFR: JDK-8137013 ar (static linker) broken since JDK-8065912

2015-09-23 Thread Magnus Ihse Bursie
(I'm resending this as it does not seem to have reached build-dev; I apologize it this is a dup.) Unfortunately JDK-8065912 broke ar, at least on solaris. In spec.gmk on posix platforms, we find AR_OUT_OPTION:=rcs$(SPACE) However, in JDK-8065912, the definition of SPACE moved from spec.gmk to

RFR: JDK-8137014 Various improvements in build infrastructure

2015-09-23 Thread Magnus Ihse Bursie
As a result of the recent work in the build-infra sandbox, here is a batch of improvements and fixes to the build-infra structure. Some of these are needed to support the conversion of the building of an Oracle internal test framework, while other are general improvements. A list of fixes incl