(moving from jdk9-dev)
Hi,
I have created a webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/
Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]
Reviewed-by: omajid, prr
Contributed-by: Matthias Klose
Regards,
Omair
* Philip Race
Hi Erik:
Looks good to me.
/Tim
I send this review prematurely. Here is a new webrev, which has been
properly tested. We had some test code compilations using the boot
javac, which hadn't properly declared DISABLE_SJAVAC. The copy paste
error in configure has also been corrected.
On my wor
Erik:
When I optimized the vardeps functionality in JDK-8136385, I caused a
regression when the variable contained '$' characters. By reading the
old value as a makefile using "include", variable substitution is
applied. To work around this, dollar characters need to be escaped
(doubled) prio
I send this review prematurely. Here is a new webrev, which has been
properly tested. We had some test code compilations using the boot
javac, which hadn't properly declared DISABLE_SJAVAC. The copy paste
error in configure has also been corrected.
On my workstation, running "make java" with h
When I optimized the vardeps functionality in JDK-8136385, I caused a
regression when the variable contained '$' characters. By reading the
old value as a makefile using "include", variable substitution is
applied. To work around this, dollar characters need to be escaped
(doubled) prior to pri