Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

2015-11-06 Thread Brian Burkhalter
Looks reasonable so far. Thanks, Brian On Nov 6, 2015, at 3:49 PM, Mikael Vidstedt wrote: > http://cr.openjdk.java.net/~mikael/webrevs/8141491/webrev.01/webrev/ > > Feedback appreciated, but I'll get back with an official RFR when I have done > some benchmarking.

Re: [9] RFR of 8140630: java/nio/Buffer/Basic.java crashes vm on linux-x64 using latest devkit to build

2015-11-06 Thread Mikael Vidstedt
Any decent compiler will inline those functions, but that said I still need to verify the performance with the fix. Here's the latests/greatest webrev: http://cr.openjdk.java.net/~mikael/webrevs/8141491/webrev.01/webrev/ There are just a few minor changes compared to webrev.00 - primarily to

Re: RFR (XS): JDK-8141548 Hotspot Windows build should respect WARNINGS_AS_ERRORS

2015-11-06 Thread Magnus Ihse Bursie
On 2015-11-06 08:18, David Holmes wrote: Looks okay to me. Where do you propose to push this? Please submit via JPRT. I was planning to use hs-rt, but I have no opinion on that, really. /Magnus Thanks. David On 6/11/2015 2:18 AM, Magnus Ihse Bursie wrote: Currently the /WX flag is hardco

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread Volker Simonis
On Fri, Nov 6, 2015 at 11:06 AM, David Holmes wrote: > On 6/11/2015 6:08 PM, Volker Simonis wrote: >> >> On Fri, Nov 6, 2015 at 8:35 AM, David Holmes >> wrote: >>> >>> Hi Magnus, >>> >>> On 6/11/2015 1:43 AM, Magnus Ihse Bursie wrote: Unfortunately, the --disable-warnings-as-errors

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread Volker Simonis
On Fri, Nov 6, 2015 at 10:35 AM, Magnus Ihse Bursie wrote: > On 2015-11-05 18:19, Volker Simonis wrote: >> >> Hi Magnus, >> >> great that finally somebody is addressing this issue! >> >> But shouldn't we also change the lines: >> >> WARNINGS_ARE_ERRORS = -Werror >> >> to: >> >> WARNINGS_ARE_ERRORS

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread Magnus Ihse Bursie
On 2015-11-06 10:52, Volker Simonis wrote: On Fri, Nov 6, 2015 at 10:35 AM, Magnus Ihse Bursie wrote: On 2015-11-05 18:19, Volker Simonis wrote: Hi Magnus, great that finally somebody is addressing this issue! But shouldn't we also change the lines: WARNINGS_ARE_ERRORS = -Werror to: WARNI

Re: RFR (XS): JDK-8141548 Hotspot Windows build should respect WARNINGS_AS_ERRORS

2015-11-06 Thread Magnus Ihse Bursie
On 2015-11-06 08:36, David Holmes wrote: Just realized as per other RFR hotspot uses WARNINGS_ARE_ERRORS not AS Yes and no. That value is only used in the unix make files, not in the Windows nmake. In there, there have been no support for disabling warnings as errors at all. I actually starte

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread David Holmes
On 6/11/2015 6:08 PM, Volker Simonis wrote: On Fri, Nov 6, 2015 at 8:35 AM, David Holmes wrote: Hi Magnus, On 6/11/2015 1:43 AM, Magnus Ihse Bursie wrote: Unfortunately, the --disable-warnings-as-errors flag only operates on the build-infra code, and does not propagate to the Hotspot build s

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread Magnus Ihse Bursie
On 2015-11-05 18:19, Volker Simonis wrote: Hi Magnus, great that finally somebody is addressing this issue! But shouldn't we also change the lines: WARNINGS_ARE_ERRORS = -Werror to: WARNINGS_ARE_ERRORS ?= -Werror in the various hotspot compiler files (e.g. make/linux/makefiles/gcc.make). Hm

Re: RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

2015-11-06 Thread Volker Simonis
On Fri, Nov 6, 2015 at 8:35 AM, David Holmes wrote: > Hi Magnus, > > On 6/11/2015 1:43 AM, Magnus Ihse Bursie wrote: >> >> Unfortunately, the --disable-warnings-as-errors flag only operates on >> the build-infra code, and does not propagate to the Hotspot build system. >> >> This is unfortunate, a