Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-17 Thread Andrew Hughes
- Original Message - > Hello, > > I think this looks mostly OK, but I'm pretty sure Magnus will want to > comment. I'm afraid he likely won't be able to until next week however. > > One thing, could you name the variable DEBUG_SYMBOLS, with the S at the > end so that it matches the confi

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-17 Thread Andrew Hughes
- Original Message - > Thank you for your comment! > > I've uploaded new webrev: >http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.01/ > > Could you review it again? > This looks better :) You could move the default setting into the AC_ARG_WITH itself (the fourth argument

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-17 Thread Andrew Hughes
- Original Message - > * Yasumasa Suenaga [2015-11-16 04:38]: > > I would like to propose JDK-8036003: Add > > --with-debug-symbols=[none|internal|external|zipped] . > > > > I had posted this enhancement which provides new make variable [1]. > > But it does not fit current jdk 9. So I pro

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-17 Thread Omair Majid
* Yasumasa Suenaga [2015-11-16 04:38]: > I would like to propose JDK-8036003: Add > --with-debug-symbols=[none|internal|external|zipped] . > > I had posted this enhancement which provides new make variable [1]. > But it does not fit current jdk 9. So I propose it again as new configure > option

RFR: JDK-8143141: Bring in minor build changes from the jigsaw/jake forest

2015-11-17 Thread Erik Joelsson
Hello, When bringing changes from jdk9 to jigsaw/jake, the merges have become quite involved. The build files in jdk9 and jake have also diverged unnecessarily over time. I would like to bring them back closer to each other so that we are only carrying the changes we really need to in jake.

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

2015-11-17 Thread Erik Joelsson
Hello, I realized that there already was a mechanism for controlling the inclusion of SA from configure. Unfortunately, this variable is not picked up by any makefile currently. I changed the explicit checks for aix-ppc and zero to instead use the variable INCLUDE_SA which configure sets up b