Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Jaroslav Bachorik
Mandy, On 25.11.2015 18:22, Mandy Chung wrote: On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk This looks fine to me. Is there any test referen

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Alan Bateman
On 25/11/2015 16:53, Jaroslav Bachorik wrote: Updated webrevs: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/jdk Thanks to Erik J. for helping me with the build script! Updated version looks good to me. -Alan

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-26 Thread Erik Joelsson
Hello, This is not sjavac, but just the rather new feature javac-server. It takes the client/server model from sjavac and applies it to plain old javac. What this means is that when we invoke javac, it will spawn off a background server process that stays alive for the duration of the build.

Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

2015-11-26 Thread Yasumasa Suenaga
I uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.04/ I implemented --with-native-debug-symbols and --enable-java-debug-symbols in it. And I deprecated --enable-debug-symbols and --enable-zip-debug-info . Thanks, Yasumasa On 2015/11/25 23:52, Yasumasa Suenaga

Silence warnings with new GCC

2015-11-26 Thread Andrew Haley
I've been getting a lot of warnings such as warning: 'size' may be used uninitialized in this function [-Wmaybe-uninitialized] which error out with -Werror. Almost all of them are bogus. They are typically of the form unsigned size; if (i->get(26, 26)) { // float switch(i->get(

RE: Silence warnings with new GCC

2015-11-26 Thread Lindenmaier, Goetz
Hi Andrew, I know about this problem ... I guess a change of mine causes these warnings. While I found a row of good fixes, these with ShouldNotReachHere are annoying. What you propose has been discussed in April: 8065585: Change ShouldNotReachHere() to never return. I didn't follow the discussi

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

2015-11-26 Thread Mandy Chung
> On Nov 26, 2015, at 2:12 AM, Jaroslav Bachorik > wrote: > > Mandy, > > On 25.11.2015 18:22, Mandy Chung wrote: >> >>> On Nov 25, 2015, at 8:53 AM, Jaroslav Bachorik >>> wrote: >>> >>> Updated webrevs: >>> >>> http://cr.openjdk.java.net/~jbachorik/8043138/webrev.01/top >>> http://cr.open

Re: Silence warnings with new GCC

2015-11-26 Thread Mario Torre
2015-11-26 20:37 GMT+01:00 Lindenmaier, Goetz : > Hi Andrew, > > I know about this problem ... I guess a change of mine causes these warnings. > While I found a row of good fixes, these with ShouldNotReachHere are annoying. > > What you propose has been discussed in April: 8065585: Change > Should

Re: Silence warnings with new GCC

2015-11-26 Thread David Holmes
On 27/11/2015 3:24 AM, Andrew Haley wrote: I've been getting a lot of warnings such as warning: 'size' may be used uninitialized in this function [-Wmaybe-uninitialized] which error out with -Werror. Almost all of them are bogus. They are typically of the form unsigned size; if (

Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

2015-11-26 Thread Wang Weijun
> On Nov 25, 2015, at 11:04 PM, Sean Mullan wrote: > > The fix looks fine to me. For testing, can you create a test that uses a > custom java.security file with "#ifndef solaris-sparc" in it, and check > whether the property is used or not depending on what system is being tested? The tool is

Re: RFR: JDK-8144039: Enable javac server by default

2015-11-26 Thread David Holmes
Hi Erik, On 26/11/2015 6:17 PM, Erik Joelsson wrote: Hello, This is not sjavac, but just the rather new feature javac-server. It takes the client/server model from sjavac and applies it to plain old javac. What this means is that when we invoke javac, it will spawn off a background server proce