Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

Hi build folks, Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.06/ Thanks, Yasumasa On 2015/12/09 13:12, David Holmes wrote: Hi, On 9/12/2015 10:31 AM, Yasumasa Suenaga wrote: Hi, I've uploaded a new webrev:

Re: RFR: JDK-8145106: Still intermittent build error building jdk/src/demo/solaris/jni/Poller/Poller.c

Looks fine. Thanks, David On 10/12/2015 11:43 PM, Erik Joelsson wrote: I accidentally posted diff against the wrong parent. Here is the correct diff: diff --git a/make/CompileDemos.gmk b/make/CompileDemos.gmk --- a/make/CompileDemos.gmk +++ b/make/CompileDemos.gmk @@ -459,7 +459,7 @@ # We

RFR: JDK-8145106: Still intermittent build error building jdk/src/demo/solaris/jni/Poller/Poller.c

Unfortunately, this fix failed. Depending on $(BUILD_DEMO_JAVA_POLLER_COMPILE_TARGETS) doesn't guarantee that the header file is there in all cases. There is a separate copy step of headers inside SetupJavaCompilation. The simple solution to this is to just depend on $(BUILD_DEMO_JAVA_Poller)

Re: RFR: JDK-8145106: Still intermittent build error building jdk/src/demo/solaris/jni/Poller/Poller.c

I accidentally posted diff against the wrong parent. Here is the correct diff: diff --git a/make/CompileDemos.gmk b/make/CompileDemos.gmk --- a/make/CompileDemos.gmk +++ b/make/CompileDemos.gmk @@ -459,7 +459,7 @@ # We can only compile native code after java has been compiled (since we #

Re: RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling

On 11/12/2015 2:15 PM, Alexander Smundak wrote: I have jcheck enabled, so I am surprised that the absence of the Reviewed-by: field was not flagged. Anyways, here's the new set: Not sure what is going on with your jcheck setup but the formatting is still wrong: - the changeset "user" must

RFR: JDK-8145115: make JAVAC_FLAGS=-g no longer works

I looked closer at your actual command lines and managed to reproduce. The problem is JAVAC_FLAGS=-g. We have unfortunately used that name for a local variable in make/CompileJavaModules.gmk. Fix is pretty simple, just rename that local variable. In the longer term, we need to be able to

Re: RFR: JDK-8145115: make JAVAC_FLAGS=-g no longer works

On Thu, 2015-12-10 at 15:49 +0100, Erik Joelsson wrote: > I looked closer at your actual command lines and managed to reproduce.  > The problem is JAVAC_FLAGS=-g. We have unfortunately used that name for  > a local variable in make/CompileJavaModules.gmk. Fix is pretty simple,  > just rename that

Re: RFR: JDK-8145106: Still intermittent build error building jdk/src/demo/solaris/jni/Poller/Poller.c

Erik: I accidentally posted diff against the wrong parent. Here is the correct diff: diff --git a/make/CompileDemos.gmk b/make/CompileDemos.gmk --- a/make/CompileDemos.gmk +++ b/make/CompileDemos.gmk @@ -459,7 +459,7 @@ # We can only compile native code after java has been compiled (since