Re: RFR: JDK-8148351 Only display resolved symlink for compiler, do not change path

2016-01-29 Thread Erik Joelsson
Looks good. /Erik On 2016-01-27 11:32, Magnus Ihse Bursie wrote: During toolchain detection, if the found compiler (CC or CXX) is a symbolic link, we resolve it and point to the resolved binary. This was introduced to be able to debug systems with a broken setup, but it breaks use cases were

Re: RFR: JDK-8148120 Incremental update from build-infra project

2016-01-29 Thread Erik Joelsson
Looks ok. /Erik On 2016-01-25 14:51, Magnus Ihse Bursie wrote: On 2016-01-25 09:13, Erik Joelsson wrote: In NativeCompilation.gmk, the exit value saving for linking is most likely redundant. I managed to remove that for the compile command lines. There I verified that failed compiles still

Re: question on jigsaw build

2016-01-29 Thread Erik Joelsson
Hello, There are no plans in this area but we are certainly open for suggestions. Generating IDE project files is definitely something we want to support. We just haven't gotten to it yet. The removal of ALL_SRC_DIRS was for code simplification in the makefiles and because javac has changed

RFR 8148617: top level make docs target does not generate javadocs for dynalink API

2016-01-29 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8148617/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8148617 Dynalink API is specified by JEP-276 (http://openjdk.java.net/jeps/276). The current change is just to add the missing makefile instructions to generate javadoc. Thanks,

Re: RFR 8148617: top level make docs target does not generate javadocs for dynalink API

2016-01-29 Thread Erik Joelsson
Looks good. /Erik On 2016-01-29 17:13, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8148617/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8148617 Dynalink API is specified by JEP-276 (http://openjdk.java.net/jeps/276). The current change is

Re: RFR 8148617: top level make docs target does not generate javadocs for dynalink API

2016-01-29 Thread Sundararajan Athijegannathan
Added newline before line 1270 in Javadoc.gmk. Updated webrev: http://cr.openjdk.java.net/~sundar/8148617/webrev.01/ -Sundar On 1/29/2016 9:53 PM, Hannes Wallnoefer wrote: Looks good. Hannes Am 2016-01-29 um 17:13 schrieb Sundararajan Athijegannathan: Please review

Re: RFR(M) 8069540: Remove universal binaries support from hotspot build

2016-01-29 Thread Erik Joelsson
(adding build-dev) Looks good enough to me. /Erik On 2016-01-29 17:51, Gerard Ziemski wrote: Hi all (and especially the makefiles experts), This fix removes support for building hotspot universal libraries on Mac OS X and simplifies the makefiles. We are still building Mac OS X hotspot

Re: RFR 8148617: top level make docs target does not generate javadocs for dynalink API

2016-01-29 Thread Hannes Wallnoefer
+1 Am 2016-01-29 um 18:11 schrieb Sundararajan Athijegannathan: Added newline before line 1270 in Javadoc.gmk. Updated webrev: http://cr.openjdk.java.net/~sundar/8148617/webrev.01/ -Sundar On 1/29/2016 9:53 PM, Hannes Wallnoefer wrote: Looks good. Hannes Am 2016-01-29 um 17:13 schrieb

Re: RFR 8148617: top level make docs target does not generate javadocs for dynalink API

2016-01-29 Thread Erik Joelsson
Looks good. Erik On 2016-01-29 18:11, Sundararajan Athijegannathan wrote: Added newline before line 1270 in Javadoc.gmk. Updated webrev: http://cr.openjdk.java.net/~sundar/8148617/webrev.01/ -Sundar On 1/29/2016 9:53 PM, Hannes Wallnoefer wrote: Looks good. Hannes Am 2016-01-29 um 17:13