Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Magnus Ihse Bursie
On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review. Makefile change look good. /Magnus Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you pleas

Re: RFR: JDK-8149647 Incremental enhancements from build-infra

2016-02-12 Thread Magnus Ihse Bursie
On 2016-02-11 14:26, Erik Joelsson wrote: flags.m4: spelling "contitionally" Fixed. Otherwise it looks good enough to me provided that it builds and output is still the same. I ran it through JPRT with your new and improved compare script. I got a compare failure on macosx for libosxui.dyl

Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Seán Coffey
Approved for jdk8u-dev once you have a peer code review. Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bug

Re: RFR: 8149594 - Clean up Hotspot makefiles

2016-02-12 Thread Magnus Ihse Bursie
On 2016-02-10 23:10, Jesper Wilhelmsson wrote: Sending again to include the build-dev list. /Jesper Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson: Hi, Please review this cleanup of the Hotspot makefiles. Since I have been spending some time in the makefiles lately there were a few random c

Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-02-12 Thread Alexey Ivanov
I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you please review the fix for JDK-8147807 and approve push to 8u-dev? JBS: https://bugs.openjdk.java.net/browse/JDK-8147807 Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/ The issue

Re: RFR: 8149594 - Clean up Hotspot makefiles

2016-02-12 Thread Magnus Ihse Bursie
On 2016-02-11 08:35, Jesper Wilhelmsson wrote: Den 11/2/16 kl. 03:07, skrev David Holmes: Jesper, Magnus is rewriting all of the hotspot build system. Are these cleanups really worthwhile at this stage? The cleanups are worthwhile to me since I work on mostly Mac and port all my changes ov