Re: RFR: JDK-8150822: Fix typo in JDK-8150201

2016-02-29 Thread David Holmes
Looks good. Thanks, David - On 29/02/2016 8:19 PM, Erik Joelsson wrote: In JDK-8150201, some debug flags were corrected. In one of the overrides, the file name was misspelled so the debug flag correction is not in effect. Bug: https://bugs.openjdk.java.net/browse/JDK-8150822 Patch: diff -

Re: Provide zipped javadoc archive from make

2016-02-29 Thread Jiri Vanek
On 02/26/2016 08:05 PM, Jonathan Gibbons wrote: On 02/26/2016 03:49 AM, Jiri Vanek wrote: On 02/25/2016 06:34 PM, Jonathan Gibbons wrote: On 02/25/2016 09:23 AM, Jiri Vanek wrote: I must be missing something. Dozens? Of varius runs of javadoc? I thought that javadoc ending at the end in sing

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Erik Joelsson
Looks correct to me. Thanks for doing this! /Erik On 2016-02-29 14:28, Dmitry Samersoff wrote: > Yasumasa, > > Looks good for me! > > -Dmitry > > > On 2016-02-29 16:26, Yasumasa Suenaga wrote: >> Hi Dmitry, Erik, >> >> I've uploaded new webrev: >> >> hotspot: >> http://cr.openjdk.java.net/~ys

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Dmitry Samersoff
Yasumasa, Looks good for me! -Dmitry On 2016-02-29 16:26, Yasumasa Suenaga wrote: > Hi Dmitry, Erik, > > I've uploaded new webrev: > > hotspot: > http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/ > makefile: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/ma

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Yasumasa Suenaga
Hi Dmitry, Erik, I've uploaded new webrev: hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/ makefile: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/make/ > Could you move gif files to correct location and remove custom makefile > logic? I moved cla

Should we use '-fno-asynchronous-unwind-tables' to reduce the size of libjvm.so by 10 percent?

2016-02-29 Thread Volker Simonis
Hi, We are currently building and linking the libjvm.so on Linux with -fnoexceptions because we currently don't use C++ exception handling in the HotSpot. Nevertheless, g++ generates unwind tables (i.e. .eh_frame sections) in the object files and shared libraries which can not be stripped from th

Re: RFR: JDK-8150822: Fix typo in JDK-8150201

2016-02-29 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 29 feb. 2016 kl. 11:19 skrev Erik Joelsson : > > In JDK-8150201, some debug flags were corrected. In one of the overrides, the > file name was misspelled so the debug flag correction is not in effect. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8150822 > > P

RFR: JDK-8150822: Fix typo in JDK-8150201

2016-02-29 Thread Erik Joelsson
In JDK-8150201, some debug flags were corrected. In one of the overrides, the file name was misspelled so the debug flag correction is not in effect. Bug: https://bugs.openjdk.java.net/browse/JDK-8150822 Patch: diff -r 63a9e10565c4 make/solaris/makefiles/amd64.make --- a/make/solaris/makefiles

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Dmitry Samersoff
Yasumasa, I think it's better to have a complete fix rather than yet another workaround. Could you move gif files to correct location and remove custom makefile logic? I'll sponsor the push then. -Dmitry On 2016-02-27 06:44, Yasumasa Suenaga wrote: > Hi Erik, > > Thanks! > I've uploaded new w

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

2016-02-29 Thread Erik Joelsson
On 2016-02-27 04:44, Yasumasa Suenaga wrote: > Hi Erik, > > Thanks! > I've uploaded new webrev. Could you review it? > http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.01/ This looks ok to me. >> However, the real fix is to move the gifs out of the images dir so that >> they have the cor