Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread David Holmes
Just a couple of FYIs: 1. hotspot groups require copyright updates on pushes to hotspot forests; other groups do not. Hence many non-hotspot sources have out of date copyrights - these will eventually be fixed en-masse. 2. The CXXFLAGS situation, as alluded, arose out of confusion with the o

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread Andrew Hughes
- Original Message - > > On Mar 14, 2016, at 3:17 PM, Andrew Hughes wrote: > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 > > Webrev: http://cr.openjdk.java.net/~andrew/8151841/webrev.01/ > > > > A number of additional flags need to be passed to the C and C++ compiler > >

Re: RFR: JDK-8151653: Hotspot build does not respect --enable-openjdk-only

2016-03-14 Thread David Holmes
On 14/03/2016 11:22 AM, David Holmes wrote: Hi Erik, On 12/03/2016 2:31 AM, Erik Joelsson wrote: Hello, When building hotspot with closed sources present and configuring with --enable-openjdk-only, various closed parts are included in the build anyway, at least on Windows. This needs to be fix

Re: RFR: JDK-8151726: Introduce a JPRT testset buildinfra

2016-03-14 Thread David Holmes
Seems fine. Thanks, David On 12/03/2016 2:52 AM, Erik Joelsson wrote: When verifying build changes, we are currently lacking a good way of doing all relevant builds in one JPRT job. Some build configurations we aren't even able to test at all. To facilitate this, I would like to introduce a new

Re: RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread Kim Barrett
> On Mar 14, 2016, at 3:17 PM, Andrew Hughes wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 > Webrev: http://cr.openjdk.java.net/~andrew/8151841/webrev.01/ > > A number of additional flags need to be passed to the C and C++ compiler > for OpenJDK to compile with GCC 6: This mi

Re: RFR: JDK-8151770: 9-client windows builds failed from 2016-03-11

2016-03-14 Thread Philip Race
Hi Erik, Looks OK and I verified your jprt job completed. I have pushed it as -u erikj Separately I am trying to find out why there was no email notification the nightly builds were failing. -phil. On 3/14/16, 9:56 AM, Erik Joelsson wrote: Hello, The build is currently broken on Windows in j

RFR: 8151841: Build needs additional flags to compile with GCC 6

2016-03-14 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 Webrev: http://cr.openjdk.java.net/~andrew/8151841/webrev.01/ A number of additional flags need to be passed to the C and C++ compiler for OpenJDK to compile with GCC 6: 1. The C++ standard needs to be explicitly lowered to the old default of

RFR: JDK-8151770: 9-client windows builds failed from 2016-03-11

2016-03-14 Thread Erik Joelsson
Hello, The build is currently broken on Windows in jdk9/client. This patch reverts some and cleans up the makefile changes made in JDK-8145174. I have verified that it builds on Windows and Linux and am just starting a JPRT job to verify the rest. Looking through the review thread for JDK-81