Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Thank you for review. Leonid On 05.05.2016 00:42, David Holmes wrote: On 5/05/2016 12:10 AM, Leonid Mesnik wrote: The hotspot changes are fixed separately and the final fix is only changes in the root. It remains the same. http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/

Re: RFR: 8150044: Generate classlists at build-time

> On May 4, 2016, at 1:12 PM, Claes Redestad wrote: > > >> >> One question: where do you create the interim JMOD files? Or do you create >> it under images/jmods? > > No interim jmods are created for regular builds, while for cross-compilation > a buildjdk is created from JMOD files genera

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

On 5/05/2016 12:10 AM, Leonid Mesnik wrote: The hotspot changes are fixed separately and the final fix is only changes in the root. It remains the same. http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/ Ok. Thanks, David

Re: RFR: 8150044: Generate classlists at build-time

On 2016-05-04 21:45, Mandy Chung wrote: On May 4, 2016, at 6:36 AM, Claes Redestad wrote: Hi, please review this change to generate classlists at build-time bug: https://bugs.openjdk.java.net/browse/JDK-8150044 webrevs: top: http://cr.openjdk.java.net/~redestad/8150044/top.01/ jdk: http://

Re: RFR: 8150044: Generate classlists at build-time

> On May 4, 2016, at 6:36 AM, Claes Redestad wrote: > > Hi, > > please review this change to generate classlists at build-time > > bug: https://bugs.openjdk.java.net/browse/JDK-8150044 > > webrevs: > top: http://cr.openjdk.java.net/~redestad/8150044/top.01/ > jdk: http://cr.openjdk.java.net/~

Re: RFR: JDK-8156036: Enable building of arm targets in default JPRT testset

On 4 May 2016, at 16:47, Erik Joelsson wrote: > This is the open part of an Oracle internal change to JPRT. It requires > adding of a hook in the open configuration file. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8156036 > Webrev: http://cr.openjdk.java.net/~erikj/8156036/webrev.top.01

Re: RFR: JDK-8156036: Enable building of arm targets in default JPRT testset

Erik: This is the open part of an Oracle internal change to JPRT. It requires adding of a hook in the open configuration file. Bug: https://bugs.openjdk.java.net/browse/JDK-8156036 Webrev: http://cr.openjdk.java.net/~erikj/8156036/webrev.top.01 Looks good to me. /Tim

RFR: JDK-8156036: Enable building of arm targets in default JPRT testset

This is the open part of an Oracle internal change to JPRT. It requires adding of a hook in the open configuration file. Bug: https://bugs.openjdk.java.net/browse/JDK-8156036 Webrev: http://cr.openjdk.java.net/~erikj/8156036/webrev.top.01/ /Erik

Re: RFR: 8150044: Generate classlists at build-time

On 04/05/2016 14:36, Claes Redestad wrote: Hi, please review this change to generate classlists at build-time bug: https://bugs.openjdk.java.net/browse/JDK-8150044 webrevs: top: http://cr.openjdk.java.net/~redestad/8150044/top.01/ jdk: http://cr.openjdk.java.net/~redestad/8150044/jdk.01/ hot

Re: RFR: 8150044: Generate classlists at build-time

Hi Ioi, On 2016-05-04 16:05, Ioi Lam wrote: Hi Claes, The HotSpot changes look good to me. thanks! I am not knowledgeable enough to comment on the top repo makefile changes. Regarding the JDK changes, in HelloClasslist.java: Maybe add a comment about how/why you choose this particular

Re: RFR: 8150044: Generate classlists at build-time

Once installed, autoconf ran properly with make reconfigure - thx. > On May 4, 2016, at 11:24 AM, Erik Joelsson wrote: > > Depends on which OS you are using. You need version 2.69, which is the > latest. On linux, "apt-get/yum install autoconf" should do the trick unless > your distribution i

Re: RFR: 8150044: Generate classlists at build-time

On 04/05/2016 15:05, Ioi Lam wrote: : Regarding the JDK changes, in HelloClasslist.java: Maybe add a comment about how/why you choose this particular set of operations? When the JDK evolves in the future, how should this file be changed? I notice that no GUI classes are used. Is the reaso

Re: RFR: 8150044: Generate classlists at build-time

Depends on which OS you are using. You need version 2.69, which is the latest. On linux, "apt-get/yum install autoconf" should do the trick unless your distribution is ancient. On windows add autoconf through the cygwin installer. On mac I think "brew install autoconf" is easiest if you are int

Re: RFR: 8150044: Generate classlists at build-time

Correct. How do I set up autogen so I can apply these changes? > On May 4, 2016, at 11:11 AM, Erik Joelsson wrote: > > Build changes look ok to me, but I also helped write most of them. > > This certainly adds some build complexity and might seem overly so for just > this optimization. As I

Re: RFR: 8150044: Generate classlists at build-time

Build changes look ok to me, but I also helped write most of them. This certainly adds some build complexity and might seem overly so for just this optimization. As I understand it, the plan is to expand this build time profiling concept to generate more profile data that can be used by for ex

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

The hotspot changes are fixed separately and the final fix is only changes in the root. It remains the same. http://cr.openjdk.java.net/~lmesnik/8155950/webrev.00/root/ Leonid On 04.05.2016 13:23, David Holmes wrote: On 4/05/2016

Re: RFR: 8150044: Generate classlists at build-time

Hi Claes, The HotSpot changes look good to me. I am not knowledgeable enough to comment on the top repo makefile changes. Regarding the JDK changes, in HelloClasslist.java: Maybe add a comment about how/why you choose this particular set of operations? When the JDK evolves in the future, how

RFR: 8150044: Generate classlists at build-time

Hi, please review this change to generate classlists at build-time bug: https://bugs.openjdk.java.net/browse/JDK-8150044 webrevs: top: http://cr.openjdk.java.net/~redestad/8150044/top.01/ jdk: http://cr.openjdk.java.net/~redestad/8150044/jdk.01/ hotspot: http://cr.openjdk.java.net/~redestad/815

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Hi On 04.05.2016 13:23, David Holmes wrote: On 4/05/2016 7:01 PM, Leonid Mesnik wrote: David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also i

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

On 4/05/2016 7:01 PM, Leonid Mesnik wrote: David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946

RFR: JDK-8156018: Hotspot visual studio project generation broken

With the new hotspot build, there was supposed to be support for creating a visual studio project, as was possible in the old build system. When creating the final changeset I missed including some of the files needed for that. Here are the changes as they were supposed to be, including removin

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Thank you for review. I will separate gc fix from this commit and push only build changes here . Leonid On 04.05.2016 11:15, Erik Joelsson wrote: Jib change looks good to me. /Erik On 2016-05-04 08:43, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of d

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

David On 04.05.2016 11:40, David Holmes wrote: On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

On 4/05/2016 4:43 PM, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946 . Bug: https://bugs.openjdk.java.net/browse/

Re: RFR(S): 8155950: Add minimal VM in JIB profile on linux-x86

Jib change looks good to me. /Erik On 2016-05-04 08:43, Leonid Mesnik wrote: Please review this small change which adds minimal VM as a part of default JIB profile on linux-x86. The fix also include quick workaround for bug JDK-8155946 . Bug