Hi all,
this small patch ensures that the Makefiles correctly excludes gtest
unit tests for a minimal build. Right now, if you add a test to e.g.
hotspot/native/gc/g1, the test will be included in a minimal build,
which will fail.
Thanks to Erik Joelsson for helping out with this patch!
Bug:
htt
Naturally, I think it looks good. It might need some further tweaking
down the line, but this should work for now.
/Erik
On 2016-05-19 12:44, Erik Helin wrote:
Hi all,
this small patch ensures that the Makefiles correctly excludes gtest
unit tests for a minimal build. Right now, if you add a
Sorry Erik but I don't follow what this patch is doing - not familiar
with how gtest actually works. Where does the minimal build come into
what has been changed? This seems to be changing how GTEST_LIBJVM is
built, not when it is built ??
Thanks,
David
On 19/05/2016 8:44 PM, Erik Helin wrote
Hello,
I will try to explain.
The GTEST_LIBJVM consists of 3 things:
1. All the objects of libjvm.so
2. The gtest framework
3. The actual test objects
This patch changes how the sources for 3 are found. Before this patch,
the tests were found by searching hotspot/test/native for test*.cpp,
w
Thanks Erik - Erik H just explained that to me via IM.
I'm afraid I'm a still on unfamiliar ground with the new hotspot build.
Cheers,
David
On 19/05/2016 10:18 PM, Erik Joelsson wrote:
Hello,
I will try to explain.
The GTEST_LIBJVM consists of 3 things:
1. All the objects of libjvm.so
2. T
Hi,
I'm looking into a build failure we are seeing for the Zero JVM variant
build of JDK 9. The failure looks like this:
Generating lib/classlist
/home/sgehwolf/Documents/openjdk/upstream-sources/openjdk9-hs-pristine/build/linux-x86_64-normal-zero-release/support/interim-image/bin/java
-XX:Dump
Looks good!
/Jesper
Den 19/5/16 kl. 12:44, skrev Erik Helin:
Hi all,
this small patch ensures that the Makefiles correctly excludes gtest
unit tests for a minimal build. Right now, if you add a test to e.g.
hotspot/native/gc/g1, the test will be included in a minimal build,
which will fail.
Th
That's a good point, we should add a way to turn it off.
/Erik
On 2016-05-19 14:59, Severin Gehwolf wrote:
Hi,
I'm looking into a build failure we are seeing for the Zero JVM variant
build of JDK 9. The failure looks like this:
Generating lib/classlist
/home/sgehwolf/Documents/openjdk/upstrea
On 18/05/2016 15:39, Erik Joelsson wrote:
This patch replaces the list of indirectly upgradeable modules with a
generated list.
Bug: https://bugs.openjdk.java.net/browse/JDK-8155786
Webrev:
http://cr.openjdk.java.net/~erikj/8155786/webrev.top.01/index.html
This looks good to me.
-Alan
> On May 18, 2016, at 7:39 AM, Erik Joelsson wrote:
>
> This patch replaces the list of indirectly upgradeable modules with a
> generated list.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8155786
> Webrev: http://cr.openjdk.java.net/~erikj/8155786/webrev.top.01/index.html
Looks good.
On Thu, 2016-05-19 at 15:10 +0200, Erik Joelsson wrote:
> That's a good point, we should add a way to turn it off.
OK. Shall I open a bug for this?
Cheers,
Severin
> /Erik
>
> On 2016-05-19 14:59, Severin Gehwolf wrote:
> >
> > Hi,
> >
> > I'm looking into a build failure we are seeing for th
Please do.
/Erik
On 2016-05-19 16:33, Severin Gehwolf wrote:
On Thu, 2016-05-19 at 15:10 +0200, Erik Joelsson wrote:
That's a good point, we should add a way to turn it off.
OK. Shall I open a bug for this?
Cheers,
Severin
/Erik
On 2016-05-19 14:59, Severin Gehwolf wrote:
Hi,
I'm lookin
On Thu, 2016-05-19 at 16:38 +0200, Erik Joelsson wrote:
> Please do.
Done:
https://bugs.openjdk.java.net/browse/JDK-8157336
Cheers,
Severin
> /Erik
>
> On 2016-05-19 16:33, Severin Gehwolf wrote:
> >
> > On Thu, 2016-05-19 at 15:10 +0200, Erik Joelsson wrote:
> > >
> > > That's a good point, w
Hello again!
webrev
https://jvanek.fedorapeople.org/oracle/jdk9/webrevs/reproduciblePolicies/v1/
Recent Feature Complete milestone have scared me, as I have long-time persisting issue when
packaging openjdk (6..7...8 and 9)
The policy jars, always from same source, never the same. As they ar
Several recent build changes and source moves have made certain subset
configurations of the source fail to build. Some minor tweaks are needed
to correct this.
* Building of gtest needs to be conditional on the test sources being
available. Also adding --disable-gtest to be able to turn it of
Hello Jiri,
If I understand the question correctly, you are wondering how the policy
files from CreateSecurityJars.gmk end up in the final image? This is
done in two steps. First the new JDK 9 tool jmod packages each module
into a distribution format (typically java.base.jmod). Then the next n
Erik:
Several recent build changes and source moves have made certain subset
configurations of the source fail to build. Some minor tweaks are
needed to correct this.
* Building of gtest needs to be conditional on the test sources being
available. Also adding --disable-gtest to be able to tu
17 matches
Mail list logo
