Re: RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Erik Joelsson
Hello, I cannot think of a more suitable place to put this right now. So far we have not had a need for module specific configuration for jmod creation. If this need grows, we might need to think of something. (sort of related, I have been thinking of ways to move all the java compilation det

Re: RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Alan Bateman
On 07/09/2016 13:27, Sundararajan Athijegannathan wrote: jjs does not yet support module related options. So, user modules can not be scripted directly with jjs as of now. Only way is to use to launcher with -mp along with -m for jjs main class. With the change, only module name needs to be spec

Re: RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Sundararajan Athijegannathan
jjs does not yet support module related options. So, user modules can not be scripted directly with jjs as of now. Only way is to use to launcher with -mp along with -m for jjs main class. With the change, only module name needs to be specified. Also, jjs tool is not shipped for embedded platforms

Re: RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Alan Bateman
On 07/09/2016 13:10, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8165595/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165595 I'm not sure that asking users to use -m is right here, esp. when the modules contains launchers. Also CreateJmods.g

Re: RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Jim Laskey (Oracle)
+1 > On Sep 7, 2016, at 9:10 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8165595/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8165595 > > Thanks > > -Sundar >

RFR 8165595: Main class should be set for nashorn modules

2016-09-07 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8165595/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8165595 Thanks -Sundar