Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

2016-10-31 Thread Vladimir Kozlov
Thank you, Andrew I fixed compiledCI_aarch64.cpp and updated webrev in place. Thanks, Vladimir On 10/31/16 8:35 AM, Andrew Dinn wrote: Hi Vladimir, On 31/10/16 11:38, Andrew Dinn wrote: On 28/10/16 16:52, Vladimir Kozlov wrote: Thank you, Andrew, for verifying that build changes do not brea

Re: support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
In case this bites anyone else, the workaround below will keep you going :-) Thank you again Magnus Best Lance > On Oct 31, 2016, at 2:09 PM, Magnus Ihse Bursie > wrote: > > Lance, > > This is most likely due to a missed dependency in the recent Javadoc > refactoring, which is triggered on y

Re: RFR: JDK-8062810: Examine src.zip in JDK image and decide if source classes should be organized by module

2016-10-31 Thread Omair Majid
* Mandy Chung [2016-10-31 16:32]: > Yes this change impacts IDE. > > We have contacted some IDE vendors including NetBeans, IntelliJ, > JDeveloper, Eclipse about this proposed change and confirm that they > are ok with the proposed change from several of them. Great to hear this. Thanks! Omair

Re: RFR: JDK-8062810: Examine src.zip in JDK image and decide if source classes should be organized by module

2016-10-31 Thread Mandy Chung
> On Oct 31, 2016, at 12:52 PM, Omair Majid wrote: > > * Erik Joelsson [2016-10-10 09:55]: >> Please review this change, which reorganizes src.zip into modules >> directories. It also includes the source of any imported modules into >> src.zip. > > My main use case for src.zip is stepping into

Re: RFR: JDK-8062810: Examine src.zip in JDK image and decide if source classes should be organized by module

2016-10-31 Thread Omair Majid
* Erik Joelsson [2016-10-10 09:55]: > Please review this change, which reorganizes src.zip into modules > directories. It also includes the source of any imported modules into > src.zip. My main use case for src.zip is stepping into JDK code and setting breakpoints when I am debugging my applicat

Re: support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
Thank you for the suggestion Magnus, I will try that. I am on OS X 10.11.4 FWIW Best Lance > On Oct 31, 2016, at 2:09 PM, Magnus Ihse Bursie > wrote: > > Lance, > > This is most likely due to a missed dependency in the recent Javadoc > refactoring, which is triggered on your build platform.

Re: support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Magnus Ihse Bursie
Lance, This is most likely due to a missed dependency in the recent Javadoc refactoring, which is triggered on your build platform. A workaround for you right now is to do 'make jdk.jdi' first, which will make sure the Javadoc stage later will succeed. Sorry for the inconvenience. :-( /Magn

support/gensrc/jdk.jdi/jdwp-protocol.html build error

2016-10-31 Thread Lance Andersen
Hi, I just pulled the latest JDK 9 source (open and closed) and can no longer build as I am getting the following error: make[3]: *** No rule to make target `/Users/ljanders/Documents/hg-workspaces/openjdk9/modular-dev/build/macosx-x86_64-normal-server-release/support/gensrc/jdk.jdi/jdwp-protoc

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
On 10/31/16 11:38 AM, Phil Race wrote: > +1. > > I am assuming you made sure AccessBridgeCalls.c is not being compiled > during the JDK build as discussed earlier ... I looked into this. The obj is needed to build accessbridgeinspector/walker. Searching the built directories AccessBridgeCalls.*

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Phil Race
+1. I am assuming you made sure AccessBridgeCalls.c is not being compiled during the JDK build as discussed earlier ... -phil. On 10/31/2016 07:36 AM, Pete Brunet wrote: On 10/28/16 8:14 PM, Mandy Chung wrote: On Oct 28, 2016, at 1:59 PM, Philip Race wrote: If it is not in the image then t

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

2016-10-31 Thread Vladimir Kozlov
Thank you, Erik On 10/31/16 3:11 AM, Erik Joelsson wrote: Hello Vladimir, The new organization of the checks looks good. Just found one minor nit, in lib-elf.m4, no need to AC_SUBST(ENABLE_AOT) again. Removed. Thanks, Vladimir /Erik On 2016-10-29 04:23, Vladimir Kozlov wrote: Updated b

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

2016-10-31 Thread Andrew Dinn
Hi Vladimir, On 31/10/16 11:38, Andrew Dinn wrote: > On 28/10/16 16:52, Vladimir Kozlov wrote: >> Thank you, Andrew, for verifying that build changes do not break AArch64. >> But it would be nice if you can also apply Hotspot changes (revert >> hs.make.webrev changes before that since hs.webrev ha

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Mandy Chung
> On Oct 31, 2016, at 7:36 AM, Pete Brunet wrote: > > > > On 10/28/16 8:14 PM, Mandy Chung wrote: >>> On Oct 28, 2016, at 1:59 PM, Philip Race wrote: >>> >>> If it is not in the image then there is no point in the file existing. >>> Maybe this could just be a comment at the top of the includ

Re: RFR: JDK-8168950: Incremental build of images always rebuilds jmods

2016-10-31 Thread Tim Bell
Erik: A mistake in JDK-8166948 is causing jmods and images to always be rebuilt on subsequent calls to make when nothing should have changed. I forgot to touch the marker file at the end of the recipe for doing the module-info optimization. Bug: https://bugs.openjdk.java.net/browse/JDK-8168950

RFR: JDK-8168950: Incremental build of images always rebuilds jmods

2016-10-31 Thread Erik Joelsson
A mistake in JDK-8166948 is causing jmods and images to always be rebuilt on subsequent calls to make when nothing should have changed. I forgot to touch the marker file at the end of the recipe for doing the module-info optimization. Bug: https://bugs.openjdk.java.net/browse/JDK-8168950 Patc

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-31 Thread Pete Brunet
On 10/28/16 8:14 PM, Mandy Chung wrote: >> On Oct 28, 2016, at 1:59 PM, Philip Race wrote: >> >> If it is not in the image then there is no point in the file existing. >> Maybe this could just be a comment at the top of the include file. >> > This works for me. Updated: http://cr.openjdk.java.ne

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

2016-10-31 Thread Andrew Dinn
Hi Vladimir, On 28/10/16 16:52, Vladimir Kozlov wrote: > Thank you, Andrew, for verifying that build changes do not break AArch64. > But it would be nice if you can also apply Hotspot changes (revert > hs.make.webrev changes before that since hs.webrev have them): > > http://cr.openjdk.java.net/~

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

2016-10-31 Thread Erik Joelsson
Hello Vladimir, The new organization of the checks looks good. Just found one minor nit, in lib-elf.m4, no need to AC_SUBST(ENABLE_AOT) again. /Erik On 2016-10-29 04:23, Vladimir Kozlov wrote: Updated build webrevs (webrev.2) http://cr.openjdk.java.net/~kvn/aot/top.webrev.2/ http://cr.open