Re: RFR: JDK-8169632: Update compare script for clean compare

2016-11-14 Thread Tim Bell
Erik: The build compare script needs to be updated to handle some new exceptions and tweaking some old so that we have a clean baseline again. * The special treatment of the lib/classlist file needs to apply in macosx bundle images. * Since the changes to debug symbols handling, the native comp

Re: RFR(XXS): 8169630: Fix wrong cpu build flag for Linux/ppc64le build

2016-11-14 Thread Erik Joelsson
Looks good. Will sponsor. /Erik On 2016-11-14 11:19, Volker Simonis wrote: Hi, can somebody please review and sponsor the following tiny build fix which only affects ppc64le but requires the re-generation of generated-config.sh: http://cr.openjdk.java.net/~simonis/webrevs/2016/8169630/ https

RFR(XXS): 8169630: Fix wrong cpu build flag for Linux/ppc64le build

2016-11-14 Thread Volker Simonis
Hi, can somebody please review and sponsor the following tiny build fix which only affects ppc64le but requires the re-generation of generated-config.sh: http://cr.openjdk.java.net/~simonis/webrevs/2016/8169630/ https://bugs.openjdk.java.net/browse/JDK-8169630 On ppc64le we use "-mcpu=power7 -mt

Re: RFR(XS): 8169625: Libjsig build doesn't set flags for ppc64/s390 builds

2016-11-14 Thread Volker Simonis
Thanks a lot Erik! Volker On Mon, Nov 14, 2016 at 11:14 AM, Erik Joelsson wrote: > Looks good. I will push it. > > /Erik > > > > On 2016-11-14 11:09, Volker Simonis wrote: >> >> Hi, >> >> can I please have a review and sponsor for the following small change >> which only affects ppc64/s390x but

Re: RFR(XS): 8169625: Libjsig build doesn't set flags for ppc64/s390 builds

2016-11-14 Thread Erik Joelsson
Looks good. I will push it. /Erik On 2016-11-14 11:09, Volker Simonis wrote: Hi, can I please have a review and sponsor for the following small change which only affects ppc64/s390x but touches a shared make file: http://cr.openjdk.java.net/~simonis/webrevs/2016/8169625/ https://bugs.openjdk

RFR: JDK-8169632: Update compare script for clean compare

2016-11-14 Thread Erik Joelsson
The build compare script needs to be updated to handle some new exceptions and tweaking some old so that we have a clean baseline again. * The special treatment of the lib/classlist file needs to apply in macosx bundle images. * Since the changes to debug symbols handling, the native comparison

RFR(XS): 8169625: Libjsig build doesn't set flags for ppc64/s390 builds

2016-11-14 Thread Volker Simonis
Hi, can I please have a review and sponsor for the following small change which only affects ppc64/s390x but touches a shared make file: http://cr.openjdk.java.net/~simonis/webrevs/2016/8169625/ https://bugs.openjdk.java.net/browse/JDK-8169625 It is unfortunate that the build of the libjsig libr