Re: Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-22 Thread Jim Laskey (Oracle)
+1 > On Nov 22, 2016, at 5:07 PM, Mandy Chung wrote: > > This patch moves src.zip and jrt-fs.jar from the top-level into > the `lib` directory in the run-time image as we proposed [1]. > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ > > thanks > Mandy > [1] >

Review Request: JDK-8169816 Move src.zip and jrt-fs.jar under the lib directory

2016-11-22 Thread Mandy Chung
This patch moves src.zip and jrt-fs.jar from the top-level into the `lib` directory in the run-time image as we proposed [1]. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/ thanks Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-November/010128.html

Re: RFR: JDK-8170184 Remove incorrect comments about generated jvmt.h

2016-11-22 Thread Erik Joelsson
Looks good. /Erik On 2016-11-22 14:56, Magnus Ihse Bursie wrote: The inclusion of the generated jvmti.h was fixed in JDK-8063154, however the comments still state that this does not work. Bug: https://bugs.openjdk.java.net/browse/JDK-8170184 Patch inline: diff --git a/make/gensrc/GensrcJvmti

Re: RFR: JDK-8170184 Remove incorrect comments about generated jvmt.h

2016-11-22 Thread Alan Bateman
On 22/11/2016 13:56, Magnus Ihse Bursie wrote: The inclusion of the generated jvmti.h was fixed in JDK-8063154, however the comments still state that this does not work. Bug: https://bugs.openjdk.java.net/browse/JDK-8170184 Patch inline: diff --git a/make/gensrc/GensrcJvmti.gmk b/make/gensrc/

RFR: JDK-8170184 Remove incorrect comments about generated jvmt.h

2016-11-22 Thread Magnus Ihse Bursie
The inclusion of the generated jvmti.h was fixed in JDK-8063154, however the comments still state that this does not work. Bug: https://bugs.openjdk.java.net/browse/JDK-8170184 Patch inline: diff --git a/make/gensrc/GensrcJvmti.gmk b/make/gensrc/GensrcJvmti.gmk --- a/make/gensrc/GensrcJvmti.gmk

Re: RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

2016-11-22 Thread Erik Joelsson
Looks good. /Erik On 2016-11-22 14:40, Magnus Ihse Bursie wrote: On 2016-11-22 12:19, Magnus Ihse Bursie wrote: On 2016-11-22 11:23, Erik Joelsson wrote: Hello, In spec.gmk.in, shouldn't it be "ZIPEXE:=@ZIPEXE@"? You are absolutely right. How could that ever have worked?! And I did run i

Re: RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

2016-11-22 Thread Magnus Ihse Bursie
On 2016-11-22 12:19, Magnus Ihse Bursie wrote: On 2016-11-22 11:23, Erik Joelsson wrote: Hello, In spec.gmk.in, shouldn't it be "ZIPEXE:=@ZIPEXE@"? You are absolutely right. How could that ever have worked?! And I did run it through jprt... I'll fix and re-check. Updated webrev: http://c

Re: RFR: JDK-8170077 Properly parallelize javadoc generation

2016-11-22 Thread Erik Joelsson
Looks good to me. /Erik On 2016-11-21 10:25, Magnus Ihse Bursie wrote: The current javadoc generation first creates the coredocs Javadoc, and after that all the remaining javadoc instances. This dependency is not really needed, all that is required is that the remaining javadoc instances ge

Re: RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

2016-11-22 Thread Magnus Ihse Bursie
On 2016-11-22 11:23, Erik Joelsson wrote: Hello, In spec.gmk.in, shouldn't it be "ZIPEXE:=@ZIPEXE@"? You are absolutely right. How could that ever have worked?! And I did run it through jprt... I'll fix and re-check. /Magnus /Erik On 2016-11-22 10:58, Magnus Ihse Bursie wrote: Followin

Re: RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

2016-11-22 Thread Erik Joelsson
Hello, In spec.gmk.in, shouldn't it be "ZIPEXE:=@ZIPEXE@"? /Erik On 2016-11-22 10:58, Magnus Ihse Bursie wrote: Following the standard by other tools, we set ZIP to the path of the zip binary. However, ZIP is interpreted as a way to control options for the Info-Zip zip binary. The soluti

RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

2016-11-22 Thread Magnus Ihse Bursie
Following the standard by other tools, we set ZIP to the path of the zip binary. However, ZIP is interpreted as a way to control options for the Info-Zip zip binary. The solution is to rename the variable ZIP to ZIPEXE. Bug: https://bugs.openjdk.java.net/browse/JDK-8168037 WebRev: http://cr

Re: PPC64: Poor StrictMath performance due to non-optimized compilation

2016-11-22 Thread Andrew Haley
On 22/11/16 00:41, Gustavo Romero wrote: > Do you know if the gap between Math and StrictMath is also huge on aarch64? I'll try to have a look. Andrew.