If I only want jar.exe

Which target should I build with? Seems jdk.jartool is not enough. VM not complete. Also, I feel that jdk.jartool includes jdk.jartool-launchers, but java.base does not include java.base-launchers. Thanks Max

Re: RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

Thanks! > On 16 Dec 2016, at 19:45, Igor Ignatyev wrote: > > Looks good to me. > > Thanks, > — Igor > >> On Dec 16, 2016, at 5:10 PM, Staffan Larsen >> wrote: >> >> Good point. New webrev: http://cr.openjdk.java.net/~sla/8171366/webrev.01/ >>

correct version of the autoconf tools?

Hi all, What is the correct version of the autoconf tools to use when regenerating generated-configure.sh? I am generating with autoconf 2.69 and get a number of diffs unrelated to my change, among others: + -runstatedir | --runstatedir | --runstatedi | --runstated \ + | --runstate | --runstat

Re: correct version of the autoconf tools?

Hi Thomas, On 19/12/2016 8:15 PM, Thomas Stüfe wrote: Hi all, What is the correct version of the autoconf tools to use when regenerating generated-configure.sh? Current checked-in hs and dev versions says # Generated by GNU Autoconf 2.69 for OpenJDK jdk9. I am generating with autoconf 2.6

Re: correct version of the autoconf tools?

I think it's still 2.69 - at least that's what generated-configure.sh pretends: #! /bin/sh # Guess values for system-dependent variables and create Makefiles. # Generated by GNU Autoconf 2.69 for OpenJDK jdk9. In general you don't have to really care because it has to be re-generated on Oracle's

Problem building Aarch64 hs today Internal error: Invalid feature tested: aot.

lib/JvmFeatures.gmk:150: *** Internal error: Invalid feature tested: aot. Stop. This is the code in question: ifeq ($(call check-jvm-feature, aot), true) JVM_CFLAGS_FEATURES += -DINCLUDE_AOT else JVM_EXCLUDE_FILES += \ compiledIC_aot_x86_64.cpp compilerRuntime.cpp \ aotCodeHeap

Re: Problem building Aarch64 hs today Internal error: Invalid feature tested: aot.

Hi Andrew, On 19/12/2016 8:41 PM, Andrew Haley wrote: lib/JvmFeatures.gmk:150: *** Internal error: Invalid feature tested: aot. Stop. Did you do a reconfigure before building? This is the code in question: ifeq ($(call check-jvm-feature, aot), true) JVM_CFLAGS_FEATURES += -DINCLUDE_AOT

Re: Problem building Aarch64 hs today Internal error: Invalid feature tested: aot.

On 19/12/16 10:53, David Holmes wrote: > On 19/12/2016 8:41 PM, Andrew Haley wrote: >> lib/JvmFeatures.gmk:150: *** Internal error: Invalid feature tested: aot. >> Stop. > Did you do a reconfigure before building? > Ah, maybe not. I'll delete the entire build dir and start again. Thanks, An

Re: correct version of the autoconf tools?

Hi David, On Mon, Dec 19, 2016 at 11:35 AM, David Holmes wrote: > Hi Thomas, > > On 19/12/2016 8:15 PM, Thomas Stüfe wrote: > >> Hi all, >> >> What is the correct version of the autoconf tools to use when regenerating >> generated-configure.sh? >> > > Current checked-in hs and dev versions says

Re: correct version of the autoconf tools?

Hi Volker, On Mon, Dec 19, 2016 at 11:35 AM, Volker Simonis wrote: > I think it's still 2.69 - at least that's what generated-configure.sh > pretends: > > #! /bin/sh > # Guess values for system-dependent variables and create Makefiles. > # Generated by GNU Autoconf 2.69 for OpenJDK jdk9. > > In

RFR(xs): 8171433: [aix] switch on gtest AIX build

Hi all, Please review this tiny change. Note that this was already part of the review of 8171225. I decided to split that patch into multiple patches. This patch here just switches on building of gtest on AIX by default (it was disabled due to build errors before). Issue: https://bugs.openjdk.j

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

On Sun, Dec 18, 2016 at 1:50 PM, Thomas Stüfe wrote: > Hi all, > > please take a look at this small fix. In short, on AIX when linking the > gtest version of libjvm.so, the TOC overflows. > > So the gtest libjvm.so must be linked with -bbigtoc, in contrast to the > regular libjvm.so, which has no

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

On Sun, Dec 18, 2016 at 1:13 PM, Thomas Stüfe wrote: > HI all, > > after investigating I see a number of issues preventing gtest from running > on AIX, so I decided to get the fix for the wrong assert in the hotspot out > of the way and open follow up issues for the other problems. > > So, this i

Re: If I only want jar.exe

Hello Max, Currently you have to build the full exploded image, or at least java.base and jdk.jartool. There was a bug filed on this a while ago, but I can't find it. I agree that it's wrong. /Erik On 2016-12-19 10:34, Wang Weijun wrote: Which target should I build with? Seems jdk.jartool i

Re: correct version of the autoconf tools?

Hello, 2.69 is the version we require. However, the latest Ubuntu release has a different 2.69 bundled, where they cherry picked some changes from upstream, without changing the version string. The runstatedir stuff is part of that. Personally I sometimes include the generated file in my web

Re: correct version of the autoconf tools?

On Mon, Dec 19, 2016 at 3:24 PM, Erik Joelsson wrote: > Hello, > > 2.69 is the version we require. However, the latest Ubuntu release has a > different 2.69 bundled, where they cherry picked some changes from > upstream, without changing the version string. The runstatedir stuff is > part of that

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

On 18/12/2016 10:13 PM, Thomas Stüfe wrote: HI all, after investigating I see a number of issues preventing gtest from running on AIX, so I decided to get the fix for the wrong assert in the hotspot out of the way and open follow up issues for the other problems. So, this is just the fixed as

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Thomas, Attachments gets stripped from most of the mailing lists. But cr.openjdk is back now. David On 19/12/2016 11:28 PM, Thomas Stüfe wrote: On Sun, Dec 18, 2016 at 1:50 PM, Thomas Stüfe wrote: Hi all, please take a look at this small fix. In short, on AIX when linking the gtest versio

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Hi Thomas, On 18/12/2016 10:50 PM, Thomas Stüfe wrote: Hi all, please take a look at this small fix. In short, on AIX when linking the gtest version of libjvm.so, the TOC overflows. So the gtest libjvm.so must be linked with -bbigtoc, in contrast to the regular libjvm.so, which has no problems

Re: RFR(xs): 8171408: [aix] TOC overflow when linking the gtest libjvm.so

Thanks David! On Dec 19, 2016 21:47, "David Holmes" wrote: > Hi Thomas, > > On 18/12/2016 10:50 PM, Thomas Stüfe wrote: > >> Hi all, >> >> please take a look at this small fix. In short, on AIX when linking the >> gtest version of libjvm.so, the TOC overflows. >> >> So the gtest libjvm.so must b

RFR(XS): 8168137 - import-hotspot build target not removed from hotspot-ide-project

Hi, Please review this small change to not use the import-hotspot make target, also updated where to find jvm.dll once the build has completed. Tested using make hotspot-ide-project and then using VS to build/rebuild/debug using the generated project files. Webrev: http://cr.openjdk.java.

Re: RFR(XS): 8168137 - import-hotspot build target not removed from hotspot-ide-project

Hi Christian, On 20/12/2016 8:43 AM, Christian Tornqvist wrote: Hi, Please review this small change to not use the import-hotspot make target, also updated where to find jvm.dll once the build has completed. Tested using make hotspot-ide-project and then using VS to build/rebuild/debug using

Re: RFR(xs): 8171433: [aix] switch on gtest AIX build

Looks fine. I can sponsor this for you once the other changes have been pushed. Or I can push them altogether for you. David On 19/12/2016 11:26 PM, Thomas Stüfe wrote: Hi all, Please review this tiny change. Note that this was already part of the review of 8171225. I decided to split that p

Re: RFR(xs): 8171225: [aix] Build gtests on AIX 7.1 with xlC 12

Thanks David! On Dec 19, 2016 21:43, "David Holmes" wrote: > > > On 18/12/2016 10:13 PM, Thomas Stüfe wrote: > >> HI all, >> >> after investigating I see a number of issues preventing gtest from >> running on AIX, so I decided to get the fix for the wrong assert in the >> hotspot out of the way

Re: RFR(xs): 8171433: [aix] switch on gtest AIX build

Great, David, please push them all for me. The TOC overflow one (8171408) is the only non trivial IMHO and I'd like Volker to take a second look. Thanks, Thomas On Dec 20, 2016 04:18, "David Holmes" wrote: > Looks fine. I can sponsor this for you once the other changes have been > pushed. Or