Re: RFR: 8160881: Remove jvisualvm from JDK9

2017-01-19 Thread Magnus Ihse Bursie
On 2017-01-18 18:57, Henry Jen wrote: Hi, Please review the webrev to remove jvisualvm from JDK9. http://cr.openjdk.java.net/~henryjen/jdk9/8160881/jdk/webrev/ Looks good to me. /Magnus

Review request: JDK-8173085 Warning module name in --add-exports not found: jdk.jdeps when compiling for BUILD_JIGSAW_TOOLS

2017-01-19 Thread Mandy Chung
JDK-8172973 removes the warning emitted at run-time but --add-exports specified at compile-time is not removed. Hence a javac warning is emitted. diff --git a/make/CompileModuleTools.gmk b/make/CompileModuleTools.gmk --- a/make/CompileModuleTools.gmk +++ b/make/CompileModuleTools.gmk @@ -37,6 +3

Re: Review request: JDK-8173085 Warning module name in --add-exports not found: jdk.jdeps when compiling for BUILD_JIGSAW_TOOLS

2017-01-19 Thread Jonathan Gibbons
Looks OK to me. -- Jon On 01/19/2017 03:37 PM, Mandy Chung wrote: JDK-8172973 removes the warning emitted at run-time but --add-exports specified at compile-time is not removed. Hence a javac warning is emitted. diff --git a/make/CompileModuleTools.gmk b/make/CompileModuleTools.gmk --- a/mak

jdk-9+153 tarballs have packaging error

2017-01-19 Thread Martin Buchholz
I noticed I couldn't use an exploded jdk tarball because some files were not world readable. tar tvzf jdk-9-ea+153_linux-x64_bin.tar.gz ... -rw-r--r-- java_re/java_re 73955 2017-01-18 17:59 jdk-9/include/jni.h -rw-r--r-- java_re/java_re824 2017-01-18 17:59 jdk-9/include/linux/jni_md.h -rw-r--r

Re: jdk-9+153 tarballs have packaging error

2017-01-19 Thread Mandy Chung
Thanks for the report. We also uncover this regression: https://bugs.openjdk.java.net/browse/JDK-8173096 Mandy > On Jan 19, 2017, at 8:09 PM, Martin Buchholz wrote: > > I noticed I couldn't use an exploded jdk tarball because some files were > not world readable. > tar tvzf jdk-9-ea+153_lin

Re: Review request: JDK-8173085 Warning module name in --add-exports not found: jdk.jdeps when compiling for BUILD_JIGSAW_TOOLS

2017-01-19 Thread Erik Joelsson
Looks good to me. /Erik On 2017-01-20 00:37, Mandy Chung wrote: JDK-8172973 removes the warning emitted at run-time but --add-exports specified at compile-time is not removed. Hence a javac warning is emitted. diff --git a/make/CompileModuleTools.gmk b/make/CompileModuleTools.gmk --- a/make