Re: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

Thanks David! -Joe On 1/31/2017 8:50 PM, David Holmes wrote: jdk10/jdk10 is finally "JDK 10" :) David On 27/01/2017 10:26 AM, David Holmes wrote: Hi Erik, As now discovered the version can't be updated until quite a few changes are made in hotspot due to deprecated/obsolete option

Re: RFR: 8173607: JMX RMI connector should be in its own module

> On Jan 31, 2017, at 10:26 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for: > > 8173607: JMX RMI connector should be in its own module > https://bugs.openjdk.java.net/browse/JDK-8173607 > > webrev: >

Re: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

jdk10/jdk10 is finally "JDK 10" :) David On 27/01/2017 10:26 AM, David Holmes wrote: Hi Erik, As now discovered the version can't be updated until quite a few changes are made in hotspot due to deprecated/obsolete option handling. https://bugs.openjdk.java.net/browse/JDK-8173421 I would

Re: JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

On 1/02/2017 11:44 AM, Joseph D. Darcy wrote: Hi David, Just pushed the change; if you refresh your forest it will be there. Thanks Joe. Submitting my changes to JPRT now. Hopefully no surprises. David Thanks, -Joe On 1/31/2017 5:41 PM, David Holmes wrote: Hi Joe, On 1/02/2017 11:32

Re: JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

Hi David, Just pushed the change; if you refresh your forest it will be there. Thanks, -Joe On 1/31/2017 5:41 PM, David Holmes wrote: Hi Joe, On 1/02/2017 11:32 AM, joe darcy wrote: Hi David, I can apply my fix for JDK-8173383: Update JDK build to use -source and -target 10. That's

Re: JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

Hi Joe, On 1/02/2017 11:32 AM, joe darcy wrote: Hi David, I can apply my fix for JDK-8173383: Update JDK build to use -source and -target 10. That's exactly what I just discovered will fix things. :) It is reviewed isn't it? So I can just apply the change to my forest and commit it under

Re: JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

Hi David, I can apply my fix for JDK-8173383: Update JDK build to use -source and -target 10. For me, I see the normal builds as succeeding, but some fast debug failures, perhaps for unrelated reasons. At least on a local build, with 8028546 a local build worked and all langtools tests

JDK 10 build broken by "8028546: Add -source 10 and -target 10 to javac"

Joe, I just sync'd my jdk10 forest before pushing the version 10 update and related hotspot changes and now all builds are failing due to: warning: [options] bootstrap class path not set in conjunction with -source 1.9 error: warnings found and -Werror specified Which would appear to be

Re: New lead for the JDK 6 Project: Andrew Brygin

2017/1/6 7:30:28 -0800, tim.b...@oracle.com: > Andrew Haley has resigned as lead for the JDK 6 Project [1]. > > Under the bylaws for Project Roles [2], a new Project Lead may be > nominated by the Group Leads of the Project's sponsoring groups. > > The Build Infrastructure Group is sponsor of

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

On 1/02/2017 12:57 AM, Mandy Chung wrote: On Jan 30, 2017, at 11:00 PM, David Holmes wrote: Hi Mandy, On 31/01/2017 9:48 AM, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html This all seems okay. Thanks

RFR: 8173607: JMX RMI connector should be in its own module

Hi, Please find below a patch for: 8173607: JMX RMI connector should be in its own module https://bugs.openjdk.java.net/browse/JDK-8173607 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8173607/webrev.05 This patch makes it possible to remove the requires transitive java.rmi from the

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

On 2017-01-31 17:04, Mandy Chung wrote: On Jan 31, 2017, at 12:20 AM, Erik Joelsson wrote: Are all the libraries added to LIBS still needed for this breakout lib? And are all of them still needed for libmanagement.so from which this was split out? Good catch. I

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 31, 2017, at 7:35 AM, Daniel Fuchs wrote: > > Hi Mandy, > > Looks good to me in general. > > Suggestion: FileLoginModule.java > > 112 private static final String PASSWORD_FILE_NAME = "jmxremote.password"; > > Maybe the constant could be public, then it

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 31, 2017, at 12:20 AM, Erik Joelsson wrote: > > Hello Mandy, > > In Lib-jdk.management.agent.gmk: > > OPENJDK_TARGET_OS and OPENJDK_TARGET_OS_TYPE are both "windows" on Windows > platforms, so no need to treat Windows differently when defining the src dirs.

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Hi Mandy, Looks good to me in general. Suggestion: FileLoginModule.java 112 private static final String PASSWORD_FILE_NAME = "jmxremote.password"; Maybe the constant could be public, then it could be referred to by ConnectorBootstrap? I see that com.sun.jmx.remote.internal is already

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

> On Jan 30, 2017, at 11:00 PM, David Holmes wrote: > > Hi Mandy, > > On 31/01/2017 9:48 AM, Mandy Chung wrote: >> Webrev at: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html > > This all seems okay. > Thanks for the review. > But we

Re: Review Request: JDK-8173608: Separate JDK management agent from java.management module

Hello Mandy, In Lib-jdk.management.agent.gmk: OPENJDK_TARGET_OS and OPENJDK_TARGET_OS_TYPE are both "windows" on Windows platforms, so no need to treat Windows differently when defining the src dirs. The -DPSAPI_VERSION=1 seems to be copied from Lib-jdk.management.gmk and/or