Re: [10] Request for review and approval: JDK-8177770: Need more precise control on build system logging

Looks good Alexey, thanks for doing this! /Erik On 2017-03-29 18:21, alexey semenyuk wrote: Please review and approve enhancement for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-810 Webrev: http://cr.openjdk.java.net/~asemenyuk/810/webrev.00/ Thanks, Alexey

Re: Linking against a new shared library file

Thanks. I found that after I sent my msg, but the write date on the file made me think it was a generated file. -wade p.s - yes, I'm using JDK 9. On Wed, Mar 29, 2017 at 6:00 PM, David Holmes wrote: > On 30/03/2017 7:53 AM, Wade Hennessey wrote: > >> I'm trying to figure out how to link libjvm

Re: Bug in File.getLastModified()

Hi Ricardo, This isn't a build issue. Redirecting to core-libs-dev. Please don't reply to build-dev. Thanks, David On 30/03/2017 12:40 AM, Ricardo Almeida wrote: Hi, I could not raise a bug in https://bugs.openjdk.java.net/ so I hope it is ok to say it here, hoping someone can take a look a

Re: [10] Request for review and approval: JDK-8177770: Need more precise control on build system logging

Hi Alexey, Can't really review the details of this but wanted to ensure that this gets tested on all platforms before being pushed. Internally use JPRT and "-testset hotspot", but you should also reach out to the AIX-port folk to ensure it works as expected there too. Thanks, David On 30/03

Re: Linking against a new shared library file

On 30/03/2017 7:53 AM, Wade Hennessey wrote: I'm trying to figure out how to link libjvm against a shared library that isn't linked against by default. Where in the build system would I specify this new library path? -wade Assuming JDK 9. /common/autoconf/flags.m4 See JVM_LIBS setting eg:

Linking against a new shared library file

I'm trying to figure out how to link libjvm against a shared library that isn't linked against by default. Where in the build system would I specify this new library path? -wade

[10] Request for review and approval: JDK-8177770: Need more precise control on build system logging

Please review and approve enhancement for JDK10. Bug: https://bugs.openjdk.java.net/browse/JDK-810 Webrev: http://cr.openjdk.java.net/~asemenyuk/810/webrev.00/ Thanks, Alexey

Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

I fixed that but the webrev.02 missed to include this line fix (sorry about that): -BUILD_TOOLS_JDK := $(call SetupJavaCompilationCompileTarget, \ +BUILD_JIGSAW_TOOLS := $(call SetupJavaCompilationCompileTarget, \ BUILD_JIGSAW_TOOLS, $(TOOLS_CLASSES_DIR)) I’ll include ifndef as you suggeste

Re: Bug in File.getLastModified()

On 29.03.2017 16:40, Ricardo Almeida wrote: Hi, I could not raise a bug in https://bugs.openjdk.java.net/ Hi, please use bugs.java.com to file issues if you're not an OpenJDK developer. cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089

Bug in File.getLastModified()

Hi, I could not raise a bug in https://bugs.openjdk.java.net/ so I hope it is ok to say it here, hoping someone can take a look at it... File.getLastModified() always returns with second precision, losing the miliseconds (i.e. a number ending in 000). I tried using Files.getLastModifiedTime and i

Re: [OpenJDK 2D-Dev] RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

+1 -phil. On 3/29/17, 6:16 AM, Magnus Ihse Bursie wrote: On 2017-03-29 15:00, Erik Joelsson wrote: Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it r

Re: RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

On 2017-03-29 15:00, Erik Joelsson wrote: Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it require msvcr100.dll, while the rest of OpenJDK is built wit

RFR: JDK-8177135: OpenJDK 9 freetype needs msvcr100.dll

Hello, The build of freetype used internally at Oracle when building OpenJDK builds (for the reference implementation) is very old. It was also built using Visual Studio 2010, which makes it require msvcr100.dll, while the rest of OpenJDK is built with Visual Studio 2013 and subsequently requ

Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

On 2017-03-29 13:45, Magnus Ihse Bursie wrote: On 2017-03-25 22:33, Mandy Chung wrote: I edited the module descriptions per your feedback. I also revised GenGraphs tool to take a properties file to customize the dot graphs for javadoc use. Updated webrev: http://cr.openjdk.java.net/~mchung/jdk

Re: Review Request: JDK-8173303: Add module-subgraph images to main platform documentation

On 2017-03-25 22:33, Mandy Chung wrote: I edited the module descriptions per your feedback. I also revised GenGraphs tool to take a properties file to customize the dot graphs for javadoc use. Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173303/webrev.02/ I just discovere

Re: RFR: JDK-8177634 Fix for 8175307 may cause linker errors on OS X 10.9

Looks good. /Erik On 2017-03-29 10:33, Magnus Ihse Bursie wrote: Since JDK-8175307 was fixed we started seeing failures like this on OS X 10.9 systems: dyld: Library not loaded: @rpath/libjvm.dylib Referenced from: /opt/jprt/T/P1/144150.mgerdin/bundles/testBundle/hotspot/gtest/server/gtest

Re: RFR of JDK-8177553: Address removal lint warnings in the JDK build

Looks good. /Erik On 2017-03-29 03:59, joe darcy wrote: Hello, As a continuation of the warnings cleanup of JEP 212 (JDK-8042878), the new-in-9 lint category of "removal" warnings for use of deprecated for removal items should be enable as a fatal warning in the build. I have out for revi

Re: RFR: JDK-8177634 Fix for 8175307 may cause linker errors on OS X 10.9

Hi Magnus, This seems reasonable. Thanks, David H. On 29/03/2017 6:33 PM, Magnus Ihse Bursie wrote: Since JDK-8175307 was fixed we started seeing failures like this on OS X 10.9 systems: dyld: Library not loaded: @rpath/libjvm.dylib Referenced from: /opt/jprt/T/P1/144150.mgerdin/bundles/tes

RFR: JDK-8177634 Fix for 8175307 may cause linker errors on OS X 10.9

Since JDK-8175307 was fixed we started seeing failures like this on OS X 10.9 systems: dyld: Library not loaded: @rpath/libjvm.dylib Referenced from: /opt/jprt/T/P1/144150.mgerdin/bundles/testBundle/hotspot/gtest/server/gtestLauncher Reason: image not found make[2]: *** [hotspot_gtestserv