Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Alan Bateman
On 03/04/2017 22:38, Simon Nash wrote: : My comment was regarding the change of value for OS_NAME. Given that there is no compatibility issue here, does it make sense for the new value to be something that is no longer current in Apple terminology? Just on compatibility then just to say tha

Re: RFR: JDK-8172312 Update docs target and image for new combined docs

2017-04-03 Thread Jonathan Gibbons
On 04/03/2017 04:42 PM, mark.reinh...@oracle.com wrote: 2017/4/3 11:01:13 -0700, jonathan.gibb...@oracle.com: I agree there will need to be some cosmetic cleanup with respect to headings. Given the optionality of whether or not the build is set to import JavaFX, the headings and content of the

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Mandy Chung
> On Apr 3, 2017, at 4:10 PM, mark.reinh...@oracle.com wrote: > > 2017/4/3 14:50:52 -0700, mandy.ch...@oracle.com: >>> On Apr 3, 2017, at 2:39 PM, mark.reinh...@oracle.com wrote: >>> 2017/4/3 13:35:30 -0700, si...@cjnash.com: ... I am not sure why we would change to osx for Mac wh

Re: RFR: JDK-8172312 Update docs target and image for new combined docs

2017-04-03 Thread mark . reinhold
2017/4/3 11:01:13 -0700, jonathan.gibb...@oracle.com: > I agree there will need to be some cosmetic cleanup with respect to > headings. Given the optionality of whether or not the build is set to > import JavaFX, the headings and content of the new overview page will > need to be somewhat synthe

Re: RFR: JDK-8172312 Update docs target and image for new combined docs

2017-04-03 Thread mark . reinhold
2017/4/3 3:24:52 -0700, magnus.ihse.bur...@oracle.com: > I think the distinction you ask for is already there. The two separate > make targets "docs-javadoc" and "docs-reference" builds two distinct > images "docs" and "javase-docs", respectively. The first of these builds > the complete Java SE

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread mark . reinhold
2017/4/3 14:50:52 -0700, mandy.ch...@oracle.com: >> On Apr 3, 2017, at 2:39 PM, mark.reinh...@oracle.com wrote: >> 2017/4/3 13:35:30 -0700, si...@cjnash.com: >>> ... >>> >>> I am not sure why we would change to osx for Mac when the Mac developers >>> have recently dropped the Mac OS X terminology

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Mandy Chung
> On Apr 3, 2017, at 2:39 PM, mark.reinh...@oracle.com wrote: > > 2017/4/3 13:35:30 -0700, si...@cjnash.com: >> On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: >>> 2017/4/3 11:41:03 -0700, mandy.ch...@oracle.com: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webre

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread mark . reinhold
2017/4/3 13:35:30 -0700, si...@cjnash.com: > On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: >> 2017/4/3 11:41:03 -0700, mandy.ch...@oracle.com: >>> Webrev: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ >>> >>> ... >>> >>> This shows the old and new value of OS_NAME

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Simon Nash
On 03/04/2017 22:07, Mandy Chung wrote: On Apr 3, 2017, at 1:35 PM, Simon Nash wrote: On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: I am not sure why we would change to osx for Mac when the Mac developers have recently dropped the Mac OS X terminology and changed it to macOS. Just to

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Mandy Chung
> On Apr 3, 2017, at 1:35 PM, Simon Nash wrote: > > On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: > > I am not sure why we would change to osx for Mac when the Mac developers > have recently dropped the Mac OS X terminology and changed it to macOS. Just to be clear, there is no plan to

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Simon Nash
On 03/04/2017 21:15, mark.reinh...@oracle.com wrote: 2017/4/3 11:41:03 -0700, mandy.ch...@oracle.com: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ ... This shows the old and new value of OS_NAME/OS_ARCH properties in the `release` file: JDK 8

Re: Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread mark . reinhold
2017/4/3 11:41:03 -0700, mandy.ch...@oracle.com: > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ > > ... > > This shows the old and new value of OS_NAME/OS_ARCH properties > in the `release` file: > > JDK 8 JDK 9 > -

Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

2017-04-03 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/ This revisits the OS name and arch in packaging JDK modules to extend the module descriptor with ModuleTarget class file attribute. We considered matching with the system properties. Linux x64 JDK can run on a system who

Re: RFR: JDK-8172312 Update docs target and image for new combined docs

2017-04-03 Thread Jonathan Gibbons
Mark, I agree there will need to be some cosmetic cleanup with respect to headings. Given the optionality of whether or not the build is set to import JavaFX, the headings and content of the new overview page will need to be somewhat synthesized. Separately, it has always been a requirement

Re: RFR: JDK-8177955 Add testing documentation

2017-04-03 Thread Erik Joelsson
Looks good. A few grammar/spelling corrections: 96: "All tests" 127: "command line" 139: is this still true? I thought you added the default concurrency behavior from the old hotspot test/Makefile. /Erik On 2017-04-03 12:00, Magnus Ihse Bursie wrote: The new run-test framework got a seriou

Re: RFR: JDK-8172312 Update docs target and image for new combined docs

2017-04-03 Thread Magnus Ihse Bursie
Mark, I think the distinction you ask for is already there. The two separate make targets "docs-javadoc" and "docs-reference" builds two distinct images "docs" and "javase-docs", respectively. The first of these builds the complete Java SE + JDK documentation, the second build just the Java S

RFR: JDK-8177955 Add testing documentation

2017-04-03 Thread Magnus Ihse Bursie
The new run-test framework got a serious documentation effort alongside its creation. Unfortunately, there were at the time no good place to put that documentation. Now that we have common/doc and a framework for handling build documentation, it would be good to put the run-test documentation

Re: JDK10 build on Win64 fails on `make images`

2017-04-03 Thread Erik Joelsson
(moving to build-dev) Hello Oleksandr Nikitin, It looks like you forgot to clone all the repositories. Please run "sh get_source.sh" in the root of the repository you cloned. You will also need to rerun "sh ./common/bin/hgforest.sh up -r JDK-8174901-epsilon-branch" after the full clone. I w