RFR: JDK-8179079: Incremental HotSpot builds broken on Windows

2017-04-21 Thread Erik Joelsson
We have hit another issue related to the new Cygwin behavior regarding \r line endings. The incremental native build on Windows breaks because we get ^M characters in the *.d files. Output from "make --debug=b" typically looks like this: Prerequisite

Re: RFR: JDK-8179078: Jib run-test-prebuilt profile missing dependency on bootjdk

2017-04-21 Thread Christian Tornqvist
Hi Erik, This looks good, I’ve verified that the fix works. Thanks for fixing this! Thanks, Christian > On Apr 21, 2017, at 10:43 AM, Erik Joelsson wrote: > > (resending to include Christian) > > > On 2017-04-21 16:37, Erik Joelsson wrote: >> Hello, >> >> When

Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-21 Thread Mandy Chung
> On Apr 21, 2017, at 12:33 AM, Alan Bateman wrote: > > On 20/04/2017 19:37, Mandy Chung wrote: > >> A few modules are missing in the unified docs such as jdk.jcmd, >> jdk.jdwp.agent, jdk.jstatd, etc. Some tool modules are providers >> and they were in the initial

Re: RFR: JDK-8179022 Add serialization spec as markdown

2017-04-21 Thread Roger Riggs
Hi Magnus, Looks good, I checked the previous and new html content and found no significant differences. There are some content improvements that should be made but that's a separate task. Thanks, Roger On 4/20/2017 2:51 PM, Roger Riggs wrote: Hi Magnus, How did you verify that the

Re: RFR: JDK-8179078: Jib run-test-prebuilt profile missing dependency on bootjdk

2017-04-21 Thread Erik Joelsson
(resending to include Christian) On 2017-04-21 16:37, Erik Joelsson wrote: Hello, When using the run-test-prebuilt Jib profile to run tests, we need to set JT_JAVA to point to the boot jdk for jtreg. The configuration to set JT_JAVA is there, but I forgot to also add boot_jdk as a

RFR: JDK-8179078: Jib run-test-prebuilt profile missing dependency on bootjdk

2017-04-21 Thread Erik Joelsson
Hello, When using the run-test-prebuilt Jib profile to run tests, we need to set JT_JAVA to point to the boot jdk for jtreg. The configuration to set JT_JAVA is there, but I forgot to also add boot_jdk as a dependency on that profile. Bug: https://bugs.openjdk.java.net/browse/JDK-8179078

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-21 Thread Magnus Ihse Bursie
Jon, Can you please open a separate bug for this? Just adding --doclint-format html5 generates a lot of failures, as Martin points out, so it's not feasible to do as part of this fix. /Magnus On 2017-04-21 03:08, Martin Buchholz wrote: There would be a global cleanup involved for

Re: RFR: JDK-8175036 All API docs should be built for HTML 5

2017-04-21 Thread Erik Joelsson
Looks good to me. /Erik On 2017-04-21 00:20, Magnus Ihse Bursie wrote: We should switch all uses of the javadoc tool to generate documentation in HTML 5, using the -html5 option. Bug: https://bugs.openjdk.java.net/browse/JDK-8175036 Patch inline: diff --git a/make/Javadoc.gmk

Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-21 Thread Alan Bateman
On 20/04/2017 19:37, Mandy Chung wrote: A few modules are missing in the unified docs such as jdk.jcmd, jdk.jdwp.agent, jdk.jstatd, etc. Some tool modules are providers and they were in the initial set. The modules that are neither a provider nor exporting any API package are missed in the