Bug: https://bugs.openjdk.java.net/browse/JDK-8174231
webrevs:
Build-related: http://cr.openjdk.java.net/~dholmes/8174231/webrev.top/
hotspot: http://cr.openjdk.java.net/~dholmes/8174231/webrev.hotspot/
First a big thank you to Thomas Stuefe for testing various versions of
this on AIX.
Magnus,
I've added your suggested fix to spec.gmk.in, which is the minor tweak
to add @FIXPATH@ to allow pandoc to run on windows builds.
https://bugs.openjdk.java.net/browse/JDK-8180540
http://cr.openjdk.java.net/~wetmore/8180540/webrev.00/
I put you down as Contributed-by: with myse
The way to do this is to create a file
src/java.desktop/windows/classes/module-info.java.extra
and move the opens there.
See for example
src/java.base/windows/classes/module-info.java.extra
But are you sure jdk.jconsole needs these only on Windows ?
Better make sure of it.
-phil.
On 05/17/201
Hah, that seems like a reasonable solution to me. The index page
generation shouldn't be heavy enough to be a problem here.
Looks good.
/Erik
On 2017-05-17 15:44, Magnus Ihse Bursie wrote:
On 2017-05-17 13:27, Erik Joelsson wrote:
I realize the dilemma. The clean solution is to define yet an
> On May 17, 2017, at 6:44 AM, Magnus Ihse Bursie
> wrote:
>
> On 2017-05-17 13:27, Erik Joelsson wrote:
>> I realize the dilemma. The clean solution is to define yet another top level
>> target for just this file. It's also possible that this race will never
>> cause problems, I don't know f
On 2017-05-17 13:27, Erik Joelsson wrote:
I realize the dilemma. The clean solution is to define yet another top
level target for just this file. It's also possible that this race
will never cause problems, I don't know for sure.
Here's an updated version:
http://cr.openjdk.java.net/~ihse/JDK-
I realize the dilemma. The clean solution is to define yet another top
level target for just this file. It's also possible that this race will
never cause problems, I don't know for sure.
/Erik
On 2017-05-17 12:41, Magnus Ihse Bursie wrote:
On 2017-05-17 11:23, Erik Joelsson wrote:
Looks o
Instead of adding more explicit excludes, I would recommend moving the
windows specific source files to:
jdk/src/java.desktop/windows/classes
That is the intended way of making sources platform specific.
If you still need to add the qualified export to jdk.jconsole, but just
for windows, you
Yes, actually I am bit unsure of how to proceed with that. It is meant
to open internal java.desktop classes "only" to jdk.jconsole but now
afer this fix, these classes will only be available in windows platform,
so it should be a conditional "open" and I am not sure if
module-info.java allows
Build changes looks good. However in
src/java.desktop/share/classes/module-info.java you are trying to check
in commented-out code instead of removing it.
/Magnus
On 2017-05-17 12:31, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue whereby it is seen that
WindowsLookAndFe
On 2017-05-17 11:23, Erik Joelsson wrote:
Looks ok. Note that adding the global resources copy targets to two
different top level targets may cause race conditions in rare cases
depending on OS and file system.
Do you propose that I solve it in a different way? I was thinking of
moving the
Hi All,
Please review a fix for an issue whereby it is seen that
WindowsLookAndFeel classes are built for non-windows platform,
where it is not needed.
Proposed fix is to remove building these classes for non-windows platform.
JPRT build is successful. Also, fixed the regression tests which ex
Looks good.
/Erik
On 2017-05-17 10:49, Magnus Ihse Bursie wrote:
JDK-8175036 enables HTML 5 when generating the API docs.
javac runs doclint at compile time, but remains configured for HTML 4.
We should update the compilation steps to use HTML 5 except where
exceptions are needed.
Note th
Looks ok. Note that adding the global resources copy targets to two
different top level targets may cause race conditions in rare cases
depending on OS and file system.
/Erik
On 2017-05-17 10:16, Magnus Ihse Bursie wrote:
In JDK-8180208, a new top-level index.html for the entire docs image
w
Looks good.
/Erik
On 2017-05-17 10:00, Magnus Ihse Bursie wrote:
HTML files created by markdown should adhere to html5, in line with
the general effort to make all documentation html5 compliant.
Bug: https://bugs.openjdk.java.net/browse/JDK-8180472
WebRev:
http://cr.openjdk.java.net/~ihse/J
JDK-8175036 enables HTML 5 when generating the API docs.
javac runs doclint at compile time, but remains configured for HTML 4.
We should update the compilation steps to use HTML 5 except where
exceptions are needed.
Note that two modules, java.base and java.desktop, is currently not
fully h
In JDK-8180208, a new top-level index.html for the entire docs image was
created.
This should use the common jdk-default.css file, which should move out
of the specs directory.
Here is an example how the generated page looks like:
http://cr.openjdk.java.net/~ihse/demo-docs-index-with-default-
HTML files created by markdown should adhere to html5, in line with the
general effort to make all documentation html5 compliant.
Bug: https://bugs.openjdk.java.net/browse/JDK-8180472
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8180472-pandoc-should-use-html5/webrev.01
/Magnus
18 matches
Mail list logo
