Hi Claes,
The change looks fine. Yes, encoding the 2-byete latin1 at native looks
reasonable.
One nick picking is that it might be better to initialize the constant
"LATIN1" from the String class
when intializing String_coder_ID? recently I got a "naked constants"
complain #JDK-8156530, so
Hi,
This change looks ok, I have some other links to the copyright.html to
fix in serialization
and can fix the tools/docs/docs-bundle-page at the same time.
Roger
On 6/12/17 12:19 PM, Mandy Chung wrote:
jdk/make/src/classes/build/tools/docs/docs-bundle-page.html has a reference to
Hi Eric,
On Wed, 2017-06-14 at 16:38 +0200, Erik Helin wrote:
> On 06/14/2017 02:21 PM, Severin Gehwolf wrote:
> > Hi Eric,
> >
> > On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote:
> > > For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For
> > > example, the following is
On 06/14/2017 02:21 PM, Severin Gehwolf wrote:
> Hi Eric,
>
> On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote:
>> For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For
>> example, the following is a bit surprising to me (mostly because I'm not
>> familiar with zero):
>>
Hi Dalibor!
On Wed, Jun 14, 2017 at 03:08:57PM +0200, dalibor topic wrote:
> thanks, congrats & welcome!
Thank you!
> Since your OCA submission has not been processed yet, you are not listed on
> http://www.oracle.com/technetwork/community/oca-486395.html . Patches can be
> merged once your OCA
On 14.06.2017 14:04, John Paul Adrian Glaubitz wrote:
Can't wait for my first patches getting merged into OpenJDK ;-).
Hi Adrian,
thanks, congrats & welcome!
Since your OCA submission has not been processed yet, you are not listed
on
On Wed, Jun 14, 2017 at 02:30:24PM +0200, Erik Helin wrote:
> >I'm not 100% whether I did that. I'm not very familar with mercurial
> >as I'm more used to git. If the patch format looks wrong to you, I can
> >resend a revised version of this patch.
>
> No worries, someone will have to commit your
On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote:
Hi Erik!
On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
thanks for contributing and signing the OCA!
Thanks for reviewing my patches ;-).
I think the first three patches (hotspot-add-missing-log-header.diff,
Hi Eric,
On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote:
> For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For
> example, the following is a bit surprising to me (mostly because I'm not
> familiar with zero):
>
> ---
Hi Erik!
On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote:
> thanks for contributing and signing the OCA!
Thanks for reviewing my patches ;-).
> I think the first three patches (hotspot-add-missing-log-header.diff,
> hotspot-fix-checkbytebuffer.diff,
Hey Adrian,
thanks for contributing and signing the OCA!
I think the first three patches (hotspot-add-missing-log-header.diff,
hotspot-fix-checkbytebuffer.diff, rename-sparc-linux-atomic-header.diff)
all look good, thanks for fixing broken code. Consider them Reviewed by
me. Every patch
Build changes look good to me.
/Erik
On 2017-06-13 22:27, Claes Redestad wrote:
On 2017-06-13 21:09, Martin Buchholz wrote:
Looks good to me, although still hoping for more review from others.
I expect Sherman to weigh in. :-)
+if (bytes != 0) {
Style: use NULL.
Done.
+static
Build change looks good.
/Erik
On 2017-06-13 18:57, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
Fix: Relocated currency.data from java.base module
Hello Mandy,
Looks good to me.
/Erik
On 2017-06-13 07:35, Mandy Chung wrote:
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182032/webrev.00/
java.compiler is a standalone technology that allows to be running on older
JDK, in particular for IDE to support new language
14 matches
Mail list logo
