Re: RFR: JDK-8179537 Update testing.md for more clarity regarding JTReg configuration

2017-06-16 Thread Magnus Ihse Bursie
Jon pointed out in private conversation that the test suite should be written "JTReg", not "JTreg". I've updated both the new text and all old instances. New webrev: http://cr.openjdk.java.net/~ihse/JDK-8179537-update-testing-readme-about-jtreg-configuration/webrev.02 /Magnus On 2017-06-16

Re: [PATCH] linux-sparc build fixes

2017-06-16 Thread Magnus Ihse Bursie
On 2017-06-14 16:38, Erik Helin wrote: On 06/14/2017 02:21 PM, Severin Gehwolf wrote: Hi Eric, On Wed, 2017-06-14 at 13:50 +0200, Erik Helin wrote: For the fourth patch, fix-zero-build-on-sparc.diff, I'm not so sure. For example, the following is a bit surprising to me (mostly because I'm

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

2017-06-16 Thread Xueming Shen
+1 On Jun 15, 2017, at 3:35 PM, Claes Redestad wrote: > On 2017-06-15 18:50, Alan Bateman wrote: > > >> On 15/06/2017 17:26, Chris Hegarty wrote: >> : >> Claes, >> >> This is the first test in the core area that will now use a test >> specific native library,

Re: RFR: JDK-8179556 Add specs copyright file

2017-06-16 Thread Erik Joelsson
Looks good to me. /Erik On 2017-06-16 11:30, Magnus Ihse Bursie wrote: Apparently these files should reside in the closed repo instead... Now there's yet another version of this patch, this time with trivial changes to open only: