Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Martin Buchholz
Thanks! On debian-based systems, it's useful to get dependencies using sudo apt-get -y build-dep openjdk-8-jdk even when building jdk9 or jdk10

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread dalibor topic
On 21.06.2017 02:46, Magnus Ihse Bursie wrote: Also known as: "!!! THIS IS A MAJOR RE-WRITE of this document. !" :-) It is also very good. Thank you. ;) cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Magnus Ihse Bursie
On 2017-06-21 09:02, Thomas Stüfe wrote: Hi Magnus, excellent work! Thank you! :-) Some minor remarks: You also mentioned Cygwin hg in the "Special considerations" section. However, because updating Cygwin is a bit of a pain (you need to close all consoles to do this) it may make sense

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Magnus Ihse Bursie
On 2017-06-21 10:07, Erik Joelsson wrote: Wow, this is massive, and very good! Thanks you. It's been in the making for a long time, and I almost didn't get to complete it in time for JDK 9. IMO, we should just push this as is and handle any updates/corrections as followups. Otherwise we

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Erik Joelsson
Wow, this is massive, and very good! IMO, we should just push this as is and handle any updates/corrections as followups. Otherwise we risk not getting this in at all. Looks good enough to me. /Erik On 2017-06-21 02:46, Magnus Ihse Bursie wrote: Also known as: "!!! THIS IS A

Re: RFR: JDK-8179892 Update build documentation for JDK 9

2017-06-21 Thread Thomas Stüfe
Hi Magnus, excellent work! Some minor remarks: You also mentioned Cygwin hg in the "Special considerations" section. However, because updating Cygwin is a bit of a pain (you need to close all consoles to do this) it may make sense to move the "Install Cygwin and all required packages" up to the