Thanks Roger,
Made the suggested changes related to hardcoded copyright year. Please
check the updated webrev
http://cr.openjdk.java.net/~nishjain/8177472/webrev.06/
Regards,
Nishit Jain
On 25-07-2017 22:55, Roger Riggs wrote:
Hi,
I was focused mostly on *not *hardcoding the copyright text i
Hello Nishit:
A gentle reminder! Requesting for a build review
Regards,
Nishit Jain
The build changes look fine.
Tim
On 20-07-2017 23:36, Naoto Sato wrote:
Looks good to me.
Naoto
On 7/19/17 10:33 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8177472
Bug: https://bugs.ope
Hi,
I was focused mostly on *not *hardcoding the copyright text in yet
another place
and if possible avoiding a manual update of the year.
And yet since the source is being generated and is transient (not
retained after the build), the current year
is correct. (Same as cldr)
Roger
On 7/25
Hi Roger,
CLDR converter generate the copyright year by the current date in which
it is getting executed. I think the copyright year in
LocaleEquivalentMaps.java should be the year in which the lsr data is
last updated in jdk i.e. the year in which LocaleEquivalentMaps.java is
last modified.
Hi Nishit,
Can the hardcoded copyright be made more automatic?
I see the make/src/classes/build/tools/cldrconverter has functions to
create/convert copyrights.
Can that be leveraged to generate the needed copyright and reduce some
potential maintenance
of the copyright date and or contents?
A gentle reminder! Requesting for a build review
Regards,
Nishit Jain
On 20-07-2017 23:36, Naoto Sato wrote:
Looks good to me.
Naoto
On 7/19/17 10:33 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8177472
Bug: https://bugs.openjdk.java.net/browse/JDK-8177472
Webrev: http://cr.open
