On 2017-10-12 16:52, Erik Joelsson wrote:
Hello,
http://cr.openjdk.java.net/~erikj/8189095/webrev.03/
Renamed TestCommon.gmk to UtilsForTests.gmk.
Renamed the macros to EncodeSpace and DecodeSpace.
Fixed a compile problem on Solaris. ($(@D) and $(dir $@) don't behave
exactly alike. I believe
On 2017-10-12 16:52, Erik Joelsson wrote:
Hello,
http://cr.openjdk.java.net/~erikj/8189095/webrev.03/
Renamed TestCommon.gmk to UtilsForTests.gmk.
Renamed the macros to EncodeSpace and DecodeSpace.
Fixed a compile problem on Solaris. ($(@D) and $(dir $@) don't behave
exactly alike. I belie
Erik commented off-line that this code was intended to include closed
source code. It was indeed correct prior to the consolidation, but has
not been working since. The code is a performance optimization, and not
about correctness, that's why it has not been detected.
I'll come back with an up
Hello,
http://cr.openjdk.java.net/~erikj/8189095/webrev.03/
Renamed TestCommon.gmk to UtilsForTests.gmk.
Renamed the macros to EncodeSpace and DecodeSpace.
Fixed a compile problem on Solaris. ($(@D) and $(dir $@) don't behave
exactly alike. I believe the former does not leave a trailing space
When creating the consolidated forest, old paths were rewritten
automatically using pattern matching. Unfortunately, this resulted in
incorrect paths in some places.
Specifically, we do not need to look for source code in
$(TOPDIR)/src/*/$(MODULE).
(Actually, some code history digging later
On 2017-10-12 15:40, Erik Joelsson wrote:
Unfortunately, it didn't stay as easy as that. After hitting snag
after snag, I finally decided to implement some kind of general
support for file names with spaces in them, with support in CacheFind
and SetupCopyFiles, as well as the various install-fi
Unfortunately, it didn't stay as easy as that. After hitting snag after
snag, I finally decided to implement some kind of general support for
file names with spaces in them, with support in CacheFind and
SetupCopyFiles, as well as the various install-file variants. This got a
little bit more me
Hi Magnus,
On Thu, Oct 12, 2017 at 1:44 PM, Magnus Ihse Bursie <
magnus.ihse.bur...@oracle.com> wrote:
> On 2017-10-11 12:13, Thomas Stüfe wrote:
>
> Hi all,
>
> It seems to me make/nb_native project is not yet fully adapted after
> convesion to the new repo structure?
>
> When I open the project
On 2017-10-11 12:13, Thomas Stüfe wrote:
Hi all,
It seems to me make/nb_native project is not yet fully adapted after
convesion to the new repo structure?
When I open the project, I see all native sources greyed out (in addition
to dead links to the old sources which can just be deleted).
Is a
On 2017-10-12 13:37, Alan Bateman wrote:
On 12/10/2017 12:15, Magnus Ihse Bursie wrote:
We should remove make/corba/Makefile. This should have been done long
time ago by JDK-8076060.
"Patch":
$ hg st
R make/corba/Makefile
Bug: https://bugs.openjdk.java.net/browse/JDK-8189222
Looks okay t
On 12/10/2017 12:15, Magnus Ihse Bursie wrote:
We should remove make/corba/Makefile. This should have been done long
time ago by JDK-8076060.
"Patch":
$ hg st
R make/corba/Makefile
Bug: https://bugs.openjdk.java.net/browse/JDK-8189222
Looks okay to me.
One thing to keep in mind is that t
Looks good.
/Erik
On 2017-10-12 13:15, Magnus Ihse Bursie wrote:
We should remove make/corba/Makefile. This should have been done long
time ago by JDK-8076060.
"Patch":
$ hg st
R make/corba/Makefile
Bug: https://bugs.openjdk.java.net/browse/JDK-8189222
/Magnus
We should remove make/corba/Makefile. This should have been done long
time ago by JDK-8076060.
"Patch":
$ hg st
R make/corba/Makefile
Bug: https://bugs.openjdk.java.net/browse/JDK-8189222
/Magnus
13 matches
Mail list logo
