Re: RFR: JDK-8192816 Let run-test save exit code

2017-11-30 Thread Martin Buchholz
Yeah, tr is a stupid little utility that it would be nice to get away from. It's possible that env LC_ALL=C tr will fix your ASCII character set problem. On Thu, Nov 30, 2017 at 1:45 PM, Tim Bell wrote: > Magnus: > > Looks good. > > On well-behaving unix systems, tr -c

Re: RFR: JDK-8139653: Freetype bundled on macosx, but not correctly linked

2017-11-30 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 29 nov. 2017 kl. 23:48 skrev Erik Joelsson : > > When building macosx openjdk and enabling bundling of freetype (which is > usually not the default), the makefiles will copy the library in, but > libfontmanager will not be able to link to

Re: RFR: JDK-8190464: OpenJDK on macosx needs to bundle freetype

2017-11-30 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 30 nov. 2017 kl. 22:58 skrev Erik Joelsson : > > Since X11 and freetype aren't available on Macosx by default, and we (Oracle) > are now shipping OpenJDK builds for Macosx, we need to start bundling > freetype on Macosx, just like we do

RFR: JDK-8190464: OpenJDK on macosx needs to bundle freetype

2017-11-30 Thread Erik Joelsson
Since X11 and freetype aren't available on Macosx by default, and we (Oracle) are now shipping OpenJDK builds for Macosx, we need to start bundling freetype on Macosx, just like we do on Windows. This patch adds a new freetype bundle as a dependency for Macosx builds. It also updates the

Re: RFR: JDK-8192816 Let run-test save exit code

2017-11-30 Thread Tim Bell
Magnus: Looks good. On well-behaving unix systems, tr -c '[a-z]' '_' would take the complement of a-z and replace it by underscore. But on solaris, -c [a-z] would evaluate to a (not clearly defined) massive string of all characters except a-z in the current locale. I wish we could get away

Re: RFR: JDK-8139653: Freetype bundled on macosx, but not correctly linked

2017-11-30 Thread Philip Race
Looks good .. and worked for me when I tested with --enable-freetype-bundling. I used otool to verify the rpath used by fontmanager and used vmmap to verify an executing process was picking up freetype from the JDK's lib. So when we do bundle freetype then it should work as expected. -phil.

Re: RFR: JDK-8139653: Freetype bundled on macosx, but not correctly linked

2017-11-30 Thread Tim Bell
Erik: When building macosx openjdk and enabling bundling of freetype (which is usually not the default), the makefiles will copy the library in, but libfontmanager will not be able to link to it at runtime. This is caused by a peculiarity on macosx where a library that is being linked to

How to disable JVM features?

2017-11-30 Thread Vladimir Ivanov
Hi, I'm curious is there a way to disable JVM features from the default list. Configure mentions --with-jvm-features [1], but it doesn't allow to remove features which are enabled by default (tried to override the list, but it didn't work). Thanks! Best regards, Vladimir Ivanov [1]

Re: RFR: JDK-8192816 Let run-test save exit code

2017-11-30 Thread Erik Joelsson
Looks good. / On 2017-11-30 06:09, Magnus Ihse Bursie wrote: To support all the use cases of the old test/Makefile way of running tests, we need to save the exit code from running tests. This patch also includes three other bug fixes: * Saving the test ID:s of the latest run in

RFR: JDK-8192816 Let run-test save exit code

2017-11-30 Thread Magnus Ihse Bursie
To support all the use cases of the old test/Makefile way of running tests, we need to save the exit code from running tests. This patch also includes three other bug fixes: * Saving the test ID:s of the latest run in test-last-ids.txt, so we can programmatically discover which new tests were