Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-01-24 Thread David Holmes
Hi Magnus, On 25/01/2018 9:55 AM, Magnus Ihse Bursie wrote: I'm not sure I'm able to follow where this discussion is heading, but at the very least I'd like to chime in on the patch below: I don't like how the entire DISABLED_WARNINGS_gcc line is lifted out. A better solution is something lik

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-01-24 Thread Magnus Ihse Bursie
I'm not sure I'm able to follow where this discussion is heading, but at the very least I'd like to chime in on the patch below: I don't like how the entire DISABLED_WARNINGS_gcc line is lifted out. A better solution is something like this: ifeq ($(CC_VERSION_NUMBER), 4.8.5)  #Turn off array-