Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-02-01 Thread Erik Joelsson
Hello, Oracle still builds JDK 10 and 11 using Xcode 6.3 using the Macosx10.9 sdk. We are warning free there. Using newer versions of Xcode is known to produce warnings. I'm currently in the process of updating the toolchain versions and platforms we use at Oracle so this should get fixed

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-02-01 Thread Alan Snyder
> On Feb 1, 2018, at 9:05 AM, Erik Joelsson wrote: > > Regarding warning chasing. I agree that we it's not feasible to chase down > every warning in every version of GCC, or any other toolchain, but I also > think that for platforms/configurations where people are

Re: Proposal: Make custom extension point additions

2018-02-01 Thread Erik Joelsson
Hello Andrew, This looks good to me. I've created https://bugs.openjdk.java.net/browse/JDK-8196585 and will push it for you. /Erik On 2018-02-01 08:52, Andrew Leonard wrote: Thanks Erik, I have moved the "post" hooks after the ###'s as you mentioned and similarly to the end for

Re: Proposal: Make custom extension point additions

2018-02-01 Thread Andrew Leonard
Thanks Erik, I have moved the "post" hooks after the ###'s as you mentioned and similarly to the end for GensrcVarHandles.gmk. Here is the new hg diff -g patch, I have built it with the latest jdk head and run the jtreg tests successfully. Cheers Andrew diff --git

Re: RFR: JDK-8195689 Remove generated-configure.sh and instead use autoconf

2018-02-01 Thread Erik Joelsson
This version looks good to me. /Erik On 2018-01-25 13:33, Magnus Ihse Bursie wrote: On 2018-01-18 19:37, Erik Joelsson wrote: Hello Magnus, Nice to see this finally happening! Thanks! In building.md, when getting autoconf for Cygwin, I believe you also need the autoconf wrapper scripts

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Gary Adams
Here's a revised webrev http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html Still testing ... Using shutdown() fixed problems reported by the java/nio/channelSocketChannel tests. I also noticed prior use of getaddrinfo for "localhost" was not calling freeaddrinfo. ... On

Re: RFR: JDK-8196524: Align MaxRAMPercentage settings between open and closed

2018-02-01 Thread Tim Bell
Erik: Looks good to me as well. Thanks. /Tim Looks fine. Thanks, David On 1/02/2018 10:29 AM, Erik Joelsson wrote: New webrev addressing concerns from both Tim and David. http://cr.openjdk.java.net/~erikj/8196524/webrev.02/ /Erik On 2018-01-31 15:52, Erik Joelsson wrote: An internal

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Gary Adams
On 2/1/18, 6:59 AM, Langer, Christoph wrote: But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it? I still don't see the reason... vs2013 include/um/winsock2.h has WSASendDisconnect deprecated. .../src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c(230) :

RE: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Langer, Christoph
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it? I still don't see the reason... -Original Message- From: gary.ad...@oracle.com [mailto:gary.ad...@oracle.com] Sent: Donnerstag, 1. Februar 2018 12:17 To: Langer, Christoph ; OpenJDK

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-02-01 Thread John Paul Adrian Glaubitz
On 02/01/2018 12:36 PM, Adam Farley8 wrote: After doing some experimenting, I've discovered the problem isn't limited to SLES, or gcc 4.8.5, or zLinux. (...) Thoughts? I think the problem is more that if you are trying to silence warnings, you will end up being busy for a very long time since

Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c

2018-02-01 Thread Adam Farley8
Hi All, After doing some experimenting, I've discovered the problem isn't limited to SLES, or gcc 4.8.5, or zLinux. Platforms affected: zLinux, ppcle Linux Platforms not affected: x86 Linux gcc versions affected: 4.8.5, 5.4.0 gcc versions unaffected: 7.2.1 linux variations affected: Ubuntu,

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread gary.ad...@oracle.com
First pass over the code I disabled the compilation flag and then did quick substitution for the easier functions. I commented out the WSASendDisconnect calls so I could see what tests would fail if the function was just removed. I have a replacement now that uses "shutdown(fd,SD_SEND)", but I

RE: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread Langer, Christoph
Hi Gary, I was having a look at your changes. I'm wondering what the reason is behind uncommenting WSASendDisconnect in Java_sun_nio_ch_SocketDispatcher_preClose0 of file SocketDispatcher.c? And in dbgsysSocketClose? In socketTransport.c, line: 331 setLastError(0,